Re: [PATCH v2] efi: Fix stack protector issues

2024-02-29 Thread Glenn Washburn
On Wed, 17 Jan 2024 06:10:29 +0300 "Vladimir 'phcoder' Serbinenko" wrote: > Looks good. A small comment inline > > > diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c > > index 731c07c29..5db504e6e 100644 > > --- a/grub-core/kern/main.c > > +++ b/grub-core/kern/main.c > > @@ -265,6 +265

Re: [PATCH v2] efi: Fix stack protector issues

2024-01-16 Thread Vladimir 'phcoder' Serbinenko
Looks good. A small comment inline > diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c > index 731c07c29..5db504e6e 100644 > --- a/grub-core/kern/main.c > +++ b/grub-core/kern/main.c > @@ -265,6 +265,11 @@ reclaim_module_space (void) > void __attribute__ ((noreturn)) > grub_main (void)

Re: [PATCH v2] efi: Fix stack protector issues

2024-01-15 Thread Glenn Washburn
On Fri, 12 Jan 2024 18:42:19 +0100 Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The 'ground truth' stack protector cookie value is kept in a global > variable, and loaded in every function prologue and epilogue to store > it into resp. compare it with the stack slot holding the cookie. Wha