Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-29 Thread Matthew Garrett
On Tue, Nov 27, 2018 at 8:37 AM Daniel Kiper wrote: > > On Mon, Nov 26, 2018 at 05:00:03PM +1100, Matthew Garrett wrote: > > The implementation here should work fine with TPM 1.2, so the only > > Hmmm... IIRC UEFI interface only supports TPM 2.0. However, there is > a chance that I am missing some

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-27 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 05:00:03PM +1100, Matthew Garrett wrote: > On Mon, Nov 26, 2018 at 4:47 PM Daniel Kiper wrote: > > > I have a feeling that both UEFI and TIS TPM implementations can coexists > > together even on UEFI platform. Of course, AIUI, UEFI TPM should be default > > if we play with

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-25 Thread Matthew Garrett
On Mon, Nov 26, 2018 at 4:47 PM Daniel Kiper wrote: > I have a feeling that both UEFI and TIS TPM implementations can coexists > together even on UEFI platform. Of course, AIUI, UEFI TPM should be default > if we play with TPM 2.0. TIS implementation should be used with TPM 1.2 > or if UEFI is bu

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-25 Thread Matthew Garrett
On Tue, Nov 20, 2018 at 10:59 AM Matthew Garrett wrote: > > On Mon, Nov 19, 2018 at 1:13 AM Daniel P. Smith wrote: > > > > It would be great if the TPM commands that are using EFI protocol and > > exposed to TPM command module be name spaced under efi, e.g. > > grub_efi_tpm_log_event. As I lay in

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 10:59:18AM +1100, Matthew Garrett wrote: > On Mon, Nov 19, 2018 at 1:13 AM Daniel P. Smith wrote: > > > > It would be great if the TPM commands that are using EFI protocol and > > exposed to TPM command module be name spaced under efi, e.g. > > grub_efi_tpm_log_event. As I

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-19 Thread Matthew Garrett
On Mon, Nov 19, 2018 at 1:13 AM Daniel P. Smith wrote: > > It would be great if the TPM commands that are using EFI protocol and > exposed to TPM command module be name spaced under efi, e.g. > grub_efi_tpm_log_event. As I lay in a TIS implementation, I can mimic a > similar set of tis name spaced

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-19 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 03:24:53PM -0800, Matthew Garrett wrote: > From: Matthew Garrett > > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. In future we might > want to have some sort of mechanism for choosing which eve

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-18 Thread Daniel P. Smith
On 11/14/2018 06:24 PM, Matthew Garrett wrote: > From: Matthew Garrett > > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. In future we might > want to have some sort of mechanism for choosing which events get logged >