Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-15 Thread Goffredo Baroncelli
On 05/14/2018 09:07 PM, Daniel Kiper wrote: > On Mon, May 14, 2018 at 08:57:10PM +0200, Daniel Kiper wrote: >> On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: [...] >>> static grub_err_t >>> -grub_raid6_recover (struct grub_diskfilter_segment *array, int disknr, int >>> p, >>

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-15 Thread Daniel Kiper
On Mon, May 14, 2018 at 10:52:11PM +0200, Goffredo Baroncelli wrote: > On 05/14/2018 08:57 PM, Daniel Kiper wrote: > > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > [...] > > > >> + char *buf, grub_uint64_t sector, grub_size_t size, > >> +

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Goffredo Baroncelli
On 05/14/2018 08:57 PM, Daniel Kiper wrote: > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: [...] > >> +char *buf, grub_uint64_t sector, grub_size_t size, >> +raid_recover_read_t read_func, int layout) > > s/read_func/read_nod

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Daniel Kiper
On Mon, May 14, 2018 at 08:57:10PM +0200, Daniel Kiper wrote: > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > > The original grub code which handles the recovery of a raid6 disks array > > assumes that all the read are multiple of 1 << GRUB_DISK_SECTOR_BITS and > > s/the re

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > The original grub code which handles the recovery of a raid6 disks array > assumes that all the read are multiple of 1 << GRUB_DISK_SECTOR_BITS and s/the read/reads/ > it also assumes that all the I/O is done via the struct >