Re: [PATCH 7/7] serial: Add ability to specify MMIO ports via 'serial'

2022-12-21 Thread Benjamin Herrenschmidt
On Wed, 2022-12-21 at 15:11 +0100, Daniel Kiper wrote: > > +  if (!port && grub_memcmp (name, "mmio,", sizeof ("mmio,") - 1) == 0 > > I think grub_strncmp() in string context would be more appropriate. > Please replace grub_memcmp() with grub_strncmp() where possible. Same comment as patch 3, thi

Re: [PATCH 7/7] serial: Add ability to specify MMIO ports via 'serial'

2022-12-21 Thread Daniel Kiper
On Fri, Dec 02, 2022 at 10:05:26AM +1100, Benjamin Herrenschmidt wrote: > From: Benjamin Herrenschmidt > > This adds the ability to explicitely add an MMIO based serial port > via the 'serial' command. The syntax is: > > serial --port=mmio,{.b,.w,.l,.q} > > Signed-off-by: Benjamin Herrenschmidt >