Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread bibo,mao
Johan Rydberg wrote: Johan Rydberg <[EMAIL PROTECTED]> writes: > This code can be shorter; you only have to compare the lengths. If > they match, you can do a memcmp on the whole device path. It could look something like this; /* Returns zero if device path SUBPATH is a subpath of device p

Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread Johan Rydberg
Johan Rydberg <[EMAIL PROTECTED]> writes: > This code can be shorter; you only have to compare the lengths. If > they match, you can do a memcmp on the whole device path. It could look something like this; /* Returns zero if device path SUBPATH is a subpath of device path PATH. */ static i

Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread Johan Rydberg
"bibo,mao" <[EMAIL PROTECTED]> writes: > Previously I posted this patch, now I repost again. > Any suggestion is welcome. I will just give a comment here. Please do not treat it as a full review, I'll leave that to Okuji. > +static int compare_ancestor_path(const grub_efi_device_path_t *paren