Re: [PATCH 1/4] Add new "version" command

2018-04-05 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 04:50:25PM +0200, Hans de Goede wrote: > Add a new "version" command which prints the grub PACKAGE_STRING + > build time and date. This is useful to check if the expected version is > running, for e.g. trouble-shooting purposes. If you really need this I would consider sett

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Olaf Hering
On Thu, Mar 29, Hans de Goede wrote: > I don't think there is much value in it and I don't feel > like spending time on this to come up with another solution. Not sure what you are trying to fix. At least for me the version is shown all the time at the top. And the buildtime does not add any valu

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Hans de Goede
Hi, On 29-03-18 09:53, Olaf Hering wrote: On Wed, Mar 28, Hans de Goede wrote: + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); NACK. Debian sells something what they call "reproducible build". Check their website why usage of __DATE__ and __TIME__ is a bad thing. S

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Thomas Schmitt
Hi, Hans de Goede wrote: > > + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); Olaf Hering wrote: > Debian sells something what they call "reproducible build". It's not actually a Debian thing, although some Debian Developers seem to have initiated it and urge people to m

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Olaf Hering
On Wed, Mar 28, Hans de Goede wrote: > + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); NACK. Debian sells something what they call "reproducible build". Check their website why usage of __DATE__ and __TIME__ is a bad thing. SUSE does not want to republish an otherwise u