Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-14 Thread Petr Vorel
Hi Daniel, ... > > > +/* > > > + * Fix for glibc 2.25 is deprecating the namespace pollution of > > > sys/types.h > > > + * injecting major(), minor(), and makedev() into the compilation > > > environment. > > > + * See configure.ac. > > It seems to me "See configure.ac." is not relevant in the

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-14 Thread Petr Vorel
Hi Daniel, > On Wed, Jul 14, 2021 at 08:54:29AM +0200, Petr Vorel wrote: > > Hi Daniel, > > > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > > > Signed-off-by: Petr Vorel > > > > > --- > > > > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > > > > grub-core/osdep/de

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-14 Thread Daniel Kiper
On Wed, Jul 14, 2021 at 08:54:29AM +0200, Petr Vorel wrote: > Hi Daniel, > > > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > > Signed-off-by: Petr Vorel > > > > --- > > > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > > > grub-core/osdep/devmapper/hostdisk.c | 7 +

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Petr Vorel
Hi Daniel, > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > Signed-off-by: Petr Vorel > > > --- > > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > > > grub-core/osdep/linux/getroot.c | 7 +-- > > > gr

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Petr Vorel
> On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > Signed-off-by: Petr Vorel > > --- > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > > grub-core/osdep/linux/getroot.c | 7 +-- > > grub-core/osdep/unix/getroot

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Daniel Kiper
On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > Signed-off-by: Petr Vorel > --- > grub-core/osdep/devmapper/getroot.c | 7 +-- > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > grub-core/osdep/linux/getroot.c | 7 +-- > grub-core/osdep/unix/getroot.c | 7