Re: [PATCH 1/2] luks2: Improve error reporting when decrypting/verifying key

2020-04-16 Thread Patrick Steinhardt
On Thu, Apr 16, 2020 at 11:52:17AM +0200, Daniel Kiper wrote: > On Wed, Apr 15, 2020 at 10:52:53PM +0200, Patrick Steinhardt wrote: > > On Tue, Apr 14, 2020 at 08:12:22PM +0200, Daniel Kiper wrote: > > > On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote: > > > > While we already se

Re: [PATCH 1/2] luks2: Improve error reporting when decrypting/verifying key

2020-04-16 Thread Daniel Kiper
On Wed, Apr 15, 2020 at 10:52:53PM +0200, Patrick Steinhardt wrote: > On Tue, Apr 14, 2020 at 08:12:22PM +0200, Daniel Kiper wrote: > > On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote: > > > While we already set up error messages in both `luks2_verify_key()` and > > > `luks2_decr

Re: [PATCH 1/2] luks2: Improve error reporting when decrypting/verifying key

2020-04-15 Thread Patrick Steinhardt
On Tue, Apr 14, 2020 at 08:12:22PM +0200, Daniel Kiper wrote: > On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote: > > While we already set up error messages in both `luks2_verify_key()` and > > `luks2_decrypt_key()`, we do not ever print them. This makes it really > > hard to disc

Re: [PATCH 1/2] luks2: Improve error reporting when decrypting/verifying key

2020-04-14 Thread Daniel Kiper
On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote: > While we already set up error messages in both `luks2_verify_key()` and > `luks2_decrypt_key()`, we do not ever print them. This makes it really > hard to discover why a given key actually failed to decrypt a disk. > > Improve th