Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 10:46:16PM +0300, Andrei Borzenkov wrote: > >> I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do > >> not know how to load standalone image on ppc; is it possible to use QEMU > >> to run ARM64 (I assume you have it)? If not what are options to test it? >

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-03-01 Thread Andrei Borzenkov
01.03.2016 20:11, Leif Lindholm пишет: > On 24 February 2016 at 17:40, Andrei Borzenkov wrote: >> 24.02.2016 16:57, Leif Lindholm пишет: >>> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: >> Could you test attached patch with your alignment fixes on top. This >> implemen

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-03-01 Thread Leif Lindholm
On 24 February 2016 at 17:40, Andrei Borzenkov wrote: > 24.02.2016 16:57, Leif Lindholm пишет: >> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: > Could you test attached patch with your alignment fixes on top. This > implements my idea of using shared buffers. Seems to

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 févr. 2016 14:48, Andrei Borzenkov a écrit : > On Fri, Feb 26, 2016 at 4:27 PM, Vladimir 'phcoder' Serbinenko > wrote: > > Andrei, your patch is pretty complicated and would be a subject to > putting > > into next branch because of its breakage potential. Issue at hand affects > > x86

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-26 Thread Andrei Borzenkov
On Fri, Feb 26, 2016 at 4:27 PM, Vladimir 'phcoder' Serbinenko wrote: > Andrei, your patch is pretty complicated and would be a subject to putting > into next branch because of its breakage potential. Issue at hand affects > x86 as well. Can we split the solution from radical rework of disk.c with

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-26 Thread Vladimir 'phcoder' Serbinenko
Andrei, your patch is pretty complicated and would be a subject to putting into next branch because of its breakage potential. Issue at hand affects x86 as well. Can we split the solution from radical rework of disk.c with optimisations? Le mer. 24 févr. 2016 20:04, Andrei Borzenkov a écrit : >

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-24 Thread Andrei Borzenkov
24.02.2016 20:40, Andrei Borzenkov пишет: > 24.02.2016 16:57, Leif Lindholm пишет: >> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: > Could you test attached patch with your alignment fixes on top. This > implements my idea of using shared buffers. Seems to work in naive

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-24 Thread Andrei Borzenkov
24.02.2016 16:57, Leif Lindholm пишет: > On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: Could you test attached patch with your alignment fixes on top. This implements my idea of using shared buffers. Seems to work in naive testing. >>> >>> Testing this with a grub-mkst

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-24 Thread Leif Lindholm
On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: > >> Could you test attached patch with your alignment fixes on top. This > >> implements my idea of using shared buffers. Seems to work in naive testing. > > > > Testing this with a grub-mkstandalone image, I get: > > > > kern/dl.c:

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-24 Thread Andrei Borzenkov
On Wed, Feb 24, 2016 at 2:59 PM, Leif Lindholm wrote: > On Mon, Feb 22, 2016 at 07:56:25PM +0300, Andrei Borzenkov wrote: >> 22.02.2016 17:02, Leif Lindholm пишет: >> > On Mon, Feb 22, 2016 at 10:57:24AM +0300, Andrei Borzenkov wrote: >> >> 19.02.2016 19:18, Leif Lindholm пишет: >> >>> Some disk t

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-24 Thread Leif Lindholm
On Mon, Feb 22, 2016 at 07:56:25PM +0300, Andrei Borzenkov wrote: > 22.02.2016 17:02, Leif Lindholm пишет: > > On Mon, Feb 22, 2016 at 10:57:24AM +0300, Andrei Borzenkov wrote: > >> 19.02.2016 19:18, Leif Lindholm пишет: > >>> Some disk types have allocation requirements beyond normal grub_malloc.

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-22 Thread Andrei Borzenkov
22.02.2016 17:02, Leif Lindholm пишет: > On Mon, Feb 22, 2016 at 10:57:24AM +0300, Andrei Borzenkov wrote: >> 19.02.2016 19:18, Leif Lindholm пишет: >>> Some disk types have allocation requirements beyond normal grub_malloc. >>> Add a function pointer to grub_disk_t and a wrapper function in >>> ke

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-22 Thread Vladimir 'phcoder' Serbinenko
Rather than having extra code in all drivers, just put it in common init like we do with log sector size On Mon, 22 Feb 2016 17:59 Andrei Borzenkov wrote: > 19.02.2016 19:18, Leif Lindholm пишет: > > Some disk types have allocation requirements beyond normal grub_malloc. > > Add a function point

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-22 Thread Andrei Borzenkov
19.02.2016 19:18, Leif Lindholm пишет: > Some disk types have allocation requirements beyond normal grub_malloc. > Add a function pointer to grub_disk_t and a wrapper function in > kern/disk.c making use of that function if available, to enable these > disk drivers to implement their own malloc. >

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-22 Thread Leif Lindholm
On Mon, Feb 22, 2016 at 10:57:24AM +0300, Andrei Borzenkov wrote: > 19.02.2016 19:18, Leif Lindholm пишет: > > Some disk types have allocation requirements beyond normal grub_malloc. > > Add a function pointer to grub_disk_t and a wrapper function in > > kern/disk.c making use of that function if a

Re: [PATCH 1/2] disk: Add support for device-specific malloc function

2016-02-21 Thread Andrei Borzenkov
19.02.2016 19:18, Leif Lindholm пишет: > Some disk types have allocation requirements beyond normal grub_malloc. > Add a function pointer to grub_disk_t and a wrapper function in > kern/disk.c making use of that function if available, to enable these > disk drivers to implement their own malloc. T