Re: [PATCH 1/2] Verify commands executed by grub

2017-07-24 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 22, 2017, 00:13 Matthew Garrett wrote: > On Fri, Jul 21, 2017 at 7:39 AM, Vladimir 'phcoder' Serbinenko > wrote: > > This omits all separators. So it considers e.g. ab and a b to be the > same. > > Can we have a better array serialization? I.a. following 3 need to be > > distinguishe

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Matthew Garrett
On Fri, Jul 21, 2017 at 7:39 AM, Vladimir 'phcoder' Serbinenko wrote: > This omits all separators. So it considers e.g. ab and a b to be the same. > Can we have a better array serialization? I.a. following 3 need to be > distinguished: > ab > a b > "a b" It inserts a space after each argv, so I t

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Vladimir 'phcoder' Serbinenko
On Wed, Jul 5, 2017, 23:26 Matthew Garrett wrote: > Pass commands to the verification code. We want to be able to log these > in the TPM verification case. > --- > grub-core/script/execute.c | 27 --- > include/grub/verify.h | 1 + > 2 files changed, 25 insertions(+

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Javier Martinez Canillas
On 07/05/2017 11:19 PM, Matthew Garrett wrote: > Pass commands to the verification code. We want to be able to log these > in the TPM verification case. > --- > grub-core/script/execute.c | 27 --- > include/grub/verify.h | 1 + > 2 files changed, 25 insertions(+), 3