Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-11 Thread Petr Vorel
Hi Milan, ... > > GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that > > necessary > > modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually > > -before this command can be used. > > +before this command can be used. For LUKS2 only the PBKDF2 key derival

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-11 Thread Milan Broz
On 03/02/2021 12:02, Petr Vorel wrote: > To give users hint why Argon2 (the default in cryptsetup for LUKS2) > does not work. > > Signed-off-by: Petr Vorel > --- > Hi, > > it'd be nice to have it for Grub 2.06. > > Kind regards, > Petr > > docs/grub.texi | 3 ++- > 1 file changed, 2 insertion

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-03 Thread Petr Vorel
Hi Paul, Patrick, > Dear Petr, > Thank you for your patch. thanks for your review! ... > > -before this command can be used. > > +before this command can be used. For LUKS2 only the PBKDF2 key derival > > +function is supported (Argon2 is not yet supported). > Nit: I’d get rid of the parenthes

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-03 Thread Paul Menzel
Dear Petr, Thank you for your patch. Am 03.02.21 um 12:02 schrieb Petr Vorel: To give users hint why Argon2 (the default in cryptsetup for LUKS2) does not work. Signed-off-by: Petr Vorel --- […] docs/grub.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

2021-02-03 Thread Patrick Steinhardt
On Wed, Feb 03, 2021 at 12:02:19PM +0100, Petr Vorel wrote: > To give users hint why Argon2 (the default in cryptsetup for LUKS2) > does not work. > > Signed-off-by: Petr Vorel Reviewed-by: Patrick Steinhardt > --- > Hi, > > it'd be nice to have it for Grub 2.06. > > Kind regards, > Petr Ma