Re: [PATCH] zero-fill entry before asking BIOS for memory map

2009-09-03 Thread Robert Millan
On Fri, Aug 28, 2009 at 09:21:02PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> +     /* clear the request area, buggy BIOSes may not clear it */ > >> +     xor     %edi, %edi > >> +     movl    %edi, 4(%eax) > >> +     movl    %edi, 8(%eax) > >> +     movl    %edi, 12(%eax) > >> +     movl    

Re: [PATCH] zero-fill entry before asking BIOS for memory map

2009-08-28 Thread Vladimir 'phcoder' Serbinenko
>> +     /* clear the request area, buggy BIOSes may not clear it */ >> +     xor     %edi, %edi >> +     movl    %edi, 4(%eax) >> +     movl    %edi, 8(%eax) >> +     movl    %edi, 12(%eax) >> +     movl    %edi, 16(%eax) >> +     movl    %edi, 20(%eax) > > This effectively hardcodes sizeof(entry)

Re: [PATCH] zero-fill entry before asking BIOS for memory map

2009-07-25 Thread Robert Millan
On Thu, Jul 23, 2009 at 05:31:57PM -0400, Pavel Roskin wrote: > On Thu, 2009-07-23 at 11:38 +0200, Vladimir 'phcoder' Serbinenko wrote: > > Hello. According to xen some BIOSes update only lower 32-bit in mmap > > entries. To workaround this and not get high values in memory map > > zero-fill before

Re: [PATCH] zero-fill entry before asking BIOS for memory map

2009-07-23 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 23, 2009 at 11:31 PM, Pavel Roskin wrote: > On Thu, 2009-07-23 at 11:38 +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. According to xen some BIOSes update only lower 32-bit in mmap >> entries. To workaround this and not get high values in memory map >> zero-fill before calling BI

Re: [PATCH] zero-fill entry before asking BIOS for memory map

2009-07-23 Thread Pavel Roskin
On Thu, 2009-07-23 at 11:38 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. According to xen some BIOSes update only lower 32-bit in mmap > entries. To workaround this and not get high values in memory map > zero-fill before calling BIOS I think the fix belongs to grub_get_mmap_entry(), not t