Re: [PATCH] savedefault

2009-06-11 Thread Pavel Roskin
Quoting Robert Millan : + saved_entry=\${chosen_entry} + save_env saved_entry EOF prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/" cat << EOF I think it'd really be a good idea to either factorize this into a function (ala prepare_grub_to_access_device), or make it

Re: [PATCH] savedefault

2009-06-11 Thread Robert Millan
Hi! On Mon, Jun 01, 2009 at 12:48:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > cat << EOF > +load_env > set default=${GRUB_DEFAULT} Does the "set" line override the settings in load_env? It looks like it would. > --- a/util/grub.d/10_freebsd.in > +++ b/util/grub.d/10_freebsd.in > @@ -5

Re: [PATCH] savedefault

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
Hello On Mon, Jun 8, 2009 at 9:37 AM, Bean wrote: > On Sun, Jun 7, 2009 at 10:51 PM, Vladimir 'phcoder' > Serbinenko wrote: >> Hello. Welcome back >> >> On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: >>> Hi, >>> >>> Actually, I'm thinking about a more generic method to implement this >>> feature wit

Re: [PATCH] savedefault

2009-06-08 Thread Bean
On Sun, Jun 7, 2009 at 10:51 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello. Welcome back > > On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: >> Hi, >> >> Actually, I'm thinking about a more generic method to implement this >> feature with events. The menu viewer fire events at certain >> circumstan

Re: [PATCH] savedefault

2009-06-07 Thread Vladimir 'phcoder' Serbinenko
Hello. Welcome back On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: > Hi, > > Actually, I'm thinking about a more generic method to implement this > feature with events. The menu viewer fire events at certain > circumstance, and we can configure the commands to execute. For > example, we could have a

Re: [PATCH] savedefault

2009-06-07 Thread Bean
Hi, Actually, I'm thinking about a more generic method to implement this feature with events. The menu viewer fire events at certain circumstance, and we can configure the commands to execute. For example, we could have a menu.select event fire when a menu item is selected, and use something like

Re: [PATCH] savedefault

2009-06-07 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 7, 2009 at 9:50 AM, Felix Zielcke wrote: > Am Montag, den 01.06.2009, 12:48 +0200 schrieb Vladimir 'phcoder' > Serbinenko: >> Hello. Here is a long-awaited savedefault patch. Works correctly only >> if my scripting fix is applied > > What happens if this is used on RAID? Then writing is

Re: [PATCH] savedefault

2009-06-07 Thread Felix Zielcke
Am Montag, den 01.06.2009, 12:48 +0200 schrieb Vladimir 'phcoder' Serbinenko: > Hello. Here is a long-awaited savedefault patch. Works correctly only > if my scripting fix is applied What happens if this is used on RAID? Especially when the grubenv file is wrapped by the chunksize? We should consi