Re: [PATCH] save_env variable_name=value

2009-09-12 Thread Pavel Roskin
On Sat, 2009-09-12 at 09:54 -0500, richardvo...@gmail.com wrote: > On Fri, Sep 11, 2009 at 4:43 PM, Pavel Roskin wrote: > > I don't see how grub-mkconfig could compensate for a missing feature in > > save_env. Perhaps I'm missing the context here. > > AFAICT, it's grub.cfg that has to work aroun

Re: [PATCH] save_env variable_name=value

2009-09-12 Thread richardvo...@gmail.com
On Fri, Sep 11, 2009 at 4:43 PM, Pavel Roskin wrote: > On Thu, 2009-09-03 at 17:08 +0200, Robert Millan wrote: > >> Pavel, please comment on this when you can.  It seems to me that doing it >> in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it >> more efficient. > > I don't

Re: [PATCH] save_env variable_name=value

2009-09-12 Thread Colin Watson
On Fri, Sep 11, 2009 at 05:43:06PM -0400, Pavel Roskin wrote: > On Thu, 2009-09-03 at 17:08 +0200, Robert Millan wrote: > > Pavel, please comment on this when you can. It seems to me that doing it > > in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it > > more efficient. >

Re: [PATCH] save_env variable_name=value

2009-09-12 Thread Robert Millan
On Fri, Sep 11, 2009 at 05:43:06PM -0400, Pavel Roskin wrote: > On Thu, 2009-09-03 at 17:08 +0200, Robert Millan wrote: > > > Pavel, please comment on this when you can. It seems to me that doing it > > in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it > > more efficient.

Re: [PATCH] save_env variable_name=value

2009-09-11 Thread Pavel Roskin
On Thu, 2009-09-03 at 17:08 +0200, Robert Millan wrote: > Pavel, please comment on this when you can. It seems to me that doing it > in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it > more efficient. I don't see how grub-mkconfig could compensate for a missing feature i

Re: [PATCH] save_env variable_name=value

2009-09-03 Thread Robert Millan
On Thu, Sep 03, 2009 at 03:52:43PM +0100, Colin Watson wrote: > On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote: > > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote: > > > 2009-09-02 Colin Watson > > > > > > * commands/loadenv.c (grub_cmd_save_env): Allow an optiona

Re: [PATCH] save_env variable_name=value

2009-09-03 Thread Colin Watson
On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote: > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote: > > 2009-09-02 Colin Watson > > > > * commands/loadenv.c (grub_cmd_save_env): Allow an optional > > explicit value (`save_env variable_name=value'). > > (GR

Re: [PATCH] save_env variable_name=value

2009-09-03 Thread Robert Millan
On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote: > This implements saving an environment variable with a given value > without having to set that variable first, as suggested by Pavel here: > > http://lists.gnu.org/archive/html/grub-devel/2009-06/msg00190.html > > 2009-09-02 Colin