Re: [PATCH] probe command

2009-06-15 Thread Vladimir 'phcoder' Serbinenko
Comitted On Wed, Jun 10, 2009 at 10:11 AM, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jun 9, 2009 at 11:48 PM, Pavel Roskin wrote: >> On Tue, 2009-06-09 at 22:55 +0200, Vladimir 'phcoder' Serbinenko wrote: >> >>> > --target=partmap doesn't work on whole disks. >>> It was the intent. I'm norkin

Re: [PATCH] probe command

2009-06-10 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 9, 2009 at 11:48 PM, Pavel Roskin wrote: > On Tue, 2009-06-09 at 22:55 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > --target=partmap doesn't work on whole disks. >> It was the intent. I'm norking on nested partitions and consider the >> following situation: >> hd0 is subdivided by

Re: [PATCH] probe command

2009-06-09 Thread Pavel Roskin
On Tue, 2009-06-09 at 22:55 +0200, Vladimir 'phcoder' Serbinenko wrote: > > --target=partmap doesn't work on whole disks. > It was the intent. I'm norking on nested partitions and consider the > following situation: > hd0 is subdivided by pc partmap into > hd0,1 - linux > hd0,2 - solaris which is

Re: [PATCH] probe command

2009-06-09 Thread Vladimir 'phcoder' Serbinenko
> I can have a look how to fix it if you don't find a way.  Actually, I > would prefer separate options for targets, as in "search".  That would > be: > > -l --label > -u --fs_uuid > -p --partmap > -d --driver (instead of "provider") I was inspired by grub-probe but this way it's ok too > > --targe

Re: [PATCH] probe command

2009-06-09 Thread Pavel Roskin
On Tue, 2009-06-09 at 20:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > Following Pavel's suggestion to make uuid command I implemented probe > command similar to grub-probe Great! Please remove trailing whitespace. Please add missing space after "=" on line 64 in probe.c. The help doesn't lo