Re: [PATCH] password command implementation

2007-08-08 Thread Marco Gerards
Jordi Mallach <[EMAIL PROTECTED]> writes: > On Tue, Aug 07, 2007 at 02:17:16PM +0200, Julien Ranc wrote: >> - plain text passwords are indeed very insecure, but I kept them, as it was >> possible in Grub legacy. Should I remove them ? > > I think there's plenty of people who will have use for pla

Re: [PATCH] password command implementation

2007-08-07 Thread Yoshinori K. Okuji
Hello, > - md5.c/h comes from Grub Legacy, just a bit adapted to use Grub2 memory > functions (malloc, memset, endianness). Therefore, code works correctly, or > at least in a coherent way with respect to Grub Legacy. I can try to make > the code clearer if needed... Other code is made from scrat

Re: [PATCH] password command implementation

2007-08-07 Thread Jordi Mallach
On Tue, Aug 07, 2007 at 02:17:16PM +0200, Julien Ranc wrote: > - plain text passwords are indeed very insecure, but I kept them, as it was > possible in Grub legacy. Should I remove them ? I think there's plenty of people who will have use for plain, insecure passwords. The first security proble

Re: [PATCH] password command implementation

2007-08-07 Thread Marco Gerards
Julien RANC <[EMAIL PROTECTED]> writes: Hi, > Here is my first patch for Grub2, so I hope it won't be too bad, and > by advance, all my apologies for the probable errors ;-) So, please, > comment gently... I'll try... :-) > These 2 patch add support for the 'password' command, with the syntax >