Re: [PATCH] make partition active

2009-03-04 Thread Robert Millan
On Mon, Mar 02, 2009 at 11:52:13AM +0800, Bean wrote: > > Then we could use parttool syntax. Then parttype can be implemented like > > grub> parttool hd0,1 type=7 > > makeactive like: > > grub> parttool hd0,1 boot+ > > And it can even be done by one command > > grub> parttool hd0,1 boot+ type=7 > >

Re: [PATCH] make partition active

2009-03-01 Thread Bean
On Mon, Mar 2, 2009 at 5:20 AM, phcoder wrote: > Hello >>> >>> It's also possible to write a wrapper >>> parttool hd0,1 boot+ >>> >>> Which chooses the correct tool and launches it (a tool can be easily >>> registered as a pair of partition style name and a function). In this >>> case >>> we would

Re: [PATCH] make partition active

2009-03-01 Thread phcoder
Hello It's also possible to write a wrapper parttool hd0,1 boot+ Which chooses the correct tool and launches it (a tool can be easily registered as a pair of partition style name and a function). In this case we wouldn't even need separate command for different partition style. We have however t

Re: [PATCH] make partition active

2009-03-01 Thread Bean
On Thu, Feb 12, 2009 at 2:28 AM, phcoder wrote: > Pavel Roskin wrote: >> >> On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote: >>> >>> Here's the patch to add a replacement for old "makeactive" command >>> New syntax is >>> activate PARTITION >>> E.g. >>> activate hd0,1 >> >> Is it necessary to cha

Re: [PATCH] make partition active

2009-02-11 Thread phcoder
Pavel Roskin wrote: On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote: Here's the patch to add a replacement for old "makeactive" command New syntax is activate PARTITION E.g. activate hd0,1 Is it necessary to change the name? I think "makeactive" is a better name for what it does. Actually I

Re: [PATCH] make partition active

2009-02-11 Thread Pavel Roskin
On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote: > Here's the patch to add a replacement for old "makeactive" command > New syntax is > activate PARTITION > E.g. > activate hd0,1 Is it necessary to change the name? I think "makeactive" is a better name for what it does. Maybe we could use a mor