Am Donnerstag, den 14.08.2008, 20:27 +0200 schrieb Marco Gerards:
> This patch looks clean enough for me :-). If you can correct the
> following (and previous ;)) comments, it is ready to be committed.
>
Commited.
Hurray.
___
Grub-devel mailing lis
Hi Felix,
Felix Zielcke <[EMAIL PROTECTED]> writes:
[...]
> 2008-08-14 Felix Zielcke <[EMAIL PROTECTED]>
>
> * include/grub.err.h (grub_err_printf): New function prototype.
grub.err.h -> grub/err.h
> * util/misc.c (grub_err_printf): New function.
> * kern/misc.c [! GR
Robert Millan wrote:
> On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
>> +int
>> +grub_err_printf (const char *fmt, ...)
>> +{
>> + va_list ap;
>> + int ret;
>> +
>> + va_start (ap, fmt);
>> + ret = vfprintf (stderr, fmt, ap);
>> + va_end (ap);
>> +
>> + return ret;
>> +}
>>
On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
> +int
> +grub_err_printf (const char *fmt, ...)
> +{
> + va_list ap;
> + int ret;
> +
> + va_start (ap, fmt);
> + ret = vfprintf (stderr, fmt, ap);
> + va_end (ap);
> +
> + return ret;
> +}
> void *
> xmalloc (size_t size)
P
Am Donnerstag, den 14.08.2008, 09:13 +0200 schrieb Marco Gerards:
> So this patch isn't really required, but you want it for Lenny?
[EMAIL PROTECTED]
That's the one Robert and me thought could be something for lenny.
I have forgotten to merge the disk/raid.c changes which Robert wanted to
have i
Felix Zielcke <[EMAIL PROTECTED]> writes:
> Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke:
>>
>> This time dear Marco I didn't bother to read through the changelog, it
>> might be still not perfect and I'm even tired now.
>
> I should have better gone to bed instead of making q
On Thu, Aug 14, 2008 at 12:39:16AM +0200, Felix Zielcke wrote:
> --- util/err.c(Revision 0)
> +++ util/err.c(Revision 0)
> @@ -0,0 +1,41 @@
> +/* err.c - util error printing routine */
> +/*
> + * GRUB -- GRand Unified Bootloader
> + * Copyright (C) 2002,2005,2007 Free Software
Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke:
>
> This time dear Marco I didn't bother to read through the changelog, it
> might be still not perfect and I'm even tired now.
I should have better gone to bed instead of making quickly a patch for
this.
Well 2nd try now.
I forgot
Am Mittwoch, den 13.08.2008, 23:50 +0200 schrieb Robert Millan:
> If we can't do this in kern/err.c (although I really think it'd be simpler),
> adding a new util/err.c that can be used by grub-probe but not grub-mkimage
> would solve this.
Seems like I'm sometime really just too fast.
I should st
On Wed, Aug 13, 2008 at 10:31:36PM +0200, Felix Zielcke wrote:
>
> Yes this change is no problem, grub-probe now compiles fine
> But grub-mkimage not:
>
> grub_mkimage-util_misc.o: In function `grub_print_error':
> /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to
> `grub_error_pop
Am Mittwoch, den 13.08.2008, 22:31 +0200 schrieb Felix Zielcke:
> Am Mittwoch, den 13.08.2008, 11:47 +0200 schrieb Marco Gerards:
> > Felix Zielcke <[EMAIL PROTECTED]> writes:
> >
> > > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> > >> > * kern/err.c [GRUB_UTIL]: Includ
Am Mittwoch, den 13.08.2008, 11:47 +0200 schrieb Marco Gerards:
> Felix Zielcke <[EMAIL PROTECTED]> writes:
>
> > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> >> > * kern/err.c [GRUB_UTIL]: Include .
> >
> >> Please don't do this. Why do you want this?
> >
> > It's nee
Felix Zielcke <[EMAIL PROTECTED]> writes:
> On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
>> > * kern/err.c [GRUB_UTIL]: Include .
>
>> Please don't do this. Why do you want this?
>
> It's needed for fprintf, and fprintf is only useful for GRUB_UTIL.
I understood that.
Robert Millan <[EMAIL PROTECTED]> writes:
> On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
>> > [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...)
>> > instead of
>> > grub_printf.
>>
>> Why?
>>
>> It would be better to make a util/misc.c:grub_print
On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> > * kern/err.c [GRUB_UTIL]: Include .
> Please don't do this. Why do you want this?
It's needed for fprintf, and fprintf is only useful for GRUB_UTIL.
> >"...reset grub_errno. Do not..."
> (double space)
Right, I should
On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> > [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead
> > of
> > grub_printf.
>
> Why?
>
> It would be better to make a util/misc.c:grub_print_error instead of this
Problem is that kern/err.c i
Felix Zielcke <[EMAIL PROTECTED]> writes:
> Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke:
>
> Ok naming the old patch kern_err.diff and the new one raid_err.diff
> isn't a good idea :(
>
>
> 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]>
>
> * kern/err.c [GRUB_UTIL]: In
Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke:
Ok naming the old patch kern_err.diff and the new one raid_err.diff
isn't a good idea :(
2008-08-12 Felix Zielcke <[EMAIL PROTECTED]>
* kern/err.c [GRUB_UTIL]: Include .
[GRUB_UTIL] (grub_print_error): Use fpri
18 matches
Mail list logo
