Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le jeu. 2 sept. 2021 à 11:08, Erwan Velu a écrit : > Le 01/09/2021 à 18:24, Daniel Kiper a écrit : > > First of all, thanks for your extensive review, I'll fix all this in a V2. > > [...] Just sent the V2, hope you'll enjoy this version of the patch. I learned many things on some GRUB internals a

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le 01/09/2021 à 18:24, Daniel Kiper a écrit : First of all, thanks for your extensive review, I'll fix all this in a V2. [...] Here you should add Signed-off-by of original author. Yeah, I was wondering that but the only email I have was from his previous company. I have no idea what email

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 02:32:48PM +0200, Erwan Velu wrote: > [...] > The ext_cmd change is cool except the linker isn't happy as it cannot find the > associated symbols. > I asked a question on the IRC channel on this point. > I'm not familiar with the dependencies definition in this project, wher

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
[...] The ext_cmd change is cool except the linker isn't happy as it cannot find the associated symbols. I asked a question on the IRC channel on this point. I'm not familiar with the dependencies definition in this project, where should I work to get ext_cmd being linked with kern/efi ? I tried in

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 11:08:47AM +0200, Erwan Velu wrote: > Le 01/09/2021 à 18:24, Daniel Kiper a écrit : > > First of all, thanks for your extensive review, I'll fix all this in a V2. Cool! > [...] > > Here you should add Signed-off-by of original author. > > Yeah, I was wondering that but the

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-01 Thread Daniel Kiper
On Mon, Aug 30, 2021 at 04:08:07PM +0200, Erwan Velu wrote: > This patch got written by Arthur Mesh from Juniper (now at Apple Sec team). > It was extracted from > https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html > > Since this email, the this patch was : > - rebased against the