Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-03-03 Thread Robert Millan
Okay here's a preliminar patch. We still need to define in which ways can the user interrupt it. What do we do on '\n' ? and on ESC ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) diff -x configure -x config.h

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-28 Thread Yoshinori K. Okuji
On Thursday 28 February 2008 11:57, Robert Millan wrote: > On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > > On Friday 08 February 2008 17:18, Robert Millan wrote: > > > Fixes an ugly result of setting timeout=0. > > > > > > When this is combined with the "sleep" patch I just

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-28 Thread Robert Millan
On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > On Friday 08 February 2008 17:18, Robert Millan wrote: > > Fixes an ugly result of setting timeout=0. > > > > When this is combined with the "sleep" patch I just sent, user can > > implement hiddenmenu-like functionality via scri

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Isaac Dupree
Yoshinori K. Okuji wrote: On Sunday 10 February 2008 13:55, Robert Millan wrote: We could make the behaviour be, that if ESC is pressed at any time before an input line is completed, the operation is aborted, read returns non-zero, and it doesn't save the line to any variable. What do you think

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 13:55, Robert Millan wrote: > We could make the behaviour be, that if ESC is pressed at any time before > an input line is completed, the operation is aborted, read returns > non-zero, and it doesn't save the line to any variable. What do you think? Not bad. :) > > In

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 08:10:13AM +0100, Yoshinori K. Okuji wrote: > On Saturday 09 February 2008 23:09, Robert Millan wrote: > > On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > > > On Friday 08 February 2008 17:18, Robert Millan wrote: > > > > Fixes an ugly result of setting

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-09 Thread Yoshinori K. Okuji
On Saturday 09 February 2008 23:09, Robert Millan wrote: > On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > > On Friday 08 February 2008 17:18, Robert Millan wrote: > > > Fixes an ugly result of setting timeout=0. > > > > > > When this is combined with the "sleep" patch I just

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-09 Thread Robert Millan
On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > On Friday 08 February 2008 17:18, Robert Millan wrote: > > Fixes an ugly result of setting timeout=0. > > > > When this is combined with the "sleep" patch I just sent, user can > > implement hiddenmenu-like functionality via scri

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-09 Thread Yoshinori K. Okuji
On Friday 08 February 2008 17:18, Robert Millan wrote: > Fixes an ugly result of setting timeout=0. > > When this is combined with the "sleep" patch I just sent, user can > implement hiddenmenu-like functionality via scripting: > > echo -n "Press `ESC' to enter the menu... " > if sleep -v -i 10 ; t

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-09 Thread Robert Millan
Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel