Re: ping (Re: [PATCH] grub-probefs --root-device)

2006-10-14 Thread Robert Millan
On Sat, Oct 14, 2006 at 09:04:32PM +0200, Robert Millan wrote: > > Committed, thanks! Btw, for --target=device and --target=drive, the new grub-probe command should also be usable on non-i386. I think we just need to disable some code. Any powerpc user wants to give that a try? -- Robert Mill

Re: ping (Re: [PATCH] grub-probefs --root-device)

2006-10-14 Thread Robert Millan
On Sat, Oct 14, 2006 at 12:10:49PM +0200, Yoshinori K. Okuji wrote: > On Saturday 14 October 2006 12:06, Robert Millan wrote: > > Ping :) > > Thank you for prompting me. ;) > > Please check it in. I have no objection. Committed, thanks! -- Robert Millan My spam trap is [EMAIL PROTECTED] Note

Re: ping (Re: [PATCH] grub-probefs --root-device)

2006-10-14 Thread Yoshinori K. Okuji
On Saturday 14 October 2006 12:06, Robert Millan wrote: > Ping :) Thank you for prompting me. ;) Please check it in. I have no objection. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

ping (Re: [PATCH] grub-probefs --root-device)

2006-10-14 Thread Robert Millan
Ping :) On Sun, Oct 01, 2006 at 09:27:59PM +0200, Robert Millan wrote: > > Is it alright for commit now? > > On Thu, Sep 28, 2006 at 04:39:56PM +0200, Robert Millan wrote: > > On Tue, Sep 26, 2006 at 08:29:33PM +0300, Vesa Jääskeläinen wrote: > > > Hi, > > > > > > Here are some comments about

Re: [PATCH] grub-probefs --root-device

2006-10-01 Thread Robert Millan
Is it alright for commit now? On Thu, Sep 28, 2006 at 04:39:56PM +0200, Robert Millan wrote: > On Tue, Sep 26, 2006 at 08:29:33PM +0300, Vesa Jääskeläinen wrote: > > Hi, > > > > Here are some comments about your patch. As requested :) > > Thanks for the corrections. Some of them make me ashame

Re: [PATCH] grub-probefs --root-device

2006-09-28 Thread Robert Millan
On Tue, Sep 26, 2006 at 08:29:33PM +0300, Vesa Jääskeläinen wrote: > Hi, > > Here are some comments about your patch. As requested :) Thanks for the corrections. Some of them make me ashamed, I should have looked better at all those grub-probefs instances... ;) > Robert Millan wrote: > > 2006-0

Re: [PATCH] grub-probefs --root-device

2006-09-26 Thread Vesa Jääskeläinen
Hi, Here are some comments about your patch. As requested :) Robert Millan wrote: > 2006-09-23 Robert Millan <[EMAIL PROTECTED]> > > * util/i386/pc/getroot.c (grub_guess_root_device): Stop using > grub_util_biosdisk_get_grub_dev to convert system device to GRUB device. > * ut

Re: [PATCH] grub-probefs --root-device

2006-09-25 Thread Robert Millan
On Sat, Sep 23, 2006 at 10:37:52AM +0200, Robert Millan wrote: > > Uhm actualy, I'll need this on non-i386 too. Can we enable grub-probe.c for > all > platforms? If the last part (about PC/BIOS translation) is i386-specific, > perhaps it could be conditionalised so that non-i386 can use > --tar

Re: [PATCH] grub-probefs --root-device

2006-09-23 Thread Robert Millan
Uhm actualy, I'll need this on non-i386 too. Can we enable grub-probe.c for all platforms? If the last part (about PC/BIOS translation) is i386-specific, perhaps it could be conditionalised so that non-i386 can use --target=(drive|device) ? -- Robert Millan My spam trap is [EMAIL PROTECTED]

Re: [PATCH] grub-probefs --root-device

2006-09-23 Thread Robert Millan
On Sat, Sep 23, 2006 at 05:20:37AM +0200, Yoshinori K. Okuji wrote: > > However, this usage is against the original meaning, thus the naming is not > appropriate any longer. In addition, I don't like that we make an ad-hoc text > output (the first line is a fs module name, the second line is a r

Re: [PATCH] grub-probefs --root-device

2006-09-22 Thread Yoshinori K. Okuji
On Friday 22 September 2006 18:33, Robert Millan wrote: > This would be very useful to get rid of ugly kludges in Debian, such as > this one: > > http://svn.debian.org/wsvn/pkg-grub/grub2/trunk/debian/update-grub?op=file&; >rev=0&sc=0 (look for convert() here) > > Fortunately grub-probefs is alre

Re: [PATCH] grub-probefs --root-device

2006-09-22 Thread Robert Millan
On Fri, Sep 22, 2006 at 06:33:13PM +0200, Robert Millan wrote: > > This would be very useful to get rid of ugly kludges in Debian, such as this > one: > > http://svn.debian.org/wsvn/pkg-grub/grub2/trunk/debian/update-grub?op=file&rev=0&sc=0 > (look for convert() here) > > Fortunately grub-pr