Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2015 15:15, Andrei Borzenkov wrote: On Fri, Feb 27, 2015 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 27.02.2015 13:06, Andrei Borzenkov wrote: On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 27.02.2015 12:47, Fajar A. Nugraha wrote:

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Andrei Borzenkov
On Fri, Feb 27, 2015 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 27.02.2015 13:06, Andrei Borzenkov wrote: >> >> On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko >> wrote: >>> >>> On 27.02.2015 12:47, Fajar A. Nugraha wrote: + lua_pushstring

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Vladimir 'phcoder' Serbinenko
Le 2015-02-27 13:48, "Fajar A. Nugraha" a écrit : > > On Fri, Feb 27, 2015 at 7:42 PM, Vladimir 'phcoder' Serbinenko > wrote: > > > > Le 2015-02-27 13:40, "Fajar A. Nugraha" a écrit : > > > > > >> > >> On Fri, Feb 27, 2015 at 7:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko > >> wrote: > >> > On

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Fajar A. Nugraha
On Fri, Feb 27, 2015 at 7:42 PM, Vladimir 'phcoder' Serbinenko wrote: > > Le 2015-02-27 13:40, "Fajar A. Nugraha" a écrit : > > >> >> On Fri, Feb 27, 2015 at 7:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko >> wrote: >> > On 27.02.2015 13:06, Andrei Borzenkov wrote: >> >> >> >> On Fri, Feb 27, 201

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Vladimir 'phcoder' Serbinenko
Le 2015-02-27 13:40, "Fajar A. Nugraha" a écrit : > > On Fri, Feb 27, 2015 at 7:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: > > On 27.02.2015 13:06, Andrei Borzenkov wrote: > >> > >> On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko > >> wrote: > >>> > >>> On 27.02

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Fajar A. Nugraha
On Fri, Feb 27, 2015 at 7:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 27.02.2015 13:06, Andrei Borzenkov wrote: >> >> On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko >> wrote: >>> >>> On 27.02.2015 12:47, Fajar A. Nugraha wrote: + lua_pushstring

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2015 13:06, Andrei Borzenkov wrote: On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 27.02.2015 12:47, Fajar A. Nugraha wrote: + lua_pushstring (state, label); What happens if label is NULL? In all cases if grub could mount filesystem it returns

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Fajar A. Nugraha
On Fri, Feb 27, 2015 at 6:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 27.02.2015 12:47, Fajar A. Nugraha wrote: >> >> + lua_pushstring (state, label); > > What happens if label is NULL? On my test it doesn't throw any errors. Note that the new code was mostly copy-paste from the or

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

2015-02-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.02.2015 12:47, Fajar A. Nugraha wrote: + lua_pushstring (state, label); What happens if label is NULL? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel