Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-18 Thread Glenn Washburn
On Tue, 14 Nov 2023 04:05:00 + Dimitri John Ledkov wrote: > On Tue, 14 Nov 2023, 03:19 Glenn Washburn, > wrote: > > > On Mon, 13 Nov 2023 17:18:50 +0100 > > Daniel Kiper wrote: > > > > > On Sun, Nov 12, 2023 at 08:22:42AM +0100, Heinrich Schuchardt wrote: > > > > On 11/12/23 04:23, Glenn W

Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-18 Thread Glenn Washburn
On Mon, 13 Nov 2023 17:18:50 +0100 Daniel Kiper wrote: > On Sun, Nov 12, 2023 at 08:22:42AM +0100, Heinrich Schuchardt wrote: > > On 11/12/23 04:23, Glenn Washburn wrote: > > > The canary, __stack_chk_guard, is in the BSS and so will get initialized > > > to > > > zero if it is not explicitly in

Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-13 Thread Dimitri John Ledkov
On Tue, 14 Nov 2023, 03:19 Glenn Washburn, wrote: > On Mon, 13 Nov 2023 17:18:50 +0100 > Daniel Kiper wrote: > > > On Sun, Nov 12, 2023 at 08:22:42AM +0100, Heinrich Schuchardt wrote: > > > On 11/12/23 04:23, Glenn Washburn wrote: > > > > The canary, __stack_chk_guard, is in the BSS and so will

Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-13 Thread Glenn Washburn
On Mon, 13 Nov 2023 17:18:50 +0100 Daniel Kiper wrote: > On Sun, Nov 12, 2023 at 08:22:42AM +0100, Heinrich Schuchardt wrote: > > On 11/12/23 04:23, Glenn Washburn wrote: > > > The canary, __stack_chk_guard, is in the BSS and so will get initialized > > > to > > > zero if it is not explicitly in

Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-13 Thread Daniel Kiper
On Sun, Nov 12, 2023 at 08:22:42AM +0100, Heinrich Schuchardt wrote: > On 11/12/23 04:23, Glenn Washburn wrote: > > The canary, __stack_chk_guard, is in the BSS and so will get initialized to > > zero if it is not explicitly initialized. If the UEFI firmware does not > > support the RNG protocol, t

Re: [PATCH] efi: Initialize canary to non-zero value

2023-11-11 Thread Heinrich Schuchardt
On 11/12/23 04:23, Glenn Washburn wrote: The canary, __stack_chk_guard, is in the BSS and so will get initialized to zero if it is not explicitly initialized. If the UEFI firmware does not support the RNG protocol, then the canary will not be randomized and will be used as zero. This seems like a