Re: [PATCH] bug fix for bootp

2012-05-01 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.04.2012 20:59, Bean wrote: > 2012/4/30 Bean : >> 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko : >>> On 29.04.2012 20:26, Bean wrote: Hi, It should be ok, since it's insideFOR_NET_NETWORK_LEVEL_INTERFACES (inf) loop and compare inf->hwaddress.mac to the current dhcp

Re: [PATCH] bug fix for bootp

2012-04-29 Thread Bean
2012/4/30 Bean : > 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko : >> On 29.04.2012 20:26, Bean wrote: >>> Hi, >>> >>> It should be ok, since it's inside    FOR_NET_NETWORK_LEVEL_INTERFACES >>> (inf) loop and compare inf->hwaddress.mac to the current dhcp response >>> packet. >> It's not. You ret

Re: [PATCH] bug fix for bootp

2012-04-29 Thread Bean
2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko : > On 29.04.2012 20:26, Bean wrote: >> Hi, >> >> It should be ok, since it's inside    FOR_NET_NETWORK_LEVEL_INTERFACES >> (inf) loop and compare inf->hwaddress.mac to the current dhcp response >> packet. > It's not. You return even if packet didn't

Re: [PATCH] bug fix for bootp

2012-04-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.04.2012 20:26, Bean wrote: > Hi, > > It should be ok, since it's insideFOR_NET_NETWORK_LEVEL_INTERFACES > (inf) loop and compare inf->hwaddress.mac to the current dhcp response > packet. It's not. You return even if packet didn't match. > 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko :

Re: [PATCH] bug fix for bootp

2012-04-29 Thread Bean
Hi, It should be ok, since it's inside FOR_NET_NETWORK_LEVEL_INTERFACES (inf) loop and compare inf->hwaddress.mac to the current dhcp response packet. 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko : > On 29.04.2012 06:17, Bean wrote: >> Hi, >> >> DHCP offer can use multicast address, so in

Re: [PATCH] bug fix for bootp

2012-04-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.04.2012 06:17, Bean wrote: > Hi, > > DHCP offer can use multicast address, so instead of comparing the > target address, we should compare the mac field in the dhcp packet. Could you adjust this patch to the fact that there may be several simultaneous bootp active requests from GRUB for diffe