Re: [PATCH] ata.mod under qemu

2009-05-25 Thread Pavel Roskin
On Mon, 2009-05-25 at 21:47 +0200, Christian Franke wrote: > > That must be the "ghost devices". While it would be nice to get rid of > > such messages, I'm fine if your patch is committed as is. > > > > > > Modified version committed, messages should no longer appear. The messages are gone,

Re: [PATCH] ata.mod under qemu

2009-05-25 Thread Christian Franke
Pavel Roskin wrote: On Sat, 2009-05-23 at 23:04 +0200, Christian Franke wrote: New patch attached. Please test on the above hardware if possible. It's working fine. (ata6) and (ata7) appear, but (ata0) and (ata1) doesn't. When inserting ata.mod, I get: error: error reading ATA IDEN

Re: [PATCH] ata.mod under qemu

2009-05-24 Thread Pavel Roskin
On Sat, 2009-05-23 at 23:04 +0200, Christian Franke wrote: > Christian Franke wrote: > > Pavel Roskin wrote: > >>> > >> It helps detect CD-ROM under qemu. But on the real hardware, it > >> introduces ghost drives. > >> > >> Without the patch, I have (ata7) for the SATA hard drive. With the > >>

Re: [PATCH] ata.mod under qemu

2009-05-23 Thread Christian Franke
Christian Franke wrote: Pavel Roskin wrote: It helps detect CD-ROM under qemu. But on the real hardware, it introduces ghost drives. Without the patch, I have (ata7) for the SATA hard drive. With the patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW and two bogus unre

Re: [PATCH] ata.mod under qemu

2009-05-21 Thread Christian Franke
Pavel Roskin wrote: On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote: The attached patch should fix this. It should also prevents misleading error messages if a device does not exist. It helps detect CD-ROM under qemu. But on the real hardware, it introduces ghost drives. Wit

Re: [PATCH] ata.mod under qemu

2009-05-20 Thread Pavel Roskin
On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote: > The attached patch should fix this. It should also prevents misleading > error messages if a device does not exist. > > 2009-05-20 Christian Franke > > * disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status >

Re: [PATCH] ata.mod under qemu

2009-05-20 Thread Christian Franke
The attached patch should fix this. It should also prevents misleading error messages if a device does not exist. 2009-05-20 Christian Franke * disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status register. (grub_ata_identify): Suppress error message if st

Re: [PATCH] ata.mod under qemu

2009-05-19 Thread Christian Franke
Pavel Roskin wrote: > On Mon, 2009-05-18 at 19:36 -0400, Pavel Roskin wrote: > > > I did a quick check, and your patch has no effect on my system. I'm > > using Fedora 11 with qemu 0.10. After inserting the ata module, ls > > shows no disks, with or without your patch. > > > > Never mind, my "

Re: [PATCH] ata.mod under qemu

2009-05-18 Thread Pavel Roskin
On Mon, 2009-05-18 at 19:36 -0400, Pavel Roskin wrote: > I did a quick check, and your patch has no effect on my system. I'm > using Fedora 11 with qemu 0.10. After inserting the ata module, ls > shows no disks, with or without your patch. Never mind, my "quick check" was too quick. I forgot t

Re: [PATCH] ata.mod under qemu

2009-05-18 Thread Pavel Roskin
On Mon, 2009-05-18 at 20:04 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, May 18, 2009 at 7:59 PM, Vladimir 'phcoder' Serbinenko > wrote: > > On Mon, May 18, 2009 at 7:59 PM, Vladimir 'phcoder' Serbinenko > > wrote: > >> Hello. While experimenting with ata.mod on qemu I noticed it doesn't

Re: [PATCH] ata.mod under qemu

2009-05-18 Thread Vladimir 'phcoder' Serbinenko
On Mon, May 18, 2009 at 7:59 PM, Vladimir 'phcoder' Serbinenko wrote: > On Mon, May 18, 2009 at 7:59 PM, Vladimir 'phcoder' Serbinenko > wrote: >> Hello. While experimenting with ata.mod on qemu I noticed it doesn't >> see the CD when it wasn't already initialised by bios. Just putting >> the sta

Re: [PATCH] ata.mod under qemu

2009-05-18 Thread Vladimir 'phcoder' Serbinenko
On Mon, May 18, 2009 at 7:59 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello. While experimenting with ata.mod on qemu I noticed it doesn't > see the CD when it wasn't already initialised by bios. Just putting > the status check after identify check solves the problem. However I'm > not familiar