Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2021-02-24 Thread Renaud Métrich
Hello, Please find an updated version of the patch proposing a fallback mechanism in case grub is not able to detect the set to be used. I has been tested on the following systems: - Lenovo P71 - Asus N53SN - Dell Precision - HP Elitebook - Lenovo T460s - QEMU/KVM - HP G5430 On all the

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2021-01-21 Thread Daniel Kiper
Hi Javier and Renaud, Sorry for late reply but I am busy with other important stuff. I will try to take a look at the patch next week. Daniel On Tue, Jan 19, 2021 at 09:07:30AM +0100, Javier Martinez Canillas wrote: > Hello Vladimir and Daniel, > > Could you please let us know your thoughts on R

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2021-01-19 Thread Javier Martinez Canillas
Hello Vladimir and Daniel, Could you please let us know your thoughts on Renaud's investigation and patches? Thanks a lot for your help. On 1/8/21 3:00 PM, Renaud Métrich wrote: > Hello, > > It appears that the proposal works fine on all systems I could test > except one: a HP DL380p Gen 8. >

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2021-01-08 Thread Renaud Métrich
Hello, It appears that the proposal works fine on all systems I could test except one: a HP DL380p Gen 8. On that system, querying the set fails: the ACK bytes in write_mode(0) work perfectly, but then 0xFE ("NACK") is read, as if the keyboard didn't want to send back the set in use. Hence

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-14 Thread Renaud Métrich
Hi Vladimir, Thanks for the hint, this was obvious now. Please find attached the new patch which definitely fixes the issue. It has been tested on various hardware (see git commit details). In a nutshell the solution is to stick to set 1 if controller is in Translate mode, and use set X other

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-14 Thread Javier Martinez Canillas
Hello Vladimir, On 12/11/20 3:08 PM, Vladimir 'phcoder' Serbinenko wrote: > On Fri, Dec 4, 2020 at 5:53 AM Renaud Métrich wrote: >> >> Hi, >> >> Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as >> at_keyboard is selected, the keys are corrupted and it's impossible to

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-11 Thread Vladimir 'phcoder' Serbinenko
On Fri, Dec 4, 2020 at 5:53 AM Renaud Métrich wrote: > > Hi, > > Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as > at_keyboard is selected, the keys are corrupted and it's impossible to do > anything. > > Digging into this, it appears that query_mode() returns 2 (so

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-04 Thread Renaud Métrich
Hi, Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as at_keyboard is selected, the keys are corrupted and it's impossible to do anything. Digging into this, it appears that query_mode() returns 2 (so set2 needs to be used), but in fact internally the keycode are th