Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Benjamin Herrenschmidt
On Wed, 2024-10-16 at 14:18 +0100, Mate Kukri wrote: > We have reverted the SPCR table patches in Debian due to crashes, I > guess this might have been the reason. Quite likely ! The bug would be triggered by trying to search for a table that doesn't exist, which I think in grub today mostly happ

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Adam Williamson
On Wed, 2024-10-16 at 16:20 +1100, Benjamin Herrenschmidt wrote: > The calculation of the size of the table was incorrect (copy/pasta from > grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long. > > This causes us to access beyond the end of the table which is causing > crashes du

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Ross Philipson via Grub-devel
On 10/15/24 10:20 PM, Benjamin Herrenschmidt wrote: The calculation of the size of the table was incorrect (copy/pasta from grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long. Yup that is correct for XSDT entries, the are 64b each. Reviewed-by: Ross Philipson This causes

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Mate Kukri
We have reverted the SPCR table patches in Debian due to crashes, I guess this might have been the reason. On Wed, Oct 16, 2024 at 6:20 AM Benjamin Herrenschmidt wrote: > > The calculation of the size of the table was incorrect (copy/pasta from > grub_acpi_rsdt_find_table() I assume...). The entr

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Daniel Kiper
On Wed, Oct 16, 2024 at 11:38:38AM +0300, Vladimir 'phcoder' Serbinenko wrote: > Reviewed-By: Vladimir Serbinenko phco...@gmail.com Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-16 Thread Vladimir 'phcoder' Serbinenko
Reviewed-By: Vladimir Serbinenko phco...@gmail.com Le mer. 16 oct. 2024, 08:22, Benjamin Herrenschmidt < b...@kernel.crashing.org> a écrit : > The calculation of the size of the table was incorrect (copy/pasta from > grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long. > > This