Re: [PATCH] Warning if grub.cfg not found

2008-09-29 Thread Robert Millan
On Sun, Sep 28, 2008 at 11:41:02PM +0200, Carles Pina i Estany wrote: > > Hello, > > On Sep/28/2008, Robert Millan wrote: > > On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote: > > > --- normal/main.c (revision 1877) > > > +++ normal/main.c (working copy) > > > @@ -230,7 +230,1

Re: [PATCH] Warning if grub.cfg not found

2008-09-28 Thread Carles Pina i Estany
Hello, On Sep/28/2008, Robert Millan wrote: > On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote: > > --- normal/main.c (revision 1877) > > +++ normal/main.c (working copy) > > @@ -230,7 +230,13 @@ > >/* Try to open the config file. */ > >file = grub_file_open (conf

Re: [PATCH] Warning if grub.cfg not found

2008-09-28 Thread Robert Millan
On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote: > --- normal/main.c (revision 1877) > +++ normal/main.c (working copy) > @@ -230,7 +230,13 @@ >/* Try to open the config file. */ >file = grub_file_open (config); >if (! file) > -return 0; > +{ This

Re: [PATCH] Warning if grub.cfg not found

2008-09-27 Thread Carles Pina i Estany
Hello, I "recover" an old thread... Long time ago I was thinking in a better warning when Grub2 couldn't open grub.cfg file. I send attached a new patch for it (previous one was a bit incorrect, this one is shorter cleaner, showing the warning in a better place). Question: What should Grub do

Re: [PATCH] Warning if grub.cfg not found

2008-09-05 Thread Carles Pina i Estany
Hi, On Aug/30/2008, Robert Millan wrote: > > Hi > > On Sat, Aug 23, 2008 at 04:43:14PM +0200, Carles Pina i Estany wrote: > > Index: normal/cmdline.c > > === > > --- normal/cmdline.c(revision 1826) > > +++ normal/cmdline.c

Re: [PATCH] Warning if grub.cfg not found

2008-08-30 Thread Robert Millan
Hi On Sat, Aug 23, 2008 at 04:43:14PM +0200, Carles Pina i Estany wrote: > Index: normal/cmdline.c > === > --- normal/cmdline.c (revision 1826) > +++ normal/cmdline.c (working copy) > @@ -137,12 +137,17 @@ grub_cmdline_run (int nes

Re: [PATCH] Warning if grub.cfg not found

2008-08-23 Thread Carles Pina i Estany
Hi, On Aug/23/2008, Carles Pina i Estany wrote: > b) in normal/cmdline.c in grub_cmdline_run if I receive a nested == -1 I > show the warning maybe somebody prefers to macrofy this -1 to CFG_GRUB_NOT_FOUND ? Or -1 is clear enough? Thanks, -- Carles Pina i EstanyGPG id: 0x17756391