Hi,
On Aug/20/2008, Robert Millan wrote:
> On Sun, Aug 17, 2008 at 09:11:29PM +0200, Carles Pina i Estany wrote:
> > Ok:
> >
> >
> > 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]>
> >
> > * menu/normal.c (run_menu): Replace hardcoded numbers with macros
> > (16 for G
On Sun, Aug 17, 2008 at 09:11:29PM +0200, Carles Pina i Estany wrote:
> Ok:
>
>
> 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]>
>
> * menu/normal.c (run_menu): Replace hardcoded numbers with macros
> (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN)
>
Thanks
Hola,
On Aug/17/2008, Carles Pina i Estany wrote:
> > When reading the subject I thought it was the other way around. Would
> > something like:
> >
> > "replace hardcoded numbers with macros"
> >
> > or
> >
> > "macroify numbers"
>
> Ok:
>
>
> 2008-08-17 Carles Pina i Estany
Hello,
On Aug/17/2008, Robert Millan wrote:
> On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote:
> > 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]>
> >
> > * menu/normal.c (run_menu): Change magic numbers by constants
> > (16 by GRUB_TERM_UP and 14 by GRUB_T
On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote:
> 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]>
>
> * menu/normal.c (run_menu): Change magic numbers by constants
> (16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN)
When reading the subject I thought it was t
Hi,
On Aug/17/2008, Marco Gerards wrote:
> Hi,
>
> Carles Pina i Estany <[EMAIL PROTECTED]> writes:
>
> > When I did the Home/End keys patch I noticied that in normal/menu.c
> > there was some magic numbers (and some constants was already defined, in
> > include/grub/term.h (actually, reading
Hi,
Carles Pina i Estany <[EMAIL PROTECTED]> writes:
> When I did the Home/End keys patch I noticied that in normal/menu.c
> there was some magic numbers (and some constants was already defined, in
> include/grub/term.h (actually, reading the ChangeLog was committed by
> Robert Millan on 2008-02-
