Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
Bean confirmed it works. Committed without changing jmp to call, since it wasn't clear whether we want it or not. On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > > Quoting Robert Millan <[EMAIL PROTECTED]>: > > > >

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 11:38:48PM +0800, Bean wrote: > > > > "exit" in open firmware based systems would probably mean returning > > control to open firmware. > > > > By the way, it would be nice to have "exit" in both grub for PC and > > grub-emu, and not only in the rescue mode. "exit" on P

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Bean
On Fri, Apr 18, 2008 at 11:16 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > > > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > > - jmp EXT_C(cmain) > > > + jmp EXT_C(grub_main) > > > > Or maybe that should be a

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 11:16:43AM -0400, Pavel Roskin wrote: > > On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > > - jmp EXT_C(cmain) > > > + jmp EXT_C(grub_main) > > > > Or maybe that should be a "call" instead.. >

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Pavel Roskin
On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > - jmp EXT_C(cmain) > > + jmp EXT_C(grub_main) > > Or maybe that should be a "call" instead.. Only if there is any chance of return, and we can handle it. "exit" in op

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Lubomir Kundrak
On Fri, 2008-04-18 at 13:32 +0200, Robert Millan wrote: > On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > > Quoting Robert Millan <[EMAIL PROTECTED]>: > > > > >Now that I think of it, is there any reason for doing all the cmain() > > >cruft before grub_main() ? Getting to grub_ma

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > - jmp EXT_C(cmain) > + jmp EXT_C(grub_main) Or maybe that should be a "call" instead.. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > Quoting Robert Millan <[EMAIL PROTECTED]>: > > >Now that I think of it, is there any reason for doing all the cmain() > >cruft before grub_main() ? Getting to grub_main() only requires a working > >stack, which we have, and grub_main

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: Now that I think of it, is there any reason for doing all the cmain() cruft before grub_main() ? Getting to grub_main() only requires a working stack, which we have, and grub_main() inmediately returns control back to architecture-specific code in grub

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Robert Millan
On Thu, Apr 17, 2008 at 01:53:21PM +0200, Lubomir Kundrak wrote: > > On Tue, 2008-04-15 at 15:38 +0200, Robert Millan wrote: > > On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > > > diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c > > > --- grub-1.95.orig/kern/main.c

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Lubomir Kundrak
On Tue, 2008-04-15 at 15:01 -0400, Pavel Roskin wrote: > On Tue, 2008-04-15 at 00:30 +0200, Lubomir Kundrak wrote: > > These are pretty self-explainable. I think I tried to sumbit these > > changes with the serial debugging patch year and some months ago and I > > was told to sign the copyright as

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Lubomir Kundrak
On Tue, 2008-04-15 at 15:38 +0200, Robert Millan wrote: > On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > > diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c > > --- grub-1.95.orig/kern/main.c 2007-01-29 15:31:36.0 +0100 > > +++ grub-1.95/kern/main.c 2007

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-15 Thread Pavel Roskin
On Tue, 2008-04-15 at 00:30 +0200, Lubomir Kundrak wrote: > These are pretty self-explainable. I think I tried to sumbit these > changes with the serial debugging patch year and some months ago and I > was told to sign the copyright assignment. I have already done that > now. :) > > 2008-04-15 Lu

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-15 Thread Robert Millan
On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c > --- grub-1.95.orig/kern/main.c2007-01-29 15:31:36.0 +0100 > +++ grub-1.95/kern/main.c 2007-01-30 18:29:55.0 +0100 > @@ -106,6 +106,14 @@ grub_l

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-15 Thread Robert Millan
On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > These are pretty self-explainable. I think I tried to sumbit these > changes with the serial debugging patch year and some months ago and I > was told to sign the copyright assignment. I have already done that > now. :) > > 2008-04