Re: [PATCH] Large disk support for XFS

2009-08-26 Thread Bean
Hi, Ok, committed. On Wed, Aug 26, 2009 at 8:18 AM, Robert Millan wrote: > On Tue, Aug 25, 2009 at 01:41:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Tue, Aug 25, 2009 at 12:30 AM, Robert Millan wrote: >> > On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko >> > wr

Re: [PATCH] Large disk support for XFS

2009-08-25 Thread Robert Millan
On Tue, Aug 25, 2009 at 01:41:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Aug 25, 2009 at 12:30 AM, Robert Millan wrote: > > On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > >> > Hi, > >> > > >> >

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Tue, Aug 25, 2009 at 12:30 AM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: >> > Hi, >> > >> > This patch fixes a few size limits of xfs fs. >> Ping > > Isn't this already in SVN ? > No. > --

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > > Hi, > > > > This patch fixes a few size limits of xfs fs. > Ping Isn't this already in SVN ? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > Hi, > > This patch fixes a few size limits of xfs fs. Ping > > -- > Bean > > gitgrub home: http://github.com/grub/grub/ > my fork page: http://github.com/bean123/grub/ > > ___ > Grub-devel mailing list > Grub

Re: [PATCH] Large disk support for XFS

2009-08-17 Thread Felix Zielcke
Am Montag, den 17.08.2009, 15:22 -0400 schrieb Monty Montgomery: > On Mon, Aug 17, 2009 at 6:09 AM, Vladimir 'phcoder' > Serbinenko wrote: > > On Mon, Aug 17, 2009 at 3:02 AM, Monty Montgomery wrote: > >> After applying the patch, "grub-probe -v -t fs /" and "grub-install > >> /dev/sda" both succee

Re: [PATCH] Large disk support for XFS

2009-08-17 Thread Monty Montgomery
On Mon, Aug 17, 2009 at 6:09 AM, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:02 AM, Monty Montgomery wrote: >> After applying the patch, "grub-probe -v -t fs /" and "grub-install >> /dev/sda" both succeed without incident on the 6TB XFS volume. >> However, upon reboot: >> >> GR

Re: [PATCH] Large disk support for XFS

2009-08-17 Thread Robert Millan
On Mon, Aug 17, 2009 at 12:09:03PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:02 AM, Monty Montgomery wrote: > > After applying the patch, "grub-probe -v -t fs /" and "grub-install > > /dev/sda" both succeed without incident on the 6TB XFS volume. > > However, upon rebo

Re: [PATCH] Large disk support for XFS

2009-08-17 Thread Robert Millan
On Sun, Aug 16, 2009 at 09:49:11PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > > Hi, > > > > This patch fixes a few size limits of xfs fs. > > > For sector numbers I would recommend to use grub_disk_addr_t but > otherwise the patch looks good. Provid

Re: [PATCH] Large disk support for XFS

2009-08-17 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 17, 2009 at 3:02 AM, Monty Montgomery wrote: > After applying the patch, "grub-probe -v -t fs /" and "grub-install > /dev/sda" both succeed without incident on the 6TB XFS volume. > However, upon reboot: > > GRUB loading. > Welcome to GRUB! > > Entering rescue mode > error: out of d

Re: [PATCH] Large disk support for XFS

2009-08-16 Thread Monty Montgomery
After applying the patch, "grub-probe -v -t fs /" and "grub-install /dev/sda" both succeed without incident on the 6TB XFS volume. However, upon reboot: GRUB loading. Welcome to GRUB! Entering rescue mode error: out of disk grub rescue> At this point I tried 'help' and was told: Unknown com

Re: [PATCH] Large disk support for XFS

2009-08-16 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > Hi, > > This patch fixes a few size limits of xfs fs. > For sector numbers I would recommend to use grub_disk_addr_t but otherwise the patch looks good. Provided you write a Changelog and it passes the test, I'm ok with you comitting it. > -- > Bean >