RE: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-24 Thread Gregg C Levine
f Of Pavel Roskin > Sent: Wednesday, July 22, 2009 8:05 PM > To: The development of GRUB 2 > Subject: Re: [PATCH] Fix chainloding + Chainloading into logical partitions > > On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote: > > > There is st

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-23 Thread Jean-Pierre Flori
>On Thu, Jul 23, 2009 at 2:04 AM, Pavel Roskin wrote: >> On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote: >> >>> There is strictly no need to do this restructuration. The real bug is >>> different fix would be setting dev->disk->partition to 0 before >>> calling grub_disk_rea

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-23 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 23, 2009 at 2:04 AM, Pavel Roskin wrote: > On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> There is strictly no need to do this restructuration. The real bug is >> different fix would be setting dev->disk->partition to 0 before >> calling grub_disk_read and

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-22 Thread Pavel Roskin
On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote: > There is strictly no need to do this restructuration. The real bug is > different fix would be setting dev->disk->partition to 0 before > calling grub_disk_read and restoring it afterwards. This part of code > is changed any

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-22 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 23, 2009 at 12:11 AM, Jean-Pierre Flori wrote: > As already mentioned in this mailing list > (http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00192.html)n I > can't chainload Syslinux from Grub2 on a disk with a pc partition table > (Syslinux is installed on a primary partition)

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-22 Thread Jean-Pierre Flori
As already mentioned in this mailing list ( http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00192.html)nI can't chainload Syslinux from Grub2 on a disk with a pc partition table (Syslinux is installed on a primary parti

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-10 Thread Bean
On Thu, Jul 10, 2008 at 10:08 PM, Lucas Gadani <[EMAIL PROTECTED]> wrote: > On Sun, Jul 6, 2008 at 5:47 PM, Lucas Gadani <[EMAIL PROTECTED]> wrote: >> On Sun, Jul 6, 2008 at 18:41, Robert Millan <[EMAIL PROTECTED]> wrote: >>> >>> Looks like it increases pc.mod code to store information that is only

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-10 Thread Lucas Gadani
On Sun, Jul 6, 2008 at 5:47 PM, Lucas Gadani <[EMAIL PROTECTED]> wrote: > On Sun, Jul 6, 2008 at 18:41, Robert Millan <[EMAIL PROTECTED]> wrote: >> >> Looks like it increases pc.mod code to store information that is only useful >> to the chainloader. Is there a reason for not having the chainloade

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-06 Thread Lucas Gadani
On Sun, Jul 6, 2008 at 18:41, Robert Millan <[EMAIL PROTECTED]> wrote: > > Looks like it increases pc.mod code to store information that is only useful > to the chainloader. Is there a reason for not having the chainloader > retrieve it? (note that for disk access we have a cache) We would need

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-06 Thread Robert Millan
On Mon, Jun 30, 2008 at 02:28:24AM +, Lucas Gadani wrote: > Hello, > > This is my first patch for GRUB, and I haven't found any coding > styles/formatting, nor developer documentation, so, if there's > something wrong, please, forgive me and point me to the right > direction. > > Current impl

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-06-30 Thread Fulvio Scapin
2008/6/30 Lucas Gadani <[EMAIL PROTECTED]>: > Hello, > > This is my first patch for GRUB, and I haven't found any coding > styles/formatting, nor developer documentation, so, if there's > something wrong, please, forgive me and point me to the right > direction. > > Current implementation of the c