Re: [PATCH] F2FS support

2018-04-04 Thread Pete Batard
On 2018.04.04 21:37, Daniel Kiper wrote: Thanks, LGTM +/- some nitpicks which I fix before committing. If there are no significant objections I will apply this patch in a week or so. Thanks Daniel. Much appreciated. Regards, /Pete ___ Grub-devel ma

Re: [PATCH] F2FS support

2018-04-04 Thread Daniel Kiper
On Sat, Mar 31, 2018 at 10:47:29PM +0200, Paul Menzel wrote: > Dear Pete, > > Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: > > Thanks for reviewing the patch. > > Here's a v2 that takes your comments into account. > > Could you please make the commit message title a statement by

Re: [PATCH] F2FS support

2018-04-04 Thread Daniel Kiper
On Thu, Mar 29, 2018 at 05:08:42PM +0100, Pete Batard wrote: > Hi Daniel, > > Thanks for reviewing the patch. > Here's a v2 that takes your comments into account. Thanks, LGTM +/- some nitpicks which I fix before committing. If there are no significant objections I will apply this patch in a week

Re: [PATCH] F2FS support

2018-04-01 Thread Pete Batard
Sorry Paul, but I'm going to have to decline both requests. There's only so much time I am willing to sink in an effort to remove one .patch file from my downstream repository (which is literally the only reason I have been pushing for F2FS GRUB integration), and these extra requirements are a

Re: [PATCH] F2FS support

2018-03-31 Thread Paul Menzel
Dear Pete, Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: > Thanks for reviewing the patch. > Here's a v2 that takes your comments into account. Could you please make the commit message title a statement by adding a verb? > Add F2FS support Could you additionally add an exampl

Re: [PATCH] F2FS support

2018-03-29 Thread Pete Batard
Hi Daniel, Thanks for reviewing the patch. Here's a v2 that takes your comments into account. Regards, /Pete On 2018.03.28 13:04, Daniel Kiper wrote: On Thu, Mar 22, 2018 at 04:47:47PM +, Pete Batard wrote: From 40030514e682191281e8ddba8d1e0835e6b685dc Mon Sep 17 00:00:00 2001 From: Jae

Re: [PATCH] F2FS support

2018-03-28 Thread Daniel Kiper
On Thu, Mar 22, 2018 at 04:47:47PM +, Pete Batard wrote: > From 40030514e682191281e8ddba8d1e0835e6b685dc Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Thu, 4 May 2017 19:12:00 +0100 > Subject: [PATCH] F2FS support > > "F2FS (Flash-Friendly File System) is flash-friendly file system whic

Re: [PATCH] F2FS support

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 08:39:45PM +, Pete Batard wrote: > +1 for F2FS integration, which I also requested a few months back and > which I know has also been requested by other people before that. > > While I understand that the GRUB project's priorities might be > elsewhere, I'm just going to

Re: [PATCH] F2FS support

2018-03-18 Thread Pete Batard
+1 for F2FS integration, which I also requested a few months back and which I know has also been requested by other people before that. While I understand that the GRUB project's priorities might be elsewhere, I'm just going to point out that I am growing a bit tired of having had to keep and

Re: [PATCH] F2FS support

2018-03-17 Thread 林博仁
> "F2FS (Flash-Friendly File System) is flash-friendly file system which was > merged into Linux kernel v3.8 in 2013. > Any update on this patch? F2FS really help much on my system's performance on a dirt-cheap flash storage key. 林博仁(Buo-ren, Lin) buo.ren@gmail.com

Re: [PATCH] F2FS support

2017-05-04 Thread Adam Borowski
On Thu, May 04, 2017 at 11:12:40AM -0700, Jaegeuk Kim wrote: > "F2FS (Flash-Friendly File System) is flash-friendly file system which was > merged > into Linux kernel v3.8 in 2013. > > The motive for F2FS was to build a file system that from the start, takes into > account the characteristics of

Re: [PATCH] F2FS support

2015-04-03 Thread Jaegeuk Kim
Hi Andrei, On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > В Tue, 24 Mar 2015 01:19:00 -0700 > Jaegeuk Kim пишет: > ... > > +/* byte-size offset */ > > +#define F2FS_SUPER_OFFSET 1024 > > + > > +/* 12 bits for 4096 bytes */ > > +#define F2FS_MAX_LOG_SECTOR_SIZE 1

Re: [PATCH] F2FS support

2015-03-28 Thread Andrei Borzenkov
В Sat, 28 Mar 2015 13:43:18 -0700 Jaegeuk Kim пишет: > Hi Andrei, > > On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > > В Tue, 24 Mar 2015 01:19:00 -0700 > > Jaegeuk Kim пишет: > > > > > * Makefile.util.def: Add f2fs.c. > > > * doc/grub.texi: Add f2fs description. > > >

Re: [PATCH] F2FS support

2015-03-28 Thread Jaegeuk Kim
Hi Andrei, On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > В Tue, 24 Mar 2015 01:19:00 -0700 > Jaegeuk Kim пишет: > > > * Makefile.util.def: Add f2fs.c. > > * doc/grub.texi: Add f2fs description. > > * grub-core/Makefile.core.def: Add f2fs module. > > * grub-core/fs/f2fs.

Re: [PATCH] F2FS support

2015-03-28 Thread Andrei Borzenkov
В Tue, 24 Mar 2015 01:19:00 -0700 Jaegeuk Kim пишет: > * Makefile.util.def: Add f2fs.c. > * doc/grub.texi: Add f2fs description. > * grub-core/Makefile.core.def: Add f2fs module. > * grub-core/fs/f2fs.c: New file. > * tests/f2fs_test.in: New file. > * tests/util/grub-fs-tester.in: Add f2fs