Re: [PATCH] Cryptomount support for key files and detached header

2020-11-10 Thread Glenn Washburn
On Tue, 10 Nov 2020 01:09:20 +0300 Dmitry wrote: > вт, 10 нояб. 2020 г. в 00:34, Glenn Washburn > : > > > > On Mon, 9 Nov 2020 10:56:51 +0300 > > Dmitry wrote: > > > > > Thanks for feedback. First of all I think it's preferable to > > > introduce the master-key option at the beginning. Because I

Re: [PATCH] Cryptomount support for key files and detached header

2020-11-09 Thread Dmitry
вт, 10 нояб. 2020 г. в 00:34, Glenn Washburn : > > On Mon, 9 Nov 2020 10:56:51 +0300 > Dmitry wrote: > > > Thanks for feedback. First of all I think it's preferable to introduce > > the master-key option at the beginning. Because I see no point for a > > user to use a standard slot key along with

Re: [PATCH] Cryptomount support for key files and detached header

2020-11-09 Thread Glenn Washburn
On Mon, 9 Nov 2020 10:56:51 +0300 Dmitry wrote: > Thanks for feedback. First of all I think it's preferable to introduce > the master-key option at the beginning. Because I see no point for a > user to use a standard slot key along with a detached header. > Decryption from key to master key takes

Re: [PATCH] Cryptomount support for key files and detached header

2020-11-09 Thread Dmitry
And it seems the next function can be used to allow keyfile-offset and keyfile-size: file.h: grub_file_t grub_file_offset_open (grub_file_t parent, enum grub_file_type type, grub_off_t start, grub_off_t size); So only grub_cmd_cryptomount can be modified for this. Dmitry пн, 9 нояб. 2020 г.

Re: [PATCH] Cryptomount support for key files and detached header

2020-11-08 Thread Dmitry
Thanks for feedback. First of all I think it's preferable to introduce the master-key option at the beginning. Because I see no point for a user to use a standard slot key along with a detached header. Decryption from key to master key takes a long time. (30 seconds for argon2i). Regarding keyfile-

Re: [PATCH] Cryptomount support for key files and detached header

2020-11-08 Thread Glenn Washburn
I've read through the patch but not applied or tested it. However, it looks like it does the job. In fact, its fairly similar in parts to a patch, which adds LUKS2 keyfile and detached header support, I've been waiting to send to the list until the previous LUKS1 keyfile and detached header suppo