Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: For 10_linux it isn't that important since the boot parameters are so small, it's 10_hurd that has more reusable stuff (that big blurb). This is true. Furthermore I still haven't found out how to get variables like "host-port", "device-port", "task-create", etc.. In t

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Fri, Feb 29, 2008 at 09:33:13AM +0100, Fabian Greffrath wrote: > >For this one, I think it'd be much better to rework 10_hurd so that code is > >shared, rather than duplicating the whole blurb. > > Yes, we could source out the complete linux/hurd kernel-adding blurbs > into an external shell l

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Fri, Feb 29, 2008 at 02:46:17PM +0100, Fabian Greffrath wrote: > Robert Millan schrieb: > >Better do this like it's done in other scripts (check grub-install). Not > >sure > >why, I guess it's more portable that way... > > Ah, now I know what you ment. However, I cannot really see the > adva

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: Better do this like it's done in other scripts (check grub-install). Not sure why, I guess it's more portable that way... Ah, now I know what you ment. However, I cannot really see the advantage in grub_probe=${sbindir}/`echo grub-probe | sed ${transform}` with ${tr

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: Better do this like it's done in other scripts (check grub-install). Not sure why, I guess it's more portable that way... You mean if [ "x$(FOO)" = "x" ] ... ? For this one, I think it'd be much better to rework 10_hurd so that code is shared, rather than duplicating

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Thu, Feb 28, 2008 at 12:46:37PM +0100, Fabian Greffrath wrote: > > if [ -x "`which os-prober 2>/dev/null`" ] ; then Better do this like it's done in other scripts (check grub-install). Not sure why, I guess it's more portable that way... > if [ -x "`which linux-boot-prober 2>/dev/n

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: Ok. Is there any mail for that waiting for input? I lose track of things. No problem, please find the script attached. #! /bin/sh -e # update-grub helper script. # Copyright (C) 2006,2007,2008 Free Software Foundation, Inc. # # GRUB is free software: you can redist

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Thu, Feb 28, 2008 at 11:28:13AM +0100, Fabian Greffrath wrote: > Robert Millan schrieb: > >Committed. > > Great, thanks! > > Now let's get support for os-prober output parsing. Ok. Is there any mail for that waiting for input? I lose track of things. -- Robert Millan I know my rights; I

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: Committed. Great, thanks! Now let's get support for os-prober output parsing. -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Thu, Feb 28, 2008 at 08:26:49AM +0100, Fabian Greffrath wrote: > Robert Millan schrieb: > >Ok. Does anybody object to Fabian's patch? I'd like to commit it. > > Silence is consense. ;) Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you a

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Robert Millan schrieb: Ok. Does anybody object to Fabian's patch? I'd like to commit it. Silence is consense. ;) -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Mon, Feb 25, 2008 at 10:49:01AM +0100, Fabian Greffrath wrote: > >If you fix those, include a ChangeLog entry and noone else objects, I'll > >commit > >it. Feel free to ping me with a direct mail if I stale for too long. > > You are CCed. ;) > > Robert Millan schrieb: > > Is this solved now?

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Hello! Robert Millan schrieb: It looks good to me. Just a pair of minor details (simply for consistency with code style in grub): [...] done. If you fix those, include a ChangeLog entry and noone else objects, I'll commit it. Feel free to ping me with a direct mail if I stale for too long.

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

On Fri, Feb 22, 2008 at 03:32:02PM +0100, Fabian Greffrath wrote: > However, grub-probe crashes with a double free error message if run with > the -d option. I am somehow stuck in this situation, can you please help me? Is this solved now? If not, you could send a gdb backtrace to give us an id

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Sorry for the long delay, I've been very busy (and unfortunately I'll continue to be :-(). On Fri, Feb 22, 2008 at 04:36:35PM +0100, Fabian Greffrath wrote: > Well, the solution seems to be easier than I expected. Is the attached > patch acceptable? It looks good to me. Just a pair of minor de

Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments

Well, the solution seems to be easier than I expected. Is the attached patch acceptable? Have a nice weekend, Fabian -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49