Re: /kern/file.c BUG

2008-01-26 Thread Robert Millan
On Sat, Jan 26, 2008 at 01:04:04PM +0100, Marco Gerards wrote: > > > > Ok, I reverted it. This will uncover another bug somewhere else. I can't > > remember what it was about, though. > > Thanks. Can you look that up? Sorry, I can't. I don't remember what I found broken, but chances are someb

Re: /kern/file.c BUG

2008-01-26 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Jan 25, 2008 at 09:50:14AM +0100, Marco Gerards wrote: >> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: >> >> (replying to this mail, I didn't receive the first mail over the list...) >> >> > Robert Millan wrote: >> >> On Wed, Jan 23, 2008 at 1

Re: /kern/file.c BUG

2008-01-25 Thread Robert Millan
On Fri, Jan 25, 2008 at 09:50:14AM +0100, Marco Gerards wrote: > Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > > (replying to this mail, I didn't receive the first mail over the list...) > > > Robert Millan wrote: > >> On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote: > >>> Incorrec

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: (replying to this mail, I didn't receive the first mail over the list...) > Robert Millan wrote: >> On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote: >>> Incorrect behavior of grub_file_open () function in e.g. loop context: >>> >>> char *

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote: >> On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: >> > > Previous behavior was working correctly. You have to han

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > >> Previous behavior was working correctly. You have to handle >> errorcodes >> at some point and that means when error is handled it is zeroed (or >> GRUB_ERR_NONE). So code is in callee whe

Re: /kern/file.c BUG

2008-01-24 Thread Pavel Roskin
On Thu, 2008-01-24 at 21:43 +, Oleg Strikov wrote: > But is it correct to check and handle errno in some `library` > function (now we do) ? I CAN, but i do not have to examine > errno after each non-error-free call; is it right? I don't know how grub_errno is suppos

Re: /kern/file.c BUG

2008-01-24 Thread Robert Millan
On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote: > On Thursday 24 January 2008 19:34, Pavel Roskin wrote: > > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > > > Previous behavior was working correctly. You have to handle > > > errorcodes > > > at some point and tha

Re: /kern/file.c BUG

2008-01-24 Thread Robert Millan
On Thu, Jan 24, 2008 at 11:09:17PM +0100, Marco Gerards wrote: > > It's nice when people say I am right (it should happen more often). You're right. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) __

Re: /kern/file.c BUG

2008-01-24 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: >> > Previous behavior was working correctly. You have to handle >> > errorcodes >> > at some point and that means when error is

Re: /kern/file.c BUG

2008-01-24 Thread Oleg Strikov
On Jan 24, 2008 9:42 PM, Oleg Strikov <[EMAIL PROTECTED]> wrote: > > >> Previous behavior was working correctly. You have to handle > > >> errorcodes > > >> at some point and that means when error is handled it is zeroed (or > > >> GRUB_ERR_NONE). So code is in callee where that loop was. > > > >

Re: /kern/file.c BUG

2008-01-24 Thread Yoshinori K. Okuji
On Thursday 24 January 2008 19:34, Pavel Roskin wrote: > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > > Previous behavior was working correctly. You have to handle > > errorcodes > > at some point and that means when error is handled it is zeroed (or > > GRUB_ERR_NONE). So code is

Re: /kern/file.c BUG

2008-01-24 Thread Pavel Roskin
On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > Previous behavior was working correctly. You have to handle > errorcodes > at some point and that means when error is handled it is zeroed (or > GRUB_ERR_NONE). So code is in callee where that loop was. I suggest that we never set gr

Re: /kern/file.c BUG

2008-01-24 Thread Vesa Jääskeläinen
Robert Millan wrote: On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote: Incorrect behavior of grub_file_open () function in e.g. loop context: char *file_names[] = { "(hd0,1)/file1", //file do not exist "(hd0,1)/file2" //file exist }; grub_file_t file; int i; for (i = 0; i < 2; i++)

Re: /kern/file.c BUG

2008-01-23 Thread Robert Millan
On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote: > Incorrect behavior of grub_file_open () function in e.g. loop context: > > char *file_names[] = > { > "(hd0,1)/file1", //file do not exist > "(hd0,1)/file2" //file exist > }; > grub_file_t file; > int i; > for (i = 0; i < 2; i++) > {