RE: grub2 code

2014-02-04 Thread Roger Cruz
Yes, that certainly would be a better fix. Thanks for addressing it. Roger -Original Message- From: Colin Watson [mailto:cjwat...@ubuntu.com] Sent: Monday, February 03, 2014 10:51 AM To: Roger Cruz Cc: Ben Guthro; grub-devel@gnu.org Subject: Re: grub2 code On Mon, Feb 03, 2014 at 03

RE: grub2 code

2014-02-04 Thread Roger Cruz
it is not clear, please feel free to ask for more details. Roger R. Cruz -Original Message- From: ben.gut...@gmail.com [mailto:ben.gut...@gmail.com] On Behalf Of Ben Guthro Sent: Monday, February 03, 2014 7:42 AM To: Colin Watson Cc: grub-devel@gnu.org; Roger Cruz Subject: Re: grub2 co

Re: grub2 code

2014-02-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.02.2014 12:57, Colin Watson wrote: > movw$(GRUB_MEMORY_MACHINE_BIOS_DATA_AREA_ADDR + 0x17), %bx > andb$3, (%bx) andb $3, (%bx) is equivalent to C code: *(grub_uint8_t *)bx &= 3; andb modifies the value at (%bx). You probably meant to use testb which has same flag seman

Re: grub2 code

2014-02-03 Thread Colin Watson
On Mon, Feb 03, 2014 at 03:44:01PM +, Roger Cruz wrote: > This was a bug that was introduced into GRUB when the code to detect > if the SHIFT key is being pressed was added. The symptom was that > customers were complaining that even though they had turn on NUMLOCK > in the BIOS, once we boote

Re: grub2 code

2014-02-03 Thread Ben Guthro
On Mon, Feb 3, 2014 at 6:57 AM, Colin Watson wrote: > On Sun, Feb 02, 2014 at 07:25:51PM +, Robert Parnell wrote: >> I was just looking at the grub2 source code and saw that >> https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/grub2/trusty/view/head:/TODO >>

Re: grub2 code

2014-02-03 Thread Colin Watson
On Sun, Feb 02, 2014 at 07:25:51PM +, Robert Parnell wrote: > I was just looking at the grub2 source code and saw that > https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/grub2/trusty/view/head:/TODO >

Re: grub2 code

2014-02-02 Thread SevenBits
On Sunday, February 2, 2014, Robert Parnell wrote: > Hi > > I was just looking at the grub2 source code and saw that > > https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/grub2/trusty/view/head:/TODO > < > https://bazaar.launchpad.net/%7Eubuntu-branches/ubuntu/trusty/grub2/trusty/view/h