Re: OLPC regression, ofdisk stops working

2009-07-10 Thread Bean
On Sat, Jul 11, 2009 at 4:20 AM, Robert Millan wrote: > On Fri, Jul 10, 2009 at 11:18:28AM -0700, David Miller wrote: >> From: Robert Millan >> Date: Fri, 10 Jul 2009 19:41:15 +0200 >> >> > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: >> >> Hi, >> >> >> >> There is something wrong with r2

Re: OLPC regression, ofdisk stops working

2009-07-10 Thread Robert Millan
On Fri, Jul 10, 2009 at 11:18:28AM -0700, David Miller wrote: > From: Robert Millan > Date: Fri, 10 Jul 2009 19:41:15 +0200 > > > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: > >> Hi, > >> > >> There is something wrong with r2132, now childtype is a pointer, so > >> sizeof childtype ==

Re: OLPC regression, ofdisk stops working

2009-07-10 Thread David Miller
From: Robert Millan Date: Fri, 10 Jul 2009 19:41:15 +0200 > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: >> Hi, >> >> There is something wrong with r2132, now childtype is a pointer, so >> sizeof childtype == 4, the name would be truncated to 4 characters. > > Bean, you never cease to

Re: OLPC regression, ofdisk stops working

2009-07-10 Thread Robert Millan
On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: > Hi, > > There is something wrong with r2132, now childtype is a pointer, so > sizeof childtype == 4, the name would be truncated to 4 characters. Bean, you never cease to amaze me. I admit the "interesting, exactly the word size" idea cross

Re: OLPC regression, ofdisk stops working

2009-07-10 Thread Bean
Hi, There is something wrong with r2132, now childtype is a pointer, so sizeof childtype == 4, the name would be truncated to 4 characters. diff --git a/kern/ieee1275/openfw.c b/kern/ieee1275/openfw.c index e7979f4..42d9278 100644 --- a/kern/ieee1275/openfw.c +++ b/kern/ieee1275/openfw.c @@ -78,1

OLPC regression, ofdisk stops working

2009-07-09 Thread Robert Millan
Hi, I got completely puzzled at this one. Turns out r2132 broke ofdisk on OLPC. But I don't see anything wrong in this commit. I isolated the change that causes this breakage, and it's very confusing. It turns out that allocating devtype in the heap instead of the stack causes its result to b