Re: LUKS Cryptography Support

2008-05-28 Thread Robert Millan
On Wed, May 28, 2008 at 07:58:20PM +0300, Vesa Jääskeläinen wrote: > > I know that ppl here prefer to write code from scratch, but perhaps in > this case it would be good idea to use another GNU project for > additional code. Security is not the easiest topic in there to write > properly. I se

Re: LUKS Cryptography Support

2008-05-28 Thread Michael Gorven
On Wednesday 28 May 2008 18:58:20 Vesa Jääskeläinen wrote: > Michael Gorven wrote: > > On Wednesday 28 May 2008 18:26:09 Vesa Jääskeläinen wrote: > >> Michael Gorven wrote: > >>> Numerous ciphers and hashes from libgcrypt: Copyright FSF and LGPL 2.1 > >>> AES cipher from Simon's patch: LGPL 2.1 > >

Re: LUKS Cryptography Support

2008-05-28 Thread Vesa Jääskeläinen
Michael Gorven wrote: On Wednesday 28 May 2008 18:26:09 Vesa Jääskeläinen wrote: Michael Gorven wrote: Numerous ciphers and hashes from libgcrypt: Copyright FSF and LGPL 2.1 AES cipher from Simon's patch: LGPL 2.1 If we are to go with libgcrypt way... why you are not using AES from there? (or

Re: LUKS Cryptography Support

2008-05-28 Thread Michael Gorven
On Wednesday 28 May 2008 18:26:09 Vesa Jääskeläinen wrote: > Michael Gorven wrote: > > Numerous ciphers and hashes from libgcrypt: Copyright FSF and LGPL 2.1 > > AES cipher from Simon's patch: LGPL 2.1 > > If we are to go with libgcrypt way... why you are not using AES from > there? (or is it not a

Re: LUKS Cryptography Support

2008-05-28 Thread Vesa Jääskeläinen
Michael Gorven wrote: Numerous ciphers and hashes from libgcrypt: Copyright FSF and LGPL 2.1 AES cipher from Simon's patch: LGPL 2.1 If we are to go with libgcrypt way... why you are not using AES from there? (or is it not available for some reason?) Two pieces of code I've used: GPL 2 or l

Re: LUKS Cryptography Support

2008-05-28 Thread Michael Gorven
On Wednesday 28 May 2008 16:07:09 Robert Millan wrote: > On Thu, May 22, 2008 at 03:56:53PM +0200, Michael Gorven wrote: > > 2. If I am to submit Simon's patch, what remaining issues are there with > > it? If there is a problem with the license of the ciphers I can replace > > them with suitable im

Re: LUKS Cryptography Support

2008-05-28 Thread Robert Millan
On Thu, May 22, 2008 at 03:56:53PM +0200, Michael Gorven wrote: > Hi > > I am currently adding support for LUKS encrypted partitions to GRUB2. > Although > I'm far from finished, there are a few issues I'd like to address. > > 1. I am using the crypto patch submitted by Simon Peter[1][2]. Are t

Re: LUKS Cryptography Support

2008-05-28 Thread Robert Millan
On Tue, May 27, 2008 at 01:24:47PM +0200, Michael Gorven wrote: > Here is an initial version of my LUKS patch. I still need to clean some > things > up, but I'd like to get some feedback regarding the design of the patch and > things like coding style. I currently have the following ciphers, has

LUKS Cryptography Support

2008-05-22 Thread Michael Gorven
Hi I am currently adding support for LUKS encrypted partitions to GRUB2. Although I'm far from finished, there are a few issues I'd like to address. 1. I am using the crypto patch submitted by Simon Peter[1][2]. Are there any plans to integrate this patch, or should I resubmit it as part of my