[PATCH 2/3] tests: include verbosity on tests.in checks

2025-09-19 Thread Leo Sandoval via Grub-devel
In this case, it does not hurt to increase bash execution verbosity so we can get more insight in case of issues. Signed-off-by: Leo Sandoval --- tests/ahci_test.in | 2 +- tests/asn1_test.in | 2 +- tests/btrfs_test.in | 2 +- tests/cdboot_te

Re: [PATCH v5 2/3] include/xen: Add warning comment for cmd_line

2025-08-18 Thread Daniel Kiper
On Wed, Aug 13, 2025 at 08:36:44PM -0500, arraybo...@gmail.com wrote: > From: Aaron Rainbolt > > The cmd_line field of the start_info struct is not guaranteed to be > NUL-terminated, even though it is intended to contain a NUL-terminated > string. Add a warning about this in a comment so future co

[PATCH v5 1/3] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-13 Thread arraybolt3
From: Aaron Rainbolt The xen.h header was using an overly generic name to refer to the maximum length of the command line passed from Xen to a guest. Rename it to avoid confusion or conflicts in the future. Signed-off-by: Aaron Rainbolt --- include/xen/xen.h | 4 ++-- 1 file changed, 2

[PATCH v5 2/3] include/xen: Add warning comment for cmd_line

2025-08-13 Thread arraybolt3
. Signed-off-by: Aaron Rainbolt --- include/xen/xen.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/xen/xen.h b/include/xen/xen.h index fdf0fc4..16f3fd7 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -823,6 +823,11 @@ struct start_info

Re: [PATCH v4 1/2] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-12 Thread Aaron Rainbolt
On Tue, 12 Aug 2025 16:00:05 +0300 "Vladimir 'phcoder' Serbinenko" wrote: > I believe this file is copied from xen as-is. It does appear so, yes. It looks like it's a copy of xen/xen/include/public/xen.h. > That's why it's under xen/ and not grub/. Did

Re: [PATCH v4 1/2] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-12 Thread Vladimir 'phcoder' Serbinenko
n.h header was using an overly generic name to refer to the > maximum length of the command line passed from Xen to a guest. Rename it > to avoid confusion or conflicts in the future. > > Signed-off-by: Aaron Rainbolt > --- > include/xen/xen.h | 4 ++-- > 1 file changed, 2 in

Re: [PATCH v4 1/2] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-12 Thread Daniel Kiper
On Mon, Aug 04, 2025 at 11:49:11PM -0500, Aaron Rainbolt wrote: > The xen.h header was using an overly generic name to refer to the > maximum length of the command line passed from Xen to a guest. Rename it > to avoid confusion or conflicts in the future. > > Signed-off-by: Aaron Rainbolt Reviewe

[PATCH v4 1/2] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-04 Thread Aaron Rainbolt
The xen.h header was using an overly generic name to refer to the maximum length of the command line passed from Xen to a guest. Rename it to avoid confusion or conflicts in the future. Signed-off-by: Aaron Rainbolt --- include/xen/xen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v4 2/6] include/grub/charset.h: Update documentation

2025-06-25 Thread Frediano Ziglio via Grub-devel
(grub_size_t) -1 is never returned, the function always return a not negative values. This is important for overflows considerations. Signed-off-by: Frediano Ziglio Reviewed-by: Daniel Kiper --- include/grub/charset.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 2/6] include/grub/charset.h: Update documentation

2025-06-24 Thread Frediano Ziglio via Grub-devel
(grub_size_t) -1 is never returned, the function always return a not negative values. This is important for overflows considerations. Signed-off-by: Frediano Ziglio --- include/grub/charset.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/charset.h b/include

[RFC PATCH 2/2] include/efi/efi: Add the prototype

2025-05-18 Thread khaalid cali
From: khaalid The function prototype. Signed-off-by: khaalid --- include/grub/efi/efi.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..3c38e2834 100644 --- a/include/grub/efi/efi.h +++ b/include/grub/efi/efi.h @@ -115,6

[PATCH 1/2] include/efi/api: Complete UEFI status codes

2025-05-18 Thread khaalid cali
From: khaalid As the the current spec UEFI 2.11 add remaining status codes. The first patch set of this series accounts for. Signed-off-by: Khalid Ali --- include/grub/efi/api.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h index

Re: [PATCH 1/2] Include function name on debug traces

2025-04-23 Thread Leo Sandoval via Grub-devel
rub2/ >> >> >> >> >>> >>> Regards >>> Vladimir 'phcoder' Serbinenko >>> >>> Le sam. 12 avr. 2025, 01:03, Leo Sandoval via Grub-devel < >>> grub-devel@gnu.org> a écrit : >>> >>>> Together wi

Re: [PATCH 1/2] Include function name on debug traces

2025-04-23 Thread Vladimir 'phcoder' Serbinenko
val via Grub-devel < >> grub-devel@gnu.org> a écrit : >> >>> Together with the line number, the debug trace with the function name >>> provides a bit more context and could be useful when inspecting log. >>> >>> Signed-off-by: Leo Sandoval &g

Re: [PATCH 1/2] Include function name on debug traces

2025-04-22 Thread Leo Sandoval via Grub-devel
text and could be useful when inspecting log. >> >> Signed-off-by: Leo Sandoval >> --- >> grub-core/kern/misc.c | 4 ++-- >> include/grub/misc.h | 5 +++-- >> 2 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/grub-core/kern/misc

Re: [PATCH 1/2] Include function name on debug traces

2025-04-15 Thread Vladimir 'phcoder' Serbinenko
; provides a bit more context and could be useful when inspecting log. > > Signed-off-by: Leo Sandoval > --- > grub-core/kern/misc.c | 4 ++-- > include/grub/misc.h | 5 +++-- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/grub-core/kern/misc.c b/

Re: [PATCH 1/2] Include function name on debug traces

2025-04-15 Thread Daniel Kiper
On Fri, Apr 11, 2025 at 04:01:04PM -0600, Leo Sandoval via Grub-devel wrote: > Together with the line number, the debug trace with the function name > provides a bit more context and could be useful when inspecting log. > > Signed-off-by: Leo Sandoval Reviewed-by: Daniel Kiper Daniel _

[PATCH 1/2] Include function name on debug traces

2025-04-11 Thread Leo Sandoval via Grub-devel
Together with the line number, the debug trace with the function name provides a bit more context and could be useful when inspecting log. Signed-off-by: Leo Sandoval --- grub-core/kern/misc.c | 4 ++-- include/grub/misc.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH] util/grub-install: Include raid5rec module for RAID 4 as well

2025-04-10 Thread Daniel Kiper
On Thu, Apr 10, 2025 at 10:55:02AM +0300, Egor Ignatov wrote: > RAID 4 requires the same recovery module as RAID 5. Extend the condition to > cover both RAID levels. > > Signed-off-by: Egor Ignatov Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mail

[PATCH] util/grub-install: Include raid5rec module for RAID 4 as well

2025-04-10 Thread Egor Ignatov
RAID 4 requires the same recovery module as RAID 5. Extend the condition to cover both RAID levels. Signed-off-by: Egor Ignatov --- util/grub-install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub-install.c b/util/grub-install.c index 7dc5657bb..060246589 100644

[PATCH v2 1/1] include/grub/i386/linux: Update linux_kernel_params to match upstream

2025-04-05 Thread Patrick Colp via Grub-devel
ick Colp --- grub-core/loader/i386/linux.c | 212 +++--- include/grub/i386/linux.h | 507 ++ 2 files changed, 440 insertions(+), 279 deletions(-) diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c index b7c1e057e14f..b54c4dd1b413 100644 --- a/grub-co

Re: [PATCH v2 1/1] include/grub/i386/linux: Update linux_kernel_params to match upstream

2025-04-04 Thread Daniel Kiper
On Thu, Apr 03, 2025 at 02:04:11PM -0700, Patrick Colp via Grub-devel wrote: > Update linux_kernel_params to match the latest upstream (v6.13.77) s/77/7/ > version of boot_params. Refactor most things out into structs, as the > Linux kernel does. > > "edid_info" should be a struct with "unsigned

Re: [PATCH] include/grub/i386/linux: Update linux_kernel_params to match upstream

2025-04-03 Thread Daniel Kiper
id_info. Make `edid_info` inline and only make it go up to 0x1b8. > > Signed-off-by: Patrick Colp > --- > grub-core/loader/i386/linux.c | 212 +++--- > include/grub/i386/linux.h | 503 ++ > 2 files changed, 436 insertions(+), 279 del

[PATCH 2/2] build: include missing header files in source tarball

2025-03-27 Thread Mike Gilbert
Fixes: 48e230c31 (key_protector: Add TPM2 Key Protector) Fixes: 99cda6788 (asn1_test: Test module for libtasn1) Signed-off-by: Mike Gilbert --- Makefile.util.def | 2 ++ grub-core/Makefile.core.def | 6 ++ 2 files changed, 8 insertions(+) diff --git a/Makefile.util.def b/Makefile.u

[PATCH] include/grub/i386/linux: Update linux_kernel_params to match upstream

2025-03-20 Thread Patrick Colp via Grub-devel
backwards compatibility, GRUB can have `efi_system_table` at 0x1b8 and padding at 0x1bc (or padding at both spots). This cuts into the end of edid_info. Make `edid_info` inline and only make it go up to 0x1b8. Signed-off-by: Patrick Colp --- grub-core/loader/i386/linux.c | 212 +++--- include

[PATCH v23 09/33] asn1_test: include asn1_test.h only

2024-11-14 Thread Gary Lin via Grub-devel
This commit removes all the headers and only uses asn1_test.h. To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, CONST_DOWN is defined in reproducers.c. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper --- ...7-asn1_test-include-asn1_test.h

[PATCH v22 09/33] asn1_test: include asn1_test.h only

2024-11-10 Thread Gary Lin via Grub-devel
This commit removes all the headers and only uses asn1_test.h. To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, CONST_DOWN is defined in reproducers.c. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper --- ...7-asn1_test-include-asn1_test.h

[PATCH v21 09/33] asn1_test: include asn1_test.h only

2024-11-03 Thread Gary Lin via Grub-devel
This commit removes all the headers and only uses asn1_test.h. To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, CONST_DOWN is defined in reproducers.c. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper --- ...7-asn1_test-include-asn1_test.h

[PATCH v1 09/15] console: Work around some minor include path weirdnesses

2024-10-31 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/arm/efi/console.h| 24 include/grub/arm64/efi/console.h | 24 include/grub/i386/efi/console.h | 24 include/grub/x86_64/efi/console.h | 24

[PATCH v20 09/33] asn1_test: include asn1_test.h only

2024-10-21 Thread Gary Lin via Grub-devel
This commit removes all the headers and only uses asn1_test.h. To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, CONST_DOWN is defined in reproducers.c. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper --- ...7-asn1_test-include-asn1_test.h

Re: [PATCH v19 09/33] asn1_test: include asn1_test.h only

2024-10-04 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:11:01PM +0800, Gary Lin via Grub-devel wrote: > This commit removes all the headers and only uses asn1_test.h. > To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, > CONST_DOWN is defined in reproducers.c. > > Signed-off-by: Daniel Axtens > Signed-off-by: Ga

Re: [PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

2024-10-02 Thread Leo Sandoval
On Mon, Sep 30, 2024 at 1:03 PM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Using titles is broken concept and the only reason we support it in > default is backwards compatibility. Maybe it's better to restrict it to > just IDs > > The word 'title' is still on the doc https://www.

Re: [PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

2024-09-30 Thread Vladimir 'phcoder' Serbinenko
Using titles is broken concept and the only reason we support it in default is backwards compatibility. Maybe it's better to restrict it to just IDs Le lun. 30 sept. 2024, 20:48, Leo Sandoval a écrit : > From: Peter Jones > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1026084 > > Sig

[PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

2024-09-30 Thread Leo Sandoval
From: Peter Jones Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1026084 Signed-off-by: Peter Jones --- grub-core/normal/menu.c | 85 - 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu

Re: [PATCH 10/24] include/grub: Introduce Secure Launch Resource Table (SLRT)

2024-09-17 Thread Ross Philipson via Grub-devel
the spec). I noticed you enhanced the error checking in the functions which is helpful. Since I was the originating author I cannot give an R-b but everything looks good. Ross Signed-off-by: Ross Philipson Signed-off-by: Sergii Dmytruk Signed-off-by: Krystian Hebel --- include/grub

[PATCH v19 09/33] asn1_test: include asn1_test.h only

2024-09-06 Thread Gary Lin via Grub-devel
This commit removes all the headers and only uses asn1_test.h. To avoid including int.h from grub-core/lib/libtasn1-grub/lib/, CONST_DOWN is defined in reproducers.c. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin --- ...7-asn1_test-include-asn1_test.h-only.patch | 163

[PATCH 10/24] include/grub: Introduce Secure Launch Resource Table (SLRT)

2024-08-26 Thread Sergii Dmytruk
From: Ross Philipson Provide definitions of structures and basic functions for constructing and parsing of SLRT. Signed-off-by: Ross Philipson Signed-off-by: Sergii Dmytruk Signed-off-by: Krystian Hebel --- include/grub/slr_table.h | 328 +++ 1 file

Re: [PATCH 1/2] Allow "fallback" to include entries by title, not just number.

2024-04-22 Thread Vladimir 'phcoder' Serbinenko
Selecting by title is deprecated and kept only for compatibility. Please use id instead Le lun. 22 avr. 2024, 17:56, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> a écrit : > From: Peter Jones > > Resolves: rhbz#1026084 > > Signed-off-by: Peter Jones > --- > grub-core/normal/me

[PATCH 1/2] Allow "fallback" to include entries by title, not just number.

2024-04-22 Thread Marek Marczykowski-Górecki
From: Peter Jones Resolves: rhbz#1026084 Signed-off-by: Peter Jones --- grub-core/normal/menu.c | 85 -- 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c index 6a90e09..6444ee6 100644 --- a

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2024-02-22 Thread Oliver Steffen
Quoting Daniel Kiper (2023-12-22 15:18:44) > On Thu, Dec 21, 2023 at 01:17:35AM -0600, Oskari Pirhonen wrote: > > Fixes build failure due to the extra_deps.lst file not existing in the > > tarball. Found while trying to package GRUB 2.12 for Gentoo. > > > > make[3]: *** No rule to make target > >

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-22 Thread Daniel Kiper
On Fri, Dec 22, 2023 at 12:45:53AM -0600, Oskari Pirhonen wrote: > On Thu, Dec 21, 2023 at 03:07:16 -0800, Oliver Steffen wrote: > > Quoting Olaf Hering (2023-12-21 11:50:49) > > > Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen : > > > > > > > Although its name suggests that it is a generated file

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-22 Thread Daniel Kiper
On Thu, Dec 21, 2023 at 01:17:35AM -0600, Oskari Pirhonen wrote: > Fixes build failure due to the extra_deps.lst file not existing in the > tarball. Found while trying to package GRUB 2.12 for Gentoo. > > make[3]: *** No rule to make target > '/var/tmp/portage/sys-boot/grub-2.12/work/grub-2.12/gru

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Oskari Pirhonen
On Thu, Dec 21, 2023 at 03:07:16 -0800, Oliver Steffen wrote: > Quoting Olaf Hering (2023-12-21 11:50:49) > > Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen : > > > > > Although its name suggests that it is a generated file (.lst ending!), > > > extra_deps.lst is actually tracked in git and is not

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Oliver Steffen
Quoting Olaf Hering (2023-12-21 11:50:49) > Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen : > > > Although its name suggests that it is a generated file (.lst ending!), > > extra_deps.lst is actually tracked in git and is not generated by the > > build system. > > I think a simple "echo 'content'

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Oliver Steffen
Quoting Oskari Pirhonen (2023-12-21 08:17:35) > Fixes build failure due to the extra_deps.lst file not existing in the > tarball. Found while trying to package GRUB 2.12 for Gentoo. > > make[3]: *** No rule to make target > '/var/tmp/portage/sys-boot/grub-2.12/work/grub-2.12/grub-core/extra_deps.l

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Olaf Hering
Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen : > Although its name suggests that it is a generated file (.lst ending!), > extra_deps.lst is actually tracked in git and is not generated by the > build system. I think a simple "echo 'content' > extra_deps.lst" in a Makefile would do. Olaf pgp

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Oliver Steffen
Quoting Olaf Hering (2023-12-21 10:12:24) > Thu, 21 Dec 2023 01:17:35 -0600 Oskari Pirhonen : > > > Fixes build failure due to the extra_deps.lst file not existing in the > > tarball. > > Maybe maybe maybe this is another slight hint that this file needs to be > generated at build time, like all

Re: [PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-21 Thread Olaf Hering
Thu, 21 Dec 2023 01:17:35 -0600 Oskari Pirhonen : > Fixes build failure due to the extra_deps.lst file not existing in the > tarball. Maybe maybe maybe this is another slight hint that this file needs to be generated at build time, like all the other similar files? Olaf pgpZAPrAL29FG.pgp De

[PATCH] build: Include grub-core/extra_deps.lst in dist

2023-12-20 Thread Oskari Pirhonen
Fixes build failure due to the extra_deps.lst file not existing in the tarball. Found while trying to package GRUB 2.12 for Gentoo. make[3]: *** No rule to make target '/var/tmp/portage/sys-boot/grub-2.12/work/grub-2.12/grub-core/extra_deps.lst', needed by 'syminfo.lst'. Stop. Fixes: 89fbe0cac

Re: [PATCH v5 04/16] include/grub/misc.h: Fix edge case in grub_uuidcasecmp()

2023-08-31 Thread Daniel Kiper
s > > > after a dash character '-'. > > > > > > Signed-off-by: Vitaly Kuzmichev > > > --- > > >  include/grub/misc.h | 3 ++- > > >  1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/grub/misc.h b/inclu

Re: [PATCH v5 04/16] include/grub/misc.h: Fix edge case in grub_uuidcasecmp()

2023-08-31 Thread Vitaly Kuzmichev
null terminators > > and actual result depends on whatever garbage follows them. > > > > So break immediately when it reaches the end in any of the strings > > after a dash character '-'. > > > > Signed-off-by: Vitaly Kuzmichev > > --

Re: [PATCH v5 04/16] include/grub/misc.h: Fix edge case in grub_uuidcasecmp()

2023-08-31 Thread Daniel Kiper
t; So break immediately when it reaches the end in any of the strings > after a dash character '-'. > > Signed-off-by: Vitaly Kuzmichev > --- > include/grub/misc.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/grub/misc.h b/i

Re: [PATCH v5 06/16] include/grub/charset.h: Enhance grub_utf16_to_utf8()

2023-08-23 Thread Vitaly Kuzmichev
Hi Vladimir, On Tue, 2023-08-22 at 23:55 +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > diff --git a/include/grub/charset.h b/include/grub/charset.h > > index 31a3b52dd..635d6df9e 100644 > > --- a/include/grub/charset.h > >

Re: [PATCH v5 08/16] include/grub/charset.h: Add grub_utf16_to_utf8_alloc()

2023-08-22 Thread Vladimir 'phcoder' Serbinenko
to existing inversed function grub_utf8_to_utf16_alloc() > in kern/misc.c. > > Signed-off-by: Vitaly Kuzmichev > --- > include/grub/charset.h | 28 > 1 file changed, 28 insertions(+) > > diff --git a/include/grub/charset.h b/include/grub/charset.h

Re: [PATCH v5 06/16] include/grub/charset.h: Enhance grub_utf16_to_utf8()

2023-08-22 Thread Vladimir 'phcoder' Serbinenko
> > > diff --git a/include/grub/charset.h b/include/grub/charset.h > index 31a3b52dd..635d6df9e 100644 > --- a/include/grub/charset.h > +++ b/include/grub/charset.h > @@ -49,6 +49,13 @@ > #define GRUB_UTF16_LOWER_SURROGATE(code) \ >(0xDC00 | (((code) - GRUB_UCS2_LI

Re: [PATCH v5 07/16] include/grub/charset.h: Add grub_utf16_{strlen, strnlen}()

2023-08-22 Thread Vladimir 'phcoder' Serbinenko
LGTM Le mar. 22 août 2023, 23:41, Vitaly Kuzmichev a écrit : > Add two functions to calculate UTF-16 string length. The address to > UTF-16 string could be unaligned, so use grub_get_unaligned16() to > iterate over characters. > > Signed-off-by: Vitaly Kuzmichev > --- > i

[PATCH v5 08/16] include/grub/charset.h: Add grub_utf16_to_utf8_alloc()

2023-08-22 Thread Vitaly Kuzmichev
-off-by: Vitaly Kuzmichev --- include/grub/charset.h | 28 1 file changed, 28 insertions(+) diff --git a/include/grub/charset.h b/include/grub/charset.h index 099f23fbe..4324fefb8 100644 --- a/include/grub/charset.h +++ b/include/grub/charset.h @@ -20,6 +20,9

[PATCH v5 06/16] include/grub/charset.h: Enhance grub_utf16_to_utf8()

2023-08-22 Thread Vitaly Kuzmichev
+- grub-core/fs/udf.c | 3 ++- grub-core/kern/efi/efi.c | 15 ++- grub-core/loader/efi/chainloader.c | 2 +- grub-core/loader/i386/xnu.c | 2 +- grub-core/osdep/windows/hostdisk.c | 2 +- include/grub/charset.h | 16

[PATCH v5 07/16] include/grub/charset.h: Add grub_utf16_{strlen, strnlen}()

2023-08-22 Thread Vitaly Kuzmichev
Add two functions to calculate UTF-16 string length. The address to UTF-16 string could be unaligned, so use grub_get_unaligned16() to iterate over characters. Signed-off-by: Vitaly Kuzmichev --- include/grub/charset.h | 26 ++ 1 file changed, 26 insertions(+) diff

[PATCH v5 04/16] include/grub/misc.h: Fix edge case in grub_uuidcasecmp()

2023-08-22 Thread Vitaly Kuzmichev
character '-'. Signed-off-by: Vitaly Kuzmichev --- include/grub/misc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/misc.h b/include/grub/misc.h index 1b35a167f..12fade5de 100644 --- a/include/grub/misc.h +++ b/include/grub/misc.h @@ -264,7 +264,8 @@ grub_uui

[PATCH 2/3] include/grub/types.h: Add PRI*GRUB_OFFSET and PRI*GRUB_DISK_ADDR

2023-06-28 Thread Glenn Washburn
These are currently always the same as PRI*GRUB_UINT64_T, but they may not be in the future. Signed-off-by: Glenn Washburn --- include/grub/types.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/grub/types.h b/include/grub/types.h index 9f43a5580935

[PATCH 2/3] include/grub/i386/linux.h support xloadflags

2022-12-05 Thread Jeremy Szu
Protocal 2.13 (Kernel 3.14) supports xloadflags to check the kernel supported boot loader. It's also kernel recommended to use. --- include/grub/i386/linux.h | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/include/grub/i386/linux.h b/include/grub

[PATCH 21/21] include: Remove trailing whitespaces

2022-03-03 Thread Elyes Haouas
Signed-off-by: Elyes Haouas --- include/grub/arc/arc.h | 4 ++-- include/grub/bitmap_scale.h | 2 +- include/grub/charset.h | 4 ++-- include/grub/crypto.h| 10 include/grub/datetime.h | 4 ++-- include/grub/disk.h

[PATCH 2/4] docs: Update development docs to include information on running test suite

2021-11-05 Thread Glenn Washburn
Add a section with minimal description on setting up and running the test suite with a link to the INSTALL documentation which is a little more detailed in terms of package requirements. Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 12 1 file changed, 12 insertions(+) dif

[PATCH v3] xfs: Include needsrepair in the supported incompat features list

2021-05-03 Thread Javier Martinez Canillas
XFS now has an incompat feature flag to indicate that the filesystem needs to be repaired. The Linux kernel refuses to mount a filesystem that has it set and only the xfs_repair tool is able to clear that flag. The GRUB doesn't have the concept of mounting filesystems and just attempt to read the

[PATCH 2/9] include/grub/i386/linux.h: Include missing header

2020-12-03 Thread Javier Martinez Canillas
This header uses types defined in but does not include it, which leads to compile errors like the following: In file included from ../include/grub/cpu/linux.h:19, from kern/efi/sb.c:21: ../include/grub/i386/linux.h:80:3: error: unknown type name ‘grub_uint64_t’ 80

[PATCH 1/9] i386: Don't include in coreboot and ieee1275 startup.S

2020-12-03 Thread Javier Martinez Canillas
Nothing defined in the header file is used in the assembly code but it may lead to build errors if some headers are included through this and contains definitions that are not recognized by the assembler, e.g.: ../include/grub/types.h: Assembler messages: ../include/grub/types.h:76: Error: no

Re: [PATCH] arm64: Include missing header

2020-11-20 Thread Daniel Kiper
On Mon, Nov 09, 2020 at 11:40:14AM +0100, Javier Martinez Canillas wrote: > This header uses types defined in but does not include it, > which leads to lead compile errors like the following: > > ../include/grub/cpu/linux.h:27:3: error: unknown type name ‘grub_uint32_t’ >27 |

Re: [PATCH 1/2] loader/i386/linux: Include missing header

2020-11-18 Thread Daniel Kiper
On Thu, Nov 05, 2020 at 03:58:56PM +0100, Javier Martinez Canillas wrote: > This header uses types defined in but does not include it, > which leads to lead compile errors like the following: > > In file included from ../include/grub/cpu/linux.h:19, > from k

[PATCH] arm64: Include missing header

2020-11-09 Thread Javier Martinez Canillas
This header uses types defined in but does not include it, which leads to lead compile errors like the following: ../include/grub/cpu/linux.h:27:3: error: unknown type name ‘grub_uint32_t’ 27 | grub_uint32_t code0; /* Executable code */ | ^ Signed-off-by: Javier

[PATCH 1/2] loader/i386/linux: Include missing header

2020-11-05 Thread Javier Martinez Canillas
This header uses types defined in but does not include it, which leads to lead compile errors like the following: In file included from ../include/grub/cpu/linux.h:19, from kern/efi/sb.c:21: ../include/grub/i386/linux.h:80:3: error: unknown type name ‘grub_uint64_t’ 80

[PATCH 2/2] arm: Include missing header

2020-11-05 Thread Javier Martinez Canillas
The header uses the EXPORT_FUNC() macro defined in but doens't include it, which leads to the following compile error on arm: ../include/grub/cpu/system.h:12:13: error: ‘EXPORT_FUNC’ declared as function returning a function 12 | extern void EXPORT_FUNC(grub_arm_disable_caches_mmu)

Re: [PATCH 5/6] i386/efi/init: Drop bogus include

2020-05-28 Thread Javier Martinez Canillas
-- a/grub-core/kern/i386/efi/init.c > +++ b/grub-core/kern/i386/efi/init.c > @@ -27,7 +27,6 @@ > #include > #include > #include > -#include > > void > grub_machine_init (void) > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canill

[PATCH 5/6] i386/efi/init: Drop bogus include

2020-05-25 Thread Daniel Kiper
+27,6 @@ #include #include #include -#include void grub_machine_init (void) -- 2.11.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH, v6] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-27 Thread John Paul Adrian Glaubitz
On 3/27/19 12:36 PM, Daniel Kiper wrote: > On Tue, Mar 26, 2019 at 09:45:02AM -0600, Eric Snowberg wrote: >>> On Mar 26, 2019, at 3:47 AM, John Paul Adrian Glaubitz >>> wrote: >>> Recent versions of binutils dropped support for the a.out and COFF >>> formats on sparc64 targets. Since the boot loa

Re: [PATCH, v6] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-27 Thread Daniel Kiper
On Tue, Mar 26, 2019 at 09:45:02AM -0600, Eric Snowberg wrote: > > On Mar 26, 2019, at 3:47 AM, John Paul Adrian Glaubitz > > wrote: > > Recent versions of binutils dropped support for the a.out and COFF > > formats on sparc64 targets. Since the boot loader on sparc64 is > > supposed to be an a.o

Re: [PATCH, v6] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-26 Thread Eric Snowberg
> On Mar 26, 2019, at 3:47 AM, John Paul Adrian Glaubitz > wrote: > > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calcul

Re: [PATCH, v6] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-26 Thread Daniel Kiper
On Tue, Mar 26, 2019 at 10:47:16AM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

Re: [PATCH v2] POTFILES: Don't include gnulib in grub.pot

2019-03-26 Thread Daniel Kiper
On Mon, Mar 25, 2019 at 04:23:05PM +0100, Vladimir 'phcoder' Serbinenko wrote: > >From 25923d90b80709b11969cd56baddd8e898d7b9b5 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 16:06:18 +0100 > Subject: [PATCH] POTFILES: Don't include

[PATCH, v6] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-26 Thread John Paul Adrian Glaubitz
| 16 +++ grub-core/boot/sparc64/ieee1275/boot.S | 27 +++--- include/grub/sparc64/ieee1275/boot.h | 3 +-- 3 files changed, 37 insertions(+), 9 deletions(-) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 43ed42191..474a63e68 10

[PATCH, v5] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-26 Thread John Paul Adrian Glaubitz
oot.S | 27 +++--- include/grub/sparc64/ieee1275/boot.h | 3 +-- 3 files changed, 37 insertions(+), 9 deletions(-) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 43ed42191..cda8ea34c 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefil

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 3:11 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 9:41 PM, Eric Snowberg wrote: >>> Is this on Solaris? I want to try reproducing it, so I can figure what >>> happened. >>> >> >> I’m using Oracle Linux for SPARC (6.9). > > Ok, so it can only be a matter of the

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
T_AOUT_HEADER_SIZE boot_path: - .org GRUB_BOOT_MACHINE_KERNEL_BYTE + .org GRUB_BOOT_MACHINE_KERNEL_BYTE + GRUB_BOOT_AOUT_HEADER_SIZE boot_path_end: kernel_byte: .xword (2 << 9) kernel_address: .word GRUB_BOOT_MACHINE_KERNEL_ADDR @@ -52,7 +73,7 @@ kernel_address: .word GRUB_B

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 1:21 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 5:20 PM, Eric Snowberg wrote: >> I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I >> missing something? >> >> Before the patch: >> >> $ grub-install --force --skip-fs-probe /dev/sdb1

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:22 PM, John Paul Adrian Glaubitz wrote: > I am not done testing yet but I just realized, 544 = 512 + 32, so it looks > like the a.out header is appended twice. Does an older binutils maybe default > to a.out when just passing binary as the output format? Just did another test build, t

[dki...@net-space.pl: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot]

2019-03-25 Thread Daniel Kiper
- Forwarded message from Daniel Kiper - Date: Mon, 25 Mar 2019 15:29:55 +0100 From: Daniel Kiper To: Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot User-Agent: NeoMutt/20170113 (1.7.2) On Mon, Mar 25, 2019 at 03:22:21PM

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:17 PM, John Paul Adrian Glaubitz wrote: >> $ grub-install --force --skip-fs-probe /dev/sdb1 >> Installing for sparc64-ieee1275 platform. >> grub-install: error: the size of `/boot/grub/sparc64-ieee1275/boot.img' is >> not 512. >> >> $ ls -al /boot/grub/sparc64-ieee1275/boot.img >> -rw

Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Colin Watson
On Mon, Mar 25, 2019 at 03:24:25PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still > > included. And as Colin pointed out missing SOB. > > This directory still exists, a

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 5:45 AM, Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: >> Recent versions of binutils dropped support for the a.out and COFF >> formats on sparc64 targets. Since the boot loader on sparc64 is >> supposed to be an a.out bi

[PATCH v2] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
>From 25923d90b80709b11969cd56baddd8e898d7b9b5 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Fri, 22 Mar 2019 16:06:18 +0100 Subject: [PATCH] POTFILES: Don't include gnulib in grub.pot They're translated as a separate project, so we don't want to submit them aga

Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Mon, Mar 25, 2019 at 3:22 PM Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot To: Daniel Kiper On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch d

Re: [PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 11:54:45PM +, Colin Watson wrote: > Ah, this explains some strangeness I was seeing. Thanks. > > Reviewed-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

Re: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Daniel Kiper
Sadly this patch does not look complete. ./grub-core/lib/gnulib is still included. And as Colin pointed out missing SOB. Could you send the patches in the email body instead of the attachments? git send-email? Daniel ___ Grub-devel mailing list Grub-de

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

Re: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-22 Thread Colin Watson
(Missing Signed-off-by.) Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

2019-03-22 Thread Colin Watson
Ah, this explains some strangeness I was seeing. Thanks. Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub

[PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

2019-03-22 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0003-kern-emu-misc.c-Don-t-include-config-util.h-when-run.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-22 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-POTFILES-Don-t-include-gnulib-in-grub.pot.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

  1   2   3   >