Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

On Fri, Dec 25, 2009 at 06:21:58PM +0100, Felix Zielcke wrote: > Am Donnerstag, den 24.12.2009, 22:55 +0100 schrieb Robert Millan: > > On Tue, Dec 22, 2009 at 09:39:07PM +0530, BVK Chaitanya wrote: > > > Hi > > > > > > > > > Attached is the patch, which removes use of undefined > > grub_assert_fa

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

Am Donnerstag, den 24.12.2009, 22:55 +0100 schrieb Robert Millan: > On Tue, Dec 22, 2009 at 09:39:07PM +0530, BVK Chaitanya wrote: > > Hi > > > > > > Attached is the patch, which removes use of undefined > grub_assert_fail > > function for catching bad-type-cast errors, with a better version > >

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

On Tue, Dec 22, 2009 at 09:39:07PM +0530, BVK Chaitanya wrote: > Hi > > > Attached is the patch, which removes use of undefined grub_assert_fail > function for catching bad-type-cast errors, with a better version > __attribute__((error("msg"))) gcc extension. With this extension, gcc > can give

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009/12/23 Gre'goire Sutre : > > For your information, I tested it on NetBSD 5.0 (with default gcc 4.1.3), > and everything seems fine. > Thanks Gre'goire. I wanted to ask you to verify, but i forgot to mention :-( -- bvk.chaitanya ___ Grub-devel

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

BVK Chaitanya wrote: Attached patch has __LINE__ and __FILE__ tags added. For your information, I tested it on NetBSD 5.0 (with default gcc 4.1.3), and everything seems fine. Thanks, Gre'goire ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009/12/22 Vladimir 'φ-coder/phcoder' Serbinenko : >> ./include/grub/list.h:44: warning: 'error' attribute directive ignored > This situation is acceptable. In unlikely case that cast is indeed bad > you will get runtime error instead of compile error. But it would be a > benefit if abort message w

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

Grégoire Sutre wrote: > Hi, > > > Unfortunately, I couldn't test this on NetBSD, where old technique was > > reported failing as GCC optimizations didn't happen. Can Grégoire > > Sutr or anybody else try this out on NetBSD and confirm? > > Thanks for looking into this. > > I tested the second vers

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

Am Dienstag, den 22.12.2009, 18:07 +0100 schrieb Grégoire Sutre: > This is on NetBSD 5.0 with gcc 4.1.3 (the default). > If I use gcc 4.4 instead, then I do not get any warning. It looks like gcc 4.3 introduced the error attribute. But this isn't documented at the gcc.gnu.org/gcc-4.X/changes.htm

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

Hi, > Unfortunately, I couldn't test this on NetBSD, where old technique was > reported failing as GCC optimizations didn't happen. Can Grégoire > Sutr or anybody else try this out on NetBSD and confirm? Thanks for looking into this. I tested the second version of the patch. Linking now works

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

grub_fatal already calls grub_abort, so grub_abort line is removed. -- bvk.chaitanya === modified file 'include/grub/handler.h' --- include/grub/handler.h 2009-03-01 17:51:44 + +++ include/grub/handler.h 2009-12-22 13:34:38 + @@ -55,6 +55,6 @@ GRUB_FIELD_MATCH (ptr, grub_

Fix for grub_assert_fail undefined on NetBSD and other platforms

Hi Attached is the patch, which removes use of undefined grub_assert_fail function for catching bad-type-cast errors, with a better version __attribute__((error("msg"))) gcc extension. With this extension, gcc can give the exact location of the bad type cast at compile time. Unfortunately, I co