Committed.
On Sat, Mar 21, 2009 at 11:49:18PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Sat, Mar 21, 2009 at 07:05:23PM +0100, phcoder wrote:
>>> Robert Millan wrote:
On Sat, Mar 21, 2009 at 06:58:58PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Wed, Mar 18, 2009 at 0
On Sat, Mar 21, 2009 at 11:03:12PM +0100, Robert Millan wrote:
> >>
> > No but it always corresponds to the current image. It's set either in
> > multiboot.c or in grub_multiboot_load_elf
>
> It is now, but your code makes this conditional.
My bad. This' been clarified on IRC. Sometimes I rea
Robert Millan wrote:
On Sat, Mar 21, 2009 at 07:05:23PM +0100, phcoder wrote:
Robert Millan wrote:
On Sat, Mar 21, 2009 at 06:58:58PM +0100, phcoder wrote:
Robert Millan wrote:
On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:52:39PM +
On Sat, Mar 21, 2009 at 07:05:23PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Sat, Mar 21, 2009 at 06:58:58PM +0100, phcoder wrote:
>>> Robert Millan wrote:
On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Fri, Mar 13, 2009 at 09:52:39PM +01
Robert Millan wrote:
On Sat, Mar 21, 2009 at 06:58:58PM +0100, phcoder wrote:
Robert Millan wrote:
On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
- grub_multiboot_payload_entry_offset = ehdr->e_entry -
On Sat, Mar 21, 2009 at 06:58:58PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
>>> Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
> - grub_multiboot_payload_entry_offset = ehdr->e_entry -
> ph
Robert Millan wrote:
On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
- grub_multiboot_payload_entry_offset = ehdr->e_entry -
phdr(lowest_segment)->p_vaddr;
+ for (i = 0; i < ehdr->e_phnum; i++)
+if (p
On Wed, Mar 18, 2009 at 02:26:40PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
>>> - grub_multiboot_payload_entry_offset = ehdr->e_entry -
>>> phdr(lowest_segment)->p_vaddr;
>>> + for (i = 0; i < ehdr->e_phnum; i++)
>>> +if (phdr(i
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
- grub_multiboot_payload_entry_offset = ehdr->e_entry -
phdr(lowest_segment)->p_vaddr;
+ for (i = 0; i < ehdr->e_phnum; i++)
+if (phdr(i)->p_vaddr <= ehdr->e_entry
+ && phdr(i)->p_vaddr + phdr(i)->p_memsz > ehd
On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
> - grub_multiboot_payload_entry_offset = ehdr->e_entry -
> phdr(lowest_segment)->p_vaddr;
> + for (i = 0; i < ehdr->e_phnum; i++)
> +if (phdr(i)->p_vaddr <= ehdr->e_entry
> + && phdr(i)->p_vaddr + phdr(i)->p_memsz > ehdr->e_entry
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:41:42PM +0100, phcoder wrote:
Robert Millan wrote:
On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
+ * include/grub/elf.h: added missing attributes
Th
On Sat, Mar 14, 2009 at 12:01:13AM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Fri, Mar 13, 2009 at 09:41:42PM +0100, phcoder wrote:
>>> Robert Millan wrote:
On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Mon, Mar 02, 2009 at 01:35:06AM +01
Robert Millan wrote:
On Fri, Mar 13, 2009 at 09:41:42PM +0100, phcoder wrote:
Robert Millan wrote:
On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
+ * include/grub/elf.h: added missing attributes
Th
On Fri, Mar 13, 2009 at 09:41:42PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
>>> Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
> + * include/grub/elf.h: added missing attributes
This should
--
Regards
Vladimir 'phcoder' Serbinenko
--- Begin Message ---
From: phcoder
Date: Fri, 13 Mar 2009 21:49:39 +0100
> David Miller wrote:
> > From: phcoder
> > Date: Fri, 13 Mar 2009 21:41:42 +0100
> >
> >> Actually our segment table is also our table for transforming
> >> between virtual and
David Miller wrote:
From: phcoder
Date: Fri, 13 Mar 2009 21:41:42 +0100
Actually our segment table is also our table for transforming
between virtual and physical address. I don't see why entry point
would be defined against virtual address of lowest physical segement
I would suggest simply
From: phcoder
Date: Fri, 13 Mar 2009 21:41:42 +0100
> Actually our segment table is also our table for transforming
> between virtual and physical address. I don't see why entry point
> would be defined against virtual address of lowest physical segement
I would suggest simply looping over the p
Robert Millan wrote:
On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
+ * include/grub/elf.h: added missing attributes
This should be a bit more descriptive.
for (i = 0; i < ehdr->e_phnum; i++)
On Wed, Mar 11, 2009 at 10:21:41PM +0100, phcoder wrote:
> Robert Millan wrote:
>> On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
>>> + * include/grub/elf.h: added missing attributes
>>
>> This should be a bit more descriptive.
>>
>>>for (i = 0; i < ehdr->e_phnum; i++)
>>> if (
From: phcoder
Date: Thu, 12 Mar 2009 14:43:51 +0100
> Actually what I was doing now was discussing. If we don't discuss we
> may everyone create our own fork. I previously had problems because
> some of the structures in headers didn't have proper alignment
> attribute. My problem was that grub2
David Miller wrote:
From: phcoder
Date: Thu, 12 Mar 2009 14:21:45 +0100
I knew it but normally when you parse files normally offsets aren't
guaranteed to be aligned. But now it seems that elf parser is
written in a way to guarantee at least some alignments. Then this
part of patch probably is
--
Regards
Vladimir 'phcoder' Serbinenko
--- Begin Message ---
David Miller wrote:
From: phcoder
Date: Thu, 12 Mar 2009 12:22:15 +0100
David Miller wrote:
From: phcoder
Date: Thu, 12 Mar 2009 09:23:34 +0100
Index: include/grub/elf.h
==
From: phcoder
Date: Thu, 12 Mar 2009 09:23:34 +0100
> Index: include/grub/elf.h
> ===
> --- include/grub/elf.h(revision 2036)
> +++ include/grub/elf.h(working copy)
> @@ -77,7 +77,7 @@
>Elf32_Half e_shentsize;
Fixed
phcoder wrote:
Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
+* include/grub/elf.h: added missing attributes
This should be a bit more descriptive.
for (i = 0; i < ehdr->e_phnum; i++)
if (phdr(i)->p_type == PT_LOAD && phdr(i)->p_filesz != 0)
Robert Millan wrote:
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
+ * include/grub/elf.h: added missing attributes
This should be a bit more descriptive.
for (i = 0; i < ehdr->e_phnum; i++)
if (phdr(i)->p_type == PT_LOAD && phdr(i)->p_filesz != 0)
{
- i
On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote:
> + * include/grub/elf.h: added missing attributes
This should be a bit more descriptive.
>for (i = 0; i < ehdr->e_phnum; i++)
> if (phdr(i)->p_type == PT_LOAD && phdr(i)->p_filesz != 0)
>{
> - if (phdr(i)->p_paddr
Hello I discovered some bugs in multiboot-elf. Here is bugfix
--
Regards
Vladimir 'phcoder' Serbinenko
Index: ChangeLog
===
--- ChangeLog (revision 2010)
+++ ChangeLog (working copy)
@@ -1,3 +1,12 @@
+2009-03-01 Vladimir Serbinenko
27 matches
Mail list logo
