[PATCH v8 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-30 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 0f420d5b4..a3cb2a11a 100644 --- a/grub-core/kern

[PATCH v7 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-27 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 0f420d5b4..a3cb2a11a 100644 --- a/grub-core/kern

Re: [PATCH v6 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-21 Thread Daniel Kiper
On Mon, Nov 20, 2023 at 09:50:07AM -0500, Stefan Berger wrote: > Display upper_mem_limit and its rounded-down value in MiB. > > Signed-off-by: Stefan Berger Reviewed-by: Daniel Kiper I will push this patch set together with other patches this week. Thanks, Daniel

[PATCH v6 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-20 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 164cccb2a..72e0292a3 100644 --- a/grub-core/kern

[PATCH v5 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-15 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 164cccb2a..72e0292a3 100644 --- a/grub-core/kern

[PATCH v4 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-10 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 164cccb2a..72e0292a3 100644 --- a/grub-core/kern

[PATCH v3 10/10] kern/ieee1275/init: ppc64: Display upper_mem_limit for debugging

2023-11-10 Thread Stefan Berger
Display upper_mem_limit and its rounded-down value in MiB. Signed-off-by: Stefan Berger --- grub-core/kern/ieee1275/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index a128a314e..a18d74092 100644 --- a/grub-core/kern

Re: [PATCH] tests/util/grub-shell-luks-tester: Do not remove generated files when test fails to allow debugging

2023-08-17 Thread Daniel Kiper
On Mon, Aug 14, 2023 at 03:00:10PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-17 Thread Olaf Hering
Wed, 16 Aug 2023 12:53:48 -0500 Glenn Washburn : > I specifically wanted these two sections to be subsections of > x86_64-efi and not at the same level as i386-pc, hence why I have them > as subsections. I suspect that the issue could be fixed by adding a > @menu in the x86_64-efi section with the

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-16 Thread Glenn Washburn
On Wed, 16 Aug 2023 10:41:40 +0200 Olaf Hering wrote: > Wed, 16 Aug 2023 00:29:28 -0500 Glenn Washburn : > > > Anyway, since you're the first and *so far* only person seeing this, > > could you submit a patch that fixes this for you? It would be great to > > support older makeinfos (if that is i

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-16 Thread Olaf Hering
Wed, 16 Aug 2023 00:29:28 -0500 Glenn Washburn : > Anyway, since you're the first and *so far* only person seeing this, > could you submit a patch that fixes this for you? It would be great to > support older makeinfos (if that is indeed the issue) in the upcoming > release. The change below fixe

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 22:37:08 +0200 Olaf Hering wrote: > Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > > > I'm not seeing this issue when building on Debian 11. I'm successfully > > building the info, html, and pdf documentation from the texi files > > using debians texinfo package at versio

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > I'm not seeing this issue when building on Debian 11. I'm successfully > building the info, html, and pdf documentation from the texi files > using debians texinfo package at version 6.7.0.dfsg.2-6. Are you sure > you are building from clean sourc

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 10:14:07 +0200 Olaf Hering wrote: > Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > > > Right now patch is in the git repo. If you want to improve that part of > > doc please send a fix to grub-devel and CC interested folks. > > Yeah, that is very unfortunate, because it br

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > Right now patch is in the git repo. If you want to improve that part of > doc please send a fix to grub-devel and CC interested folks. Yeah, that is very unfortunate, because it breaks the build: https://lists.gnu.org/archive/html/bug-grub/2023-06/

[PATCH] tests/util/grub-shell-luks-tester: Do not remove generated files when test fails to allow debugging

2023-08-14 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- tests/util/grub-shell-luks-tester.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/grub-shell-luks-tester.in b/tests/util/grub-shell-luks-tester.in index 850a20d6a7a8..3f9d1be17644 100644 --- a/tests/util/grub-shell-luks-teste

Re: [PATCH 0/4] More grub shell debugging

2023-07-13 Thread Daniel Kiper
On Mon, Jul 10, 2023 at 10:01:15PM -0500, Glenn Washburn wrote: > These are fairly trivial patches making it easier to turn on debugging > when running tests. > > Glenn > > Glenn Washburn (4): > grub-shell: Add --verbose to mkrescue when $debug is greater than 2 > g

[PATCH 0/4] More grub shell debugging

2023-07-10 Thread Glenn Washburn
These are fairly trivial patches making it easier to turn on debugging when running tests. Glenn Glenn Washburn (4): grub-shell: Add --verbose to mkrescue when $debug is greater than 2 grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar grub-shell: Allow

Re: [PATCH v2] docs: Minor edits to debugging chapter

2023-06-28 Thread Daniel Kiper
On Mon, Jun 26, 2023 at 12:12:33PM -0500, Glenn Washburn wrote: > On Sun, 25 Jun 2023 14:27:57 -0500 > Oskari Pirhonen wrote: > > > Small set of wording and grammatical edits which did not make it in time > > for the original review of the chapter. > > LGTM. > > Reviewed-by: Glenn Washburn Revie

Re: [PATCH v2] docs: Minor edits to debugging chapter

2023-06-26 Thread Glenn Washburn
tions is taken care of automatically > +when loading the kernel symbols via the user-defined GDB command > +@command{dynamic_load_kernel_exec_symbols}, which takes one argument, the > +address where the text section is loaded as determined by one of the methods > +above. Alternatively,

[PATCH v2] docs: Minor edits to debugging chapter

2023-06-25 Thread Oskari Pirhonen
d by one of the methods +above. Alternatively, the command @command{dynamic_load_symbols} with the text +section address as an agrument can be called to load the kernel symbols and set +up loading the module symbols as they are loaded at runtime. In the author's experience, when debugging wi

Re: [PATCH] docs: Minor edits to debugging chapter

2023-06-22 Thread Oskari Pirhonen
of the > > methods > > +above. Alternatively, the command @command{dynamic_load_symbols} with the > > text > > +section address as an agrument can be called to load the kernel symbols > > and set > > +up loading the module symbols as they are loaded at runtime.

Re: [PATCH] docs: Minor edits to debugging chapter

2023-06-22 Thread Glenn Washburn
Alternatively, the command @command{dynamic_load_symbols} with the > text > +section address as an agrument can be called to load the kernel symbols and > set > +up loading the module symbols as they are loaded at runtime. > > In the author's experience, when debuggin

[PATCH] docs: Minor edits to debugging chapter

2023-06-18 Thread Oskari Pirhonen
above. Alternatively, the command @command{dynamic_load_symbols} with the text +section address as an agrument can be called to load the kernel symbols and set +up loading the module symbols as they are loaded at runtime. In the author's experience, when debugging with QEMU and OVMF, to have

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Oskari Pirhonen
On Thu, Jun 15, 2023 at 13:06:09 +0200, Daniel Kiper wrote: > On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > > Oops, apologies for the late reply. Reading through it again, I found a > > few more small nits: > > Right now patch is in the git repo. If you want to improve that pa

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Daniel Kiper
On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > Oops, apologies for the late reply. Reading through it again, I found a > few more small nits: Right now patch is in the git repo. If you want to improve that part of doc please send a fix to grub-devel and CC interested folks. Da

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-14 Thread Oskari Pirhonen
Oops, apologies for the late reply. Reading through it again, I found a few more small nits: On Tue, Jun 06, 2023 at 00:48:39 -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debuggin

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-12 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 12:48:39AM -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debugging GRUB > with less effort. > > Signed-off-by: Glenn Washburn Reviewed-by: Danie

[PATCH v3] docs: Add debugging chapter to development documentation

2023-06-05 Thread Glenn Washburn
Debugging GRUB can be tricky and require arcane knowledge. This will help those unfamiliar with the process to get started debugging GRUB with less effort. Signed-off-by: Glenn Washburn --- Changes from v1: * Add gdbinfo section --- Interdiff against v2: diff --git a/docs/grub-dev.texi b/docs

Re: [PATCH v2] docs: Add debugging chapter to development documentation

2023-06-05 Thread Glenn Washburn
w. I will change it to "it has" as you suggested anyway because it can prevent confusion. Glenn > > On Fri, Jun 02, 2023 at 15:15:52 -0500, Glenn Washburn wrote: > > Debugging GRUB can be tricky and require arcane knowledge. This will > > help those unfamiliar with

Re: [PATCH v2] docs: Add debugging chapter to development documentation

2023-06-04 Thread Oskari Pirhonen
This looks useful, thanks! Some minor things I found when (quickly) reading through it: On Fri, Jun 02, 2023 at 15:15:52 -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debuggin

[PATCH v2] docs: Add debugging chapter to development documentation

2023-06-02 Thread Glenn Washburn
Debugging GRUB can be tricky and require arcane knowledge. This will help those unfamiliar with the process to get started debugging GRUB with less effort. Signed-off-by: Glenn Washburn --- Range-diff against v1: 1: 24680ea61004 ! 1: e602b68f4ee8 docs: Add debugging chapter to development

[PATCH v2 2/3] dns: add debugging messages in recv_hook() function

2023-05-03 Thread Renaud Métrich
Signed-off-by: Renaud Métrich --- grub-core/net/dns.c | 5 + 1 file changed, 5 insertions(+) diff --git a/grub-core/net/dns.c b/grub-core/net/dns.c index f28d1099f..6993a4aba 100644 --- a/grub-core/net/dns.c +++ b/grub-core/net/dns.c @@ -355,6 +355,7 @@ recv_hook (grub_net_udp_socket_t sock

[PATCH] docs: Add debugging chapter to development documentation

2023-04-28 Thread Glenn Washburn
Debugging GRUB can be tricky and require arcane knowledge. This will help those unfamiliar with the process to get started debugging GRUB with less effort. Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 217 + 1 file changed, 217 insertions

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-21 Thread Glenn Washburn
On 3/16/23 21:05, Robbie Harwood wrote: Glenn Washburn writes: On 3/9/23 23:00, Robbie Harwood wrote: Glenn Washburn writes: If the configure option --enable-efi-debug is given, then enable the printing early in EFI startup of the command needed to load symbols for the GRUB EFI kernel. Thi

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-16 Thread Robbie Harwood
Glenn Washburn writes: > On 3/9/23 23:00, Robbie Harwood wrote: >> Glenn Washburn writes: >> >>> If the configure option --enable-efi-debug is given, then enable the >>> printing early in EFI startup of the command needed to load symbols for >>> the GRUB EFI kernel. This is needed because EFI f

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-16 Thread Daniel Kiper
On Wed, Mar 15, 2023 at 03:11:05AM +, Glenn Washburn wrote: > On 3/13/23 12:27, Daniel Kiper wrote: > > On Fri, Mar 10, 2023 at 03:27:13PM -0500, Peter Jones wrote: > > > On Thu, Mar 09, 2023 at 06:00:04PM -0500, Robbie Harwood wrote: > > > > Glenn Washburn writes: > > > > > 2. Why should th

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-14 Thread Glenn Washburn
On 3/13/23 12:27, Daniel Kiper wrote: On Fri, Mar 10, 2023 at 03:27:13PM -0500, Peter Jones wrote: On Thu, Mar 09, 2023 at 06:00:04PM -0500, Robbie Harwood wrote: Glenn Washburn writes: 2. Why should the load command not be printed when secure boot is enabled? * This was also requested

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-14 Thread Glenn Washburn
On 3/9/23 23:00, Robbie Harwood wrote: Glenn Washburn writes: If the configure option --enable-efi-debug is given, then enable the printing early in EFI startup of the command needed to load symbols for the GRUB EFI kernel. This is needed because EFI firmware determines where to load the GRUB

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-13 Thread Daniel Kiper
On Fri, Mar 10, 2023 at 03:27:13PM -0500, Peter Jones wrote: > On Thu, Mar 09, 2023 at 06:00:04PM -0500, Robbie Harwood wrote: > > Glenn Washburn writes: > > > 2. Why should the load command not be printed when secure boot is > > > enabled? > > >* This was also requested by Daniel, I assume

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-10 Thread Peter Jones
On Thu, Mar 09, 2023 at 06:00:04PM -0500, Robbie Harwood wrote: > Glenn Washburn writes: > > 2. Why should the load command not be printed when secure boot is enabled? > >* This was also requested by Daniel, I assume because of infomation > > leakage > > that may be a security concern.

Re: [RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-03-09 Thread Robbie Harwood
Glenn Washburn writes: > If the configure option --enable-efi-debug is given, then enable the > printing early in EFI startup of the command needed to load symbols for > the GRUB EFI kernel. This is needed because EFI firmware determines where > to load the GRUB EFI at runtime, and so the relevan

Re: [PATCH v6 09/14] gdb: Add more support for debugging on EFI platforms

2023-03-02 Thread Daniel Kiper
t. How does this > affect things for you? > > > > This is not printed when secure boot is enabled. > > > > This will mean that any debugging first requires disabling secureboot. > > That's potentially annoying and I'm not sure I see a security benefit > >

[RFC PATCH] gdb: Add more support for debugging on EFI platforms

2023-02-27 Thread Glenn Washburn
onfigure.ac index 93626b7982d4..4bf477b0729a 100644 --- a/configure.ac +++ b/configure.ac @@ -1521,6 +1521,17 @@ else fi AC_SUBST([MM_DEBUG]) +# EFI debugging. +AC_ARG_ENABLE([efi-debug], + AS_HELP_STRING([--enable-efi-debug], + [include aides for debuggin

Re: [PATCH v6 09/14] gdb: Add more support for debugging on EFI platforms

2023-02-20 Thread Glenn Washburn
odule configurable, it should always be enabled (which it isn't currently). Also, Daniel was concerned about this breaking silent boot. How does this affect things for you? > > This is not printed when secure boot is enabled. > > This will mean that any debugging first requires disab

Re: [PATCH v6 09/14] gdb: Add more support for debugging on EFI platforms

2023-02-20 Thread Robbie Harwood
will mean that any debugging first requires disabling secureboot. That's potentially annoying and I'm not sure I see a security benefit to doing so. Be well, --Robbie signature.asc Description: PGP signature ___ Grub-devel mailing l

[PATCH v6 09/14] gdb: Add more support for debugging on EFI platforms

2023-01-10 Thread Glenn Washburn
/ #define DISK_CACHE_STATS @DISK_CACHE_STATS@ #define BOOT_TIME_STATS @BOOT_TIME_STATS@ diff --git a/configure.ac b/configure.ac index 93626b7982..4bf477b072 100644 --- a/configure.ac +++ b/configure.ac @@ -1521,6 +1521,17 @@ else fi AC_SUBST([MM_DEBUG]) +# EFI debugging. +AC_ARG_ENABLE(

[PATCH v6 14/14] docs: Add debugging chapter to development documentation

2023-01-10 Thread Glenn Washburn
Debugging GRUB can be tricky and require arcane knowledge. This will help those unfamiliar with the process to get started debugging GRUB with less effort. Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 233 + 1 file changed, 233 insertions

[PATCH v5 09/14] gdb: Add more support for debugging on EFI platforms

2022-12-23 Thread Glenn Washburn
/ #define DISK_CACHE_STATS @DISK_CACHE_STATS@ #define BOOT_TIME_STATS @BOOT_TIME_STATS@ diff --git a/configure.ac b/configure.ac index 93626b7982..4bf477b072 100644 --- a/configure.ac +++ b/configure.ac @@ -1521,6 +1521,17 @@ else fi AC_SUBST([MM_DEBUG]) +# EFI debugging. +AC_ARG_ENABLE(

[PATCH v5 14/14] docs: Add debugging chapter to development documentation

2022-12-23 Thread Glenn Washburn
Debugging GRUB can be tricky and require arcane knowledge. This will help those unfamiliar with the process to get started debugging GRUB with less effort. Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 233 + 1 file changed, 233 insertions

Re: [PATCH v4 15/15] docs: Add debugging chapter to development documentation

2022-12-21 Thread Glenn Washburn
* Contributing Changes:: > > * Setting up and running test suite:: > > * Updating External Code:: > > +* Debugging:: > > * Porting:: > > * Error Handling:: > > * Stack and heap size:: > > @@ -595,6 +596,196 @@ cp minilzo-2.10/*.[hc] grub-core/lib/minilzo

Re: [PATCH v4 15/15] docs: Add debugging chapter to development documentation

2022-12-21 Thread Daniel Kiper
> index f76fc658bf..8171e91c33 100644 > --- a/docs/grub-dev.texi > +++ b/docs/grub-dev.texi > @@ -79,6 +79,7 @@ This edition documents version @value{VERSION}. > * Contributing Changes:: > * Setting up and running test suite:: > * Updating External Code:: > +* Debugging:: > * P

Re: [PATCH v4 15/15] docs: Add debugging chapter to development documentation

2022-12-20 Thread Jeremy Szu
x f76fc658bf..8171e91c33 100644 > --- a/docs/grub-dev.texi > +++ b/docs/grub-dev.texi > @@ -79,6 +79,7 @@ This edition documents version @value{VERSION}. > * Contributing Changes:: > * Setting up and running test suite:: > * Updating External Code:: > +* Debugging:: > * Por

[PATCH v4 15/15] docs: Add debugging chapter to development documentation

2022-12-15 Thread Glenn Washburn
@@ This edition documents version @value{VERSION}. * Contributing Changes:: * Setting up and running test suite:: * Updating External Code:: +* Debugging:: * Porting:: * Error Handling:: * Stack and heap size:: @@ -595,6 +596,196 @@ cp minilzo-2.10/*.[hc] grub-core/lib/minilzo rm -r minilzo

[PATCH v3 15/15] docs: Add debugging chapter to development documentation

2022-12-14 Thread Glenn Washburn
@@ This edition documents version @value{VERSION}. * Contributing Changes:: * Setting up and running test suite:: * Updating External Code:: +* Debugging:: * Porting:: * Error Handling:: * Stack and heap size:: @@ -595,6 +596,196 @@ cp minilzo-2.10/*.[hc] grub-core/lib/minilzo rm -r minilzo

[PATCH v2 15/15] docs: Add debugging chapter to development documentation

2022-05-13 Thread Glenn Washburn
@@ This edition documents version @value{VERSION}. * Contributing Changes:: * Setting up and running test suite:: * Updating External Code:: +* Debugging:: * Porting:: * Error Handling:: * Stack and heap size:: @@ -595,6 +596,196 @@ cp minilzo-2.10/*.[hc] grub-core/lib/minilzo rm -r minilzo-2.10

[PATCH 0/3] Fixes and enhancements for memory debugging

2022-02-15 Thread Glenn Washburn
The first patch supercedes a patch sent earlier of the same subject. I've removed the #undef if --mm-debug is not passwed to configure. The idea is that even if --mm-debug is not passed to configure, the user should still be able to enable memory debugging by passing -DMM_DEBUG in CFLAGS.

[PATCH 18/19] [not for merge] ieee1275 debugging info

2021-10-12 Thread Daniel Axtens
This is also handy for debugging. Signed-off-by: Daniel Axtens --- grub-core/kern/ieee1275/init.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c index 0fb7bae280df..f70cb134178b 100644 --- a/grub

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2020 at 01:22:34PM +0100, Patrick Steinhardt wrote: > On Mon, Mar 09, 2020 at 12:18:41PM +0100, Paul Menzel wrote: > > Dear Patrick, > > > > On 2020-03-07 17:29, Patrick Steinhardt wrote: > > > The memory management system supports a debug mode that can be enabled > > > at build tim

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Patrick Steinhardt
On Mon, Mar 09, 2020 at 12:18:41PM +0100, Paul Menzel wrote: > Dear Patrick, > > > On 2020-03-07 17:29, Patrick Steinhardt wrote: > > The memory management system supports a debug mode that can be enabled > > at build time by passing "--enable-mm-debug" to the configure script. > > Passing the op

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2020 at 01:01:51PM +0100, Patrick Steinhardt wrote: > On Mon, Mar 09, 2020 at 12:19:15PM +0100, Daniel Kiper wrote: > > On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > > > When building GRUB with memory management debugging enabled, then the

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Patrick Steinhardt
On Mon, Mar 09, 2020 at 12:19:15PM +0100, Daniel Kiper wrote: > On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > > When building GRUB with memory management debugging enabled, then the > > build fails because of `grub_debug_malloc()` and `grub_debug_free()` >

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Paul Menzel
k, similar to how other defines work. > > Signed-off-by: Patrick Steinhardt > --- > configure.ac | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index f19489418..9eeec2d76 100644 > --- a/configure.ac > ++

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > When building GRUB with memory management debugging enabled, then the > build fails because of `grub_debug_malloc()` and `grub_debug_free()` > being undefined in the luks2 module. The cause is that we patch > &

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 05:29:08PM +0100, Patrick Steinhardt wrote: > The memory management system supports a debug mode that can be enabled > at build time by passing "--enable-mm-debug" to the configure script. > Passing the option will cause us define MM_DEBUG as expected, but in > fact the reve

[PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-07 Thread Patrick Steinhardt
eletions(-) diff --git a/configure.ac b/configure.ac index f19489418..9eeec2d76 100644 --- a/configure.ac +++ b/configure.ac @@ -1448,9 +1448,11 @@ LIBS="$tmp_LIBS" # Memory manager debugging. AC_ARG_ENABLE([mm-debug], AS_HELP_STRING([--enable-mm-debug], -

[PATCH 0/2] build: Fixes for memory-debugging builds

2020-03-07 Thread Patrick Steinhardt
isabling memory debugging enables memory debugging while it would've been disabled if just passing no option at all. These patches fix both issues so that GRUB now builds correctly with and without memory debugging on my system. Patrick Patrick Steinhardt (2): build: Fix option t

[PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-07 Thread Patrick Steinhardt
When building GRUB with memory management debugging enabled, then the build fails because of `grub_debug_malloc()` and `grub_debug_free()` being undefined in the luks2 module. The cause is that we patch "base64.h" to unconditionaly include "config-util.h", which shouldn'

Re: How to enable MM debugging?

2016-11-29 Thread Andrei Borzenkov
29.11.2016 17:38, Stanislav Kholmanskikh пишет: > > > On 11/29/2016 05:17 PM, Andrei Borzenkov wrote: >> On Tue, Nov 29, 2016 at 4:52 PM, Stanislav Kholmanskikh >> wrote: >>> Hi! >>> >>> Does anybody use MM debugging? If so, what is the recommend

Re: How to enable MM debugging?

2016-11-29 Thread Stanislav Kholmanskikh
On 11/29/2016 05:17 PM, Andrei Borzenkov wrote: > On Tue, Nov 29, 2016 at 4:52 PM, Stanislav Kholmanskikh > wrote: >> Hi! >> >> Does anybody use MM debugging? If so, what is the recommended/working >> way of enabling it? >> >> These steps do not work:

Re: How to enable MM debugging?

2016-11-29 Thread Andrei Borzenkov
On Tue, Nov 29, 2016 at 4:52 PM, Stanislav Kholmanskikh wrote: > Hi! > > Does anybody use MM debugging? If so, what is the recommended/working > way of enabling it? > > These steps do not work: > > 1. Run ./configure with '--enable-mm-debug'. It reports: > >

How to enable MM debugging?

2016-11-29 Thread Stanislav Kholmanskikh
Hi! Does anybody use MM debugging? If so, what is the recommended/working way of enabling it? These steps do not work: 1. Run ./configure with '--enable-mm-debug'. It reports: With memory debugging: Yes 2. Then build and install the binaries, and install the boot loader 3

Debugging modules built into a GRUB image w/ gdb

2016-05-18 Thread Charles Duffy
Howdy -- I'm trying to track down an issue encountered wherein a grub.cfg on a memdisk is only successfully loaded with check_signatures=no, despite grub_pubkey_open containing code which appears to explicitly exempt the case where io->device->disk->id == GRUB_DISK_DEVICE_MEMDISK_ID from enforceme

Question: USB serial - device driver debugging

2010-09-14 Thread Aleš Nesrsta
Hi, it seems there are some problems in USB serial driver PL2303 and I want to debug it. I need to send and receive some data to see what happened, i.e. I need to enable remote debug via classic serial interface by e.g. "serial;terminal_output console serial;debug=xxx" and then do something like

Re: grub2 debugging with gdb

2009-06-22 Thread jeff jeff
thank you. but what i need also is the gdb stub to debug over serial. do you know where i could find the right one to apply onlatest svn? thx -jf On Fri, Jun 19, 2009 at 10:41 AM, wangji wrote: > I have put the L Kundrak 's patches for grub2-gdb adjusted to svn > revision -due to genmk.rb chang

Re:grub2 debugging with gdb

2009-06-19 Thread wangji
I have put the L Kundrak 's patches for grub2-gdb adjusted to svn revision -due to genmk.rb changes. It works well with qemu -s , for stepping into modules ...hello ! http://wjhowto.googlepages.com/grub2-r2300-2340-elfgdb.patch older svn are there too http://wjhowto.googlepages.com/grub2-r1742-2

grub2 debugging with gdb

2009-06-19 Thread jeff jeff
hi i need to add a few commands/modules to grub2 for our systems. i am trying to debug grub2 with gdb to ease the development cycle. for that purpose i have followed this excellent doc http://v3.sk/~lkundrak/grub2-gdb/howto.html after i applied the procedure described in the note, for some reason

Re: qemu + gdb debugging...

2009-02-22 Thread Vesa Jääskeläinen
breakpoint if it haunts you del 1 ; where 1 is being breakpoint number use 'info break' to see numbers if you lost that. 11. Setup automatic symbol loading break_load 12. Happy debugging! If you want to debug boot code that can be done also... but its a bit more tricky... and I leave that

qemu + gdb debugging...

2009-02-22 Thread Vesa Jääskeläinen
Hi All, I was debugging some problem lately and felt that I need to use debugger. As I like how JTAG debugging works I wanted to have similar feeling :). Obivious choice is to use QEMU. QEMU provides a GDB stub that can be used to debug code running on its virtual session. I also found out that

follow-up: debugging efi on apple xserve

2008-12-17 Thread Peter Brunnengräber
Hello all, In follow-up to my last post. I have been talking with daChaac in the IRC channel. (Thanks daChaac again for all you help!!) With debug on, the system hangs initing the module. I originally had this with the "apple" module, but I rebuilt the efi image without the "apple" module and

Question on debugging EFI

2008-12-17 Thread Peter Brunnengräber
Hello all, I am attempting to boot an xserve with the EFI build of grub2. I can get success on my macbook with the build, but the xserve hangs at "Welcome to Grub!" I would like to help debug this to get it going. Anyone? Thanks! -Cheers, Peter _

Re: [PATCH] GDB Macros to ease debugging modules

2008-05-07 Thread Lubomir Rintel
On Tue, 2008-05-06 at 17:10 +0200, Robert Millan wrote: > On Tue, May 06, 2008 at 01:10:17PM +0200, Lubomir Rintel wrote: > > +# GRUB -- GRand Unified Bootloader > > +# Copyright (C) 2003,2004,2005,2006,2007,2008 Free Software Foundation, > > Inc. > > Where does this code originate? I don't r

Re: [PATCH] Remote GDB debugging stub (for i386)

2008-05-07 Thread Lubomir Rintel
On Tue, 2008-05-06 at 17:02 +0200, Robert Millan wrote: > On Thu, May 01, 2008 at 03:12:25PM +0200, Lubomir Rintel wrote: > > --- grub2/gdb/cstub.c 1970-01-01 01:00:00.0 +0100 > > +++ grub2-gdb/gdb/cstub.c 2008-05-01 10:57:57.0 +0200 > > @@ -0,0 +1,362 @@ > > +/* cstub.c - m

Re: [PATCH] Remote GDB debugging stub (for i386)

2008-05-06 Thread Vesa Jääskeläinen
Robert Millan wrote: /* The size of the first region which won't be compressed. */ -#define GRUB_KERNEL_MACHINE_RAW_SIZE 0x4A0 +#define GRUB_KERNEL_MACHINE_RAW_SIZE 0x4BC What caused this? Any way we can have this dynamically calculated? More code before compression

Re: [PATCH] GDB Macros to ease debugging modules

2008-05-06 Thread Robert Millan
On Tue, May 06, 2008 at 01:10:17PM +0200, Lubomir Rintel wrote: > +# GRUB -- GRand Unified Bootloader > +# Copyright (C) 2003,2004,2005,2006,2007,2008 Free Software Foundation, Inc. Where does this code originate? I don't recall seeing any perl in GRUB before. GDB maybe? -- Robert Millan

Re: [PATCH] Remote GDB debugging stub (for i386)

2008-05-06 Thread Robert Millan
On Thu, May 01, 2008 at 03:12:25PM +0200, Lubomir Rintel wrote: > --- grub2/gdb/cstub.c 1970-01-01 01:00:00.0 +0100 > +++ grub2-gdb/gdb/cstub.c 2008-05-01 10:57:57.0 +0200 > @@ -0,0 +1,362 @@ > +/* cstub.c - machine independent portion of remote GDB stub */ > +/* > + * Copyrigh

[PATCH] GDB Macros to ease debugging modules

2008-05-06 Thread Lubomir Rintel
09:18:25.380014078 +0200 +++ grub.gdb 2008-05-06 12:51:33.0 +0200 @@ -0,0 +1,109 @@ +# grub.gdb - Macros to ease debugging of GRUB and its modules with GDB + +# GRUB -- GRand Unified Bootloader +# Copyright (C) 2003,2004,2005,2006,2007,2008 Free Software Foundation, Inc. +# +# GRUB is free

[PATCH] Remote GDB debugging stub (for i386)

2008-05-01 Thread Lubomir Rintel
Re-sending the GDB stub patch. The GDB protocol part, though being largely rewritten, originates from GDB source tarball, which refers to it as a Public Domain code. Applies against today's CVS. Is not much of use without debugging symbols, part 2 of patch [1] preserves those. Neither is

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
Bean confirmed it works. Committed without changing jmp to call, since it wasn't clear whether we want it or not. On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > > Quoting Robert Millan <[EMAIL PROTECTED]>: > > > >

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 11:38:48PM +0800, Bean wrote: > > > > "exit" in open firmware based systems would probably mean returning > > control to open firmware. > > > > By the way, it would be nice to have "exit" in both grub for PC and > > grub-emu, and not only in the rescue mode. "exit" on P

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Bean
On Fri, Apr 18, 2008 at 11:16 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > > > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > > - jmp EXT_C(cmain) > > > + jmp EXT_C(grub_main) > > > > Or maybe that should be a

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 11:16:43AM -0400, Pavel Roskin wrote: > > On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > > - jmp EXT_C(cmain) > > > + jmp EXT_C(grub_main) > > > > Or maybe that should be a "call" instead.. >

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Pavel Roskin
On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > - jmp EXT_C(cmain) > > + jmp EXT_C(grub_main) > > Or maybe that should be a "call" instead.. Only if there is any chance of return, and we can handle it. "exit" in op

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Lubomir Kundrak
On Fri, 2008-04-18 at 13:32 +0200, Robert Millan wrote: > On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > > Quoting Robert Millan <[EMAIL PROTECTED]>: > > > > >Now that I think of it, is there any reason for doing all the cmain() > > >cruft before grub_main() ? Getting to grub_ma

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > - jmp EXT_C(cmain) > + jmp EXT_C(grub_main) Or maybe that should be a "call" instead.. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-18 Thread Robert Millan
On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > Quoting Robert Millan <[EMAIL PROTECTED]>: > > >Now that I think of it, is there any reason for doing all the cmain() > >cruft before grub_main() ? Getting to grub_main() only requires a working > >stack, which we have, and grub_main

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Pavel Roskin
Quoting Robert Millan <[EMAIL PROTECTED]>: Now that I think of it, is there any reason for doing all the cmain() cruft before grub_main() ? Getting to grub_main() only requires a working stack, which we have, and grub_main() inmediately returns control back to architecture-specific code in grub

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Robert Millan
On Thu, Apr 17, 2008 at 01:53:21PM +0200, Lubomir Kundrak wrote: > > On Tue, 2008-04-15 at 15:38 +0200, Robert Millan wrote: > > On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > > > diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c > > > --- grub-1.95.orig/kern/main.c

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Lubomir Kundrak
On Tue, 2008-04-15 at 15:01 -0400, Pavel Roskin wrote: > On Tue, 2008-04-15 at 00:30 +0200, Lubomir Kundrak wrote: > > These are pretty self-explainable. I think I tried to sumbit these > > changes with the serial debugging patch year and some months ago and I > > was told

Re: [PATCH] Make gdb debugging a bit less painful

2008-04-17 Thread Lubomir Kundrak
On Tue, 2008-04-15 at 15:38 +0200, Robert Millan wrote: > On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote: > > diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c > > --- grub-1.95.orig/kern/main.c 2007-01-29 15:31:36.0 +0100 > > +++ grub-1.95/kern/main.c 2007

  1   2   >