Robert Millan wrote:
This affects gnulib/error.c and gnulib/gettext.h which would be much better
not to change, as they're being imported semi-automatically.
I understand.
But could this be actually a bug in gnulib? The problem only occurs
when gettext is not found and when compiling with -
On Wed, Jan 13, 2010 at 02:02:22AM +0100, Grégoire Sutre wrote:
> richardvo...@gmail.com wrote:
>
>>> Another option would be to replace #if ENABLE_NLS by #if defined(ENABLE_NLS)
>>> && ENABLE_NLS.
>>
>> I know the C compiler short-circuits &&, if the preprocessor does also
>> then this looks like
richardvo...@gmail.com wrote:
Another option would be to replace #if ENABLE_NLS by #if defined(ENABLE_NLS)
&& ENABLE_NLS.
I know the C compiler short-circuits &&, if the preprocessor does also
then this looks like the best solution. If not, then nested #if.
Yes the preprocessor also short-c
2010/1/12 Grégoire Sutre :
> richardvo...@gmail.com wrote:
>
>> This fix breaks when ENABLE_NLS is defined as 0.
>
> AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either not
> defined or set to 1.
>
> But I agree that my proposed fix is too dependent on the implementation of
> AM_G
richardvo...@gmail.com wrote:
This fix breaks when ENABLE_NLS is defined as 0.
AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either
not defined or set to 1.
But I agree that my proposed fix is too dependent on the implementation
of AM_GNU_GETTEXT, which may change.
Anoth
2010/1/12 Grégoire Sutre :
> Hi,
>
> When NLS is disabled or not supported, the macro ENABLE_NLS is not defined,
> and this breaks compilation of GRUB modules as they are compiled with
> -Werror -Wundef by default. This is with bazaar trunk.
>
> $ ./autogen.sh && ./configure && gmake
> [...]
> gcc
Hi,
When NLS is disabled or not supported, the macro ENABLE_NLS is not
defined, and this breaks compilation of GRUB modules as they are
compiled with -Werror -Wundef by default. This is with bazaar trunk.
$ ./autogen.sh && ./configure && gmake
[...]
gcc -Ikern -I./kern -nostdinc -isystem /us
