Re: Bug-fix elf.c powerpc ieee1275

2008-11-03 Thread Bean
On Sun, Nov 2, 2008 at 7:06 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sun, Nov 02, 2008 at 09:22:18PM +1100, peter cros wrote: >> Thanks for the explanation, but the bug has been a show stopper for >> powerpc GNU-linux users trying to evaluate grub-ieee1275 since 1509, >> and is still there

Re: Bug-fix elf.c powerpc ieee1275

2008-11-02 Thread Robert Millan
On Sun, Nov 02, 2008 at 09:22:18PM +1100, peter cros wrote: > Thanks for the explanation, but the bug has been a show stopper for > powerpc GNU-linux users trying to evaluate grub-ieee1275 since 1509, > and is still there in rev 1891. > > Please can someone apply the reversion now? Bean, will you

Re: Bug-fix elf.c powerpc ieee1275

2008-11-02 Thread peter cros
Thanks for the explanation, but the bug has been a show stopper for powerpc GNU-linux users trying to evaluate grub-ieee1275 since 1509, and is still there in rev 1891. Please can someone apply the reversion now? On Tue, Sep 30, 2008 at 7:14 PM, Bean <[EMAIL PROTECTED]> wrote: > On Tue, Sep 30, 2

Re: Bug-fix elf.c powerpc ieee1275

2008-09-30 Thread Bean
On Tue, Sep 30, 2008 at 3:26 PM, peter cros <[EMAIL PROTECTED]> wrote: > The change was between svn version 1421 and 1509 which had bugfixes, > in grub_elf32_load, and grub_elf64_load. Hi, The patch is for bsd loader, but it seems it uses the wrong method to change load address. This is the righ

Re: Bug-fix elf.c powerpc ieee1275

2008-09-30 Thread peter cros
The change was between svn version 1421 and 1509 which had bugfixes, in grub_elf32_load, and grub_elf64_load. [EMAIL PROTECTED]:~/src/grub$ diff -pu grub1421/kern/elf.c grub1509/kern/elf.c --- grub1421/kern/elf.c2008-09-30 14:49:46.0 +1000 +++ grub1509/kern/elf.c2008-09-30 14:41:

Re: Bug-fix elf.c powerpc ieee1275

2008-09-29 Thread peter cros
Explanation. It seems to be a case of spurious line that got back into grub_elf32_load and grub_elf64_load, nested function. if (load_hook && load_hook (phdr, &load_addr)) return 1; load_addr = phdr->p_paddr; That sequence did not make sense to me, it overwrites the correct value

Re: Bug-fix elf.c powerpc ieee1275

2008-09-28 Thread Robert Millan
On Mon, Sep 29, 2008 at 12:42:36AM +1000, peter cros wrote: > Hi, > > There is a bug in /kern/elf.c/ (target powerpc, platform ieee1275), > causing load linux to fail on my powerpc64 g5 and ibook g4 32bit. > > Here is a diff of the fix I found necessary for rev 1878 (bug has existed in > previous

Bug-fix elf.c powerpc ieee1275

2008-09-28 Thread peter cros
Hi, There is a bug in /kern/elf.c/ (target powerpc, platform ieee1275), causing load linux to fail on my powerpc64 g5 and ibook g4 32bit. Here is a diff of the fix I found necessary for rev 1878 (bug has existed in previous versions). It was a one liner - diff -pu grubsvn/kern grubtry/kern/elf.