Re: About the code style requirement

On 2021/10/8 08:22, Qu Wenruo via Grub-devel wrote: On 2021/10/7 21:51, Daniel Kiper wrote: On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] GRUB already has a btrfs implementation. Writing new one f

Re: About the code style requirement

On 2021/10/7 21:51, Daniel Kiper wrote: On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] GRUB already has a btrfs implementation. Writing new one from scratch instead of existing one is unwelcome. From

Re: About the code style requirement

On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: > On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] > > GRUB already has a btrfs implementation. Writing new one from scratch > > instead of existing one is unwelcome. From scratch means new bugs. > > Do you ha

Re: About the code style requirement

On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: On Fri, Oct 1, 2021 at 2:13 AM Qu Wenruo wrote: On 2021/9/30 18:51, Qu Wenruo wrote: On 2021/9/30 18:20, Vladimir 'phcoder' Serbinenko wrote: Le jeu. 30 sept. 2021, 00:24, Qu Wenruo mailto:w...@suse.com>> a écrit : On 2

Re: About the code style requirement

On Fri, Oct 1, 2021 at 2:13 AM Qu Wenruo wrote: > > > > On 2021/9/30 18:51, Qu Wenruo wrote: > > > > > > On 2021/9/30 18:20, Vladimir 'phcoder' Serbinenko wrote: > >> > >> > >> Le jeu. 30 sept. 2021, 00:24, Qu Wenruo >> > a écrit : > >> > >> > >> > >> On 2021/9/29 23:38,

Re: About the code style requirement

On Wed, Sep 29, 2021 at 01:41:09PM +0800, Qu Wenruo wrote: > Hi, > > I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to > GRUB, so that we can have more unified code base, with more features (and > of-course bug fixes) The GPLv2 only kernel code is not going be much use for t

Re: About the code style requirement

On 2021/9/29 23:38, Lennart Sorensen wrote: On Wed, Sep 29, 2021 at 03:04:59PM +0800, Qu Wenruo via Grub-devel wrote: Oh, didn't know there would be license problem. There often is. :) Then it would be complex. Quite some code is directly copied from kernel without modification, those sho

Re: About the code style requirement

On Wed, Sep 29, 2021 at 03:04:59PM +0800, Qu Wenruo via Grub-devel wrote: > Oh, didn't know there would be license problem. There often is. :) > Then it would be complex. > > Quite some code is directly copied from kernel without modification, those > should still be GPL-2.0 only. > > For code

Re: About the code style requirement

On 2021/9/29 14:34, Vladimir 'phcoder' Serbinenko wrote: Le mer. 29 sept. 2021, 07:42, Qu Wenruo via Grub-devel mailto:grub-devel@gnu.org>> a écrit : Hi, I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to GRUB, so that we can have more unified code base, w

Re: About the code style requirement

Le mer. 29 sept. 2021, 07:42, Qu Wenruo via Grub-devel a écrit : > Hi, > > I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to > GRUB, so that we can have more unified code base, with more features > (and of-course bug fixes) > Did you check the license compatibility first? GR

Re: About the code style requirement

Qu Wenruo via Grub-devel writes: > Hi, > > I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to > GRUB, so that we can have more unified code base, with more features > (and of-course bug fixes) > > But the first blockage I'm hitting is the code style. > > It looks like GRUB

About the code style requirement

Hi, I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to GRUB, so that we can have more unified code base, with more features (and of-course bug fixes) But the first blockage I'm hitting is the code style. It looks like GRUB is using its own code style which is not found i