Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-12-14 Thread Daniel Kiper
On Tue, Dec 06, 2022 at 01:24:30AM -0800, Atish Patra wrote: > On Wed, Nov 23, 2022 at 1:11 AM Xiaotian Wu wrote: > > > > Is there a new patch? > > Not sure if you are asking about this series or Ard's series [1]. > I got busy with other day jobs and did not get time to revise this > series as tha

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-12-06 Thread Atish Patra
On Wed, Nov 23, 2022 at 1:11 AM Xiaotian Wu wrote: > > Is there a new patch? > Not sure if you are asking about this series or Ard's series [1]. I got busy with other day jobs and did not get time to revise this series as that requires a bit of work to make sure that it doesn't break ARM64 (by re

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-23 Thread Xiaotian Wu
Is there a new patch? 在 2022-11-08星期二的 23:59 -0800,Atish Kumar Patra写道: > > > On Tue, Nov 8, 2022 at 7:56 AM Daniel Kiper > wrote: > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > > Update the RISC-V Linux kernel image headers as per the current > > > header. > > > > > > Re

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Ard Biesheuvel
On Wed, 9 Nov 2022 at 13:50, Ard Biesheuvel wrote: > > On Wed, 9 Nov 2022 at 13:38, Leif Lindholm wrote: > > > > On Wed, Nov 09, 2022 at 13:10:29 +0100, Ard Biesheuvel wrote: > > > > > > The drawback to that is that not all EFI executables are destined > > > > > > for > > > > > > the Linux loade

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Heinrich Schuchardt
On 11/9/22 13:50, Ard Biesheuvel wrote: On Wed, 9 Nov 2022 at 13:38, Leif Lindholm wrote: On Wed, Nov 09, 2022 at 13:10:29 +0100, Ard Biesheuvel wrote: The drawback to that is that not all EFI executables are destined for the Linux loader. So while trying to boot them using the linux loader i

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Ard Biesheuvel
On Wed, 9 Nov 2022 at 13:38, Leif Lindholm wrote: > > On Wed, Nov 09, 2022 at 13:10:29 +0100, Ard Biesheuvel wrote: > > > > > The drawback to that is that not all EFI executables are destined for > > > > > the Linux loader. So while trying to boot them using the linux loader > > > > > is definitel

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Leif Lindholm
On Wed, Nov 09, 2022 at 13:10:29 +0100, Ard Biesheuvel wrote: > > > > The drawback to that is that not all EFI executables are destined for > > > > the Linux loader. So while trying to boot them using the linux loader > > > > is definitely user error, that change removed a potentially useful > > >

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Ard Biesheuvel
On Wed, 9 Nov 2022 at 13:01, Leif Lindholm wrote: > > On Wed, Nov 09, 2022 at 12:33:58 +0100, Ard Biesheuvel wrote: > > > > Can we get rid of these header definitions entirely? > > > > > > > > The only GRUB code that seems to care about the fields that are not > > > > defined in the PE/COFF spec i

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Leif Lindholm
On Wed, Nov 09, 2022 at 12:33:58 +0100, Ard Biesheuvel wrote: > > > Can we get rid of these header definitions entirely? > > > > > > The only GRUB code that seems to care about the fields that are not > > > defined in the PE/COFF spec is grub_cmd_file(), which currently parses > > > the magic field

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Ard Biesheuvel
On Wed, 9 Nov 2022 at 12:21, Leif Lindholm wrote: > > On Tue, Nov 08, 2022 at 17:36:51 +0100, Ard Biesheuvel wrote: > > > I can agree that hdr_offset makes more sense but > > > Documentation/riscv/boot-image-header.rst names this member as res3. > > > So, I would rename hdr_offset to res3 too. Or

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Leif Lindholm
On Tue, Nov 08, 2022 at 17:36:51 +0100, Ard Biesheuvel wrote: > > I can agree that hdr_offset makes more sense but > > Documentation/riscv/boot-image-header.rst names this member as res3. > > So, I would rename hdr_offset to res3 too. Or fix > > Documentation/riscv/boot-image-header.rst in the kern

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Atish Kumar Patra
On Wed, Nov 9, 2022 at 12:14 AM Ard Biesheuvel wrote: > On Wed, 9 Nov 2022 at 09:13, Atish Kumar Patra > wrote: > > > > > > > > On Tue, Nov 8, 2022 at 8:37 AM Ard Biesheuvel wrote: > >> > >> On Tue, 8 Nov 2022 at 16:59, Daniel Kiper wrote: > >> > > >> > On Fri, Nov 04, 2022 at 04:26:06PM -0700

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Ard Biesheuvel
On Wed, 9 Nov 2022 at 09:13, Atish Kumar Patra wrote: > > > > On Tue, Nov 8, 2022 at 8:37 AM Ard Biesheuvel wrote: >> >> On Tue, 8 Nov 2022 at 16:59, Daniel Kiper wrote: >> > >> > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: >> > > Update the RISC-V Linux kernel image headers as

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Atish Kumar Patra
On Tue, Nov 8, 2022 at 8:37 AM Ard Biesheuvel wrote: > On Tue, 8 Nov 2022 at 16:59, Daniel Kiper wrote: > > > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > > Update the RISC-V Linux kernel image headers as per the current header. > > > > > > Reference: > > > /Documentation/r

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-09 Thread Atish Kumar Patra
On Tue, Nov 8, 2022 at 7:56 AM Daniel Kiper wrote: > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > Update the RISC-V Linux kernel image headers as per the current header. > > > > Reference: > > /Documentation/riscv/boot-image-header.rst > > > > 474efecb65dc: ("riscv: modify the

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-08 Thread Ard Biesheuvel
On Tue, 8 Nov 2022 at 16:59, Daniel Kiper wrote: > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > Update the RISC-V Linux kernel image headers as per the current header. > > > > Reference: > > /Documentation/riscv/boot-image-header.rst > > > > 474efecb65dc: ("riscv: modify the

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > Update the RISC-V Linux kernel image headers as per the current header. > > Reference: > /Documentation/riscv/boot-image-header.rst > > 474efecb65dc: ("riscv: modify the Image header to improve compatibility with > the ARM64 header")

[v6 PATCH 2/3] RISC-V: Update image header

2022-11-04 Thread Atish Patra
Update the RISC-V Linux kernel image headers as per the current header. Reference: /Documentation/riscv/boot-image-header.rst 474efecb65dc: ("riscv: modify the Image header to improve compatibility with the ARM64 header") Acked-by: Heinrich Schuchardt Signed-off-by: Atish Patra --- include/g