Re: [patch] grub incorrectly identifies ext3 as fat

2009-11-11 Thread Andrew Clausen
Hi Robert, Sorry, I didn't follow up on your suggestion before (my mail program didn't highlight it properly). I had some bad luck: I can no longer reproduce the problem with any version of grub. This is a surprise to me, since my file system is 2 years old. Anyway, I just want to restate some

Re: [patch] grub incorrectly identifies ext3 as fat

2009-11-11 Thread Andrew Clausen
Hi Vladmir, Thanks for your reply. Sorry I didn't get back to you -- I had some mail problems. 2009/10/31 Vladimir 'phcoder' Serbinenko : > hfs+ and ext2 use same sector as superblock so it's not a problem Ok, what about NTFS and ext2 then? > Or you can modify the tools to clear first and last

Re: [patch] grub incorrectly identifies ext3 as fat

2009-11-09 Thread Robert Millan
On Sat, Oct 31, 2009 at 08:15:56PM +0100, Robert Millan wrote: > On Sat, Oct 31, 2009 at 02:43:19PM -0400, Andrew Clausen wrote: > > > Or we can attempt to read a given file when we expect it's there.  For > > > example, if we're looking for /boot/grub/, we can tell "/boot/grub" to the > > > filesy

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Robert Millan
On Sat, Oct 31, 2009 at 02:43:19PM -0400, Andrew Clausen wrote: > > Or we can attempt to read a given file when we expect it's there.  For > > example, if we're looking for /boot/grub/, we can tell "/boot/grub" to the > > filesystem layer, so that it will require it as a precondition. > > I can se

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Vladimir 'phcoder' Serbinenko
Andrew Clausen wrote: > Hi Robert, > > 2009/10/31 Robert Millan : > >>> What if you have a dual boot setup, with say ntfs and ext3? >>> >> The filesystem module that is embedded in core.img is only for bootstrap >> purposes. Once GRUB can access /boot/grub/, it automatically loads the >>

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Felix Zielcke
Am Samstag, den 31.10.2009, 18:02 + schrieb rubisher: > and at the grub sh prompt, ls doesn't report any disk? > > Even thought: # more /boot/grub/device.map > (hd0) /dev/sda > (hd1) /dev/sdb device.map is only used for the utilities. real GRUB never uses it. > Could it be for the reason

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Andrew Clausen
Hi Robert, 2009/10/31 Robert Millan : >> What if you have a dual boot setup, with say ntfs and ext3? > > The filesystem module that is embedded in core.img is only for bootstrap > purposes.  Once GRUB can access /boot/grub/, it automatically loads the > modules required for menu entries. OK, here

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Robert Millan
On Sat, Oct 31, 2009 at 12:38:41PM +0100, Felix Zielcke wrote: > Am Samstag, den 31.10.2009, 12:30 +0100 schrieb Robert Millan: > > On Sat, Oct 31, 2009 at 11:34:22AM +0100, Felix Zielcke wrote: > > > Am Samstag, den 31.10.2009, 11:10 +0100 schrieb Robert Millan: > > > > > > > > Felix, did you hav

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread rubisher
Hello Felix, Felix Zielcke wrote: Am Samstag, den 31.10.2009, 02:44 -0400 schrieb Andrew Clausen: Hi, 2009/10/30 Robert Millan : What about probing in the boot-loader? It's too late then. grub-install needs to know which filesystem module has to be included in core.img. What if the core.im

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Robert Millan
On Sat, Oct 31, 2009 at 11:39:16AM -0400, Andrew Clausen wrote: > Hi Felix, > > 2009/10/31 Felix Zielcke : > > That only happens if you use grub-install with --modules or you directly > > create it with grub-mkimage. > > By default there's just one module and there only needs to be one. > > The on

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Andrew Clausen
Hi Felix, 2009/10/31 Felix Zielcke : > That only happens if you use grub-install with --modules or you directly > create it with grub-mkimage. > By default there's just one module and there only needs to be one. > The one to access /boot/grub. > It doestn't make sense to include more then one fs m

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Felix Zielcke
Am Samstag, den 31.10.2009, 12:30 +0100 schrieb Robert Millan: > On Sat, Oct 31, 2009 at 11:34:22AM +0100, Felix Zielcke wrote: > > Am Samstag, den 31.10.2009, 11:10 +0100 schrieb Robert Millan: > > > > > > Felix, did you have some code to do make_path_relative_to_its_root() > > > in C? > > > Then

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Robert Millan
On Sat, Oct 31, 2009 at 11:34:22AM +0100, Felix Zielcke wrote: > Am Samstag, den 31.10.2009, 11:10 +0100 schrieb Robert Millan: > > > > Felix, did you have some code to do make_path_relative_to_its_root() > > in C? > > Then we can re-enable the check in grub-probe, fixing this problem. > > Yes,

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Felix Zielcke
Am Samstag, den 31.10.2009, 11:10 +0100 schrieb Robert Millan: > > Felix, did you have some code to do make_path_relative_to_its_root() > in C? > Then we can re-enable the check in grub-probe, fixing this problem. Yes, the only missing thing is that you wanted to have the function imported from

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Robert Millan
On Sat, Oct 31, 2009 at 02:44:08AM -0400, Andrew Clausen wrote: > Hi, > > 2009/10/30 Robert Millan : > >> What about probing in the boot-loader? > > > > It's too late then.  grub-install needs to know which filesystem module has > > to be included in core.img. > > What if the core.img contains mo

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-31 Thread Felix Zielcke
Am Samstag, den 31.10.2009, 02:44 -0400 schrieb Andrew Clausen: > Hi, > > 2009/10/30 Robert Millan : > >> What about probing in the boot-loader? > > > > It's too late then. grub-install needs to know which filesystem module has > > to be included in core.img. > > What if the core.img contains mo

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-30 Thread Andrew Clausen
Hi, 2009/10/30 Robert Millan : >> What about probing in the boot-loader? > > It's too late then.  grub-install needs to know which filesystem module has > to be included in core.img. What if the core.img contains modules for 2 or more file systems? Cheers, Andrew __

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-30 Thread Robert Millan
On Fri, Oct 30, 2009 at 03:19:31PM -0400, Andrew Clausen wrote: > >> This shouldn't have any collateral damage, because empty file systems > >> are useless to Grub. > > > > Unlike the filesystem driver, grub-probe already knows we want to probe for > > a file.  Then this assumption won't be necessa

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-30 Thread Andrew Clausen
Hi Robert, 2009/10/30 Robert Millan : >> I wrote a patch.  In order for a file system to be considered >> detected, dir() must not only succeed, it also must find at least one >> file or directory. This is pretty effective at ruling out misdetecting >> a filesystem based on a stale signature that

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-30 Thread Felix Zielcke
Am Freitag, den 30.10.2009, 19:57 +0100 schrieb Robert Millan: > On Thu, Oct 29, 2009 at 02:58:09PM +, Andrew Clausen wrote: > > Hi all, > > > > grub (both the boot loader, and grub-probe) incorrectly identifies my > > ext3 partition as containing a fat file system. This means it can't > > boo

Re: [patch] grub incorrectly identifies ext3 as fat

2009-10-30 Thread Robert Millan
On Thu, Oct 29, 2009 at 02:58:09PM +, Andrew Clausen wrote: > Hi all, > > grub (both the boot loader, and grub-probe) incorrectly identifies my > ext3 partition as containing a fat file system. This means it can't > boot without manual tweaking. The problem is caused by stale fat > signatures

[patch] grub incorrectly identifies ext3 as fat

2009-10-29 Thread Andrew Clausen
Hi all, grub (both the boot loader, and grub-probe) incorrectly identifies my ext3 partition as containing a fat file system. This means it can't boot without manual tweaking. The problem is caused by stale fat signatures... this is probably a common problem, as mke2fs often doesn't wipe old sign