Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Robbie Harwood
Zhang Boyang writes: > On 2022/12/21 06:58, Robbie Harwood wrote: >> Zhang Boyang writes: >> >>> This patch add version information to GRUB modules. Specifically, >>> PACKAGE_VERSION is embedded as null-terminated string in .modver >>> section. This string is checked at module loading time. Tha

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Glenn Washburn
On Wed, 21 Dec 2022 16:07:27 +0800 Zhang Boyang wrote: > Hi, > > On 2022/12/21 03:04, Glenn Washburn wrote: > > On Mon, 19 Dec 2022 23:33:29 +0800 > > Zhang Boyang wrote: > > > >> This patch add version information to GRUB modules. Specifically, > >> PACKAGE_VERSION is embedded as null-termina

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Pete Batard via Grub-devel
Hi Zhang, On 2022.12.21 11:38, Zhang Boyang wrote: Hi, On 2022/12/21 17:43, Thomas Schmitt wrote: Hi, Pete Batard wrote: unlike what is the case for UEFI, one can not expect to be able to pick all the GRUB core files needed to convert a GRUB based ISO bootable media to a GRUB based USB boota

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Zhang Boyang
Hi, On 2022/12/21 17:43, Thomas Schmitt wrote: Hi, Pete Batard wrote: unlike what is the case for UEFI, one can not expect to be able to pick all the GRUB core files needed to convert a GRUB based ISO bootable media to a GRUB based USB bootable media [...] Typically, one of the missing files w

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Didier Spaier
Le 21/12/2022 à 09:43, Thomas Schmitt a écrit : > I think that in any case an ISO made by grub-mkrescue should be tested. > Maybe a distro developer is here who uses it for making a full fledged > installation ISO or a live ISO. I do for making a full fledged installation ISO in this function, wit

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Thomas Schmitt
Hi, Pete Batard wrote: > > unlike what is the case for UEFI, one can not expect > > to be able to pick all the GRUB core files needed to convert a GRUB > > based ISO bootable media to a GRUB based USB bootable media [...] > > Typically, one of the > > missing files will be a 'core.img' that can wo

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Zhang Boyang
Hi, On 2022/12/21 10:43, Pete Batard via Grub-devel wrote: Hello all, On 2022.12.20 22:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is ch

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Zhang Boyang
Hi, On 2022/12/21 03:04, Glenn Washburn wrote: On Mon, 19 Dec 2022 23:33:29 +0800 Zhang Boyang wrote: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at module loading time. That

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Zhang Boyang
Hi, (sorry for duplicate emails because I forgot to add CCs) On 2022/12/21 06:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at m

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Pete Batard via Grub-devel
Hello all, On 2022.12.20 22:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at module loading time. That module will be rejected if

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Robbie Harwood
Zhang Boyang writes: > This patch add version information to GRUB modules. Specifically, > PACKAGE_VERSION is embedded as null-terminated string in .modver > section. This string is checked at module loading time. That module will > be rejected if mismatch is found. This will prevent loading modu

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Glenn Washburn
On Mon, 19 Dec 2022 23:33:29 +0800 Zhang Boyang wrote: > This patch add version information to GRUB modules. Specifically, > PACKAGE_VERSION is embedded as null-terminated string in .modver > section. This string is checked at module loading time. That module > will be rejected if mismatch is fou

[RFC PATCH] kern/dl: Add module version check

2022-12-19 Thread Zhang Boyang
This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at module loading time. That module will be rejected if mismatch is found. This will prevent loading modules from different versions of