Re: [RFC] Don't pass filename in multiboot command line

2009-11-24 Thread Samuel Thibault
Robert Millan, le Tue 24 Nov 2009 12:48:22 +0100, a écrit : > On Tue, Nov 24, 2009 at 12:34:37PM +0100, Robert Millan wrote: > > You're right. We should have documented this better. Perhaps by mentioning > > it in NEWS and in the release announcement. Sorry about that. > > And in spite of that,

Re: [RFC] Don't pass filename in multiboot command line

2009-11-24 Thread Robert Millan
On Tue, Nov 24, 2009 at 12:34:37PM +0100, Robert Millan wrote: > > You're right. We should have documented this better. Perhaps by mentioning > it in NEWS and in the release announcement. Sorry about that. And in spite of that, both versions comply with the letter of the Multiboot specificatio

Re: [RFC] Don't pass filename in multiboot command line

2009-11-24 Thread Robert Millan
On Tue, Nov 24, 2009 at 12:21:01PM +0100, Thomas Schwinge wrote: > Hello! > > On Fri, Aug 14, 2009 at 05:20:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Committed with improvements as ACK'ed by Robert on IRC > > I wasted at least half of a working day due to this change! (As well as > ot

Re: [RFC] Don't pass filename in multiboot command line

2009-11-24 Thread Thomas Schwinge
Hello! On Fri, Aug 14, 2009 at 05:20:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Committed with improvements as ACK'ed by Robert on IRC I wasted at least half of a working day due to this change! (As well as others wasted time, who where trying to help me.) Don't get me wrong -- in princ

Re: [RFC] Don't pass filename in multiboot command line

2009-08-28 Thread Robert Millan
On Thu, Aug 27, 2009 at 12:55:21PM +0200, Michal Suchanek wrote: > 2009/8/27 Seth Goldberg : > > Hi, > > > >  Any chance of having a 'multiboot1' module that can continue to pass the > > multiboot filename as arg0 ? > > > > >From the previous discussion of this feature I guess you can pass it > as

Re: [RFC] Don't pass filename in multiboot command line

2009-08-27 Thread Michal Suchanek
2009/8/27 Seth Goldberg : > Hi, > >  Any chance of having a 'multiboot1' module that can continue to pass the > multiboot filename as arg0 ? > >From the previous discussion of this feature I guess you can pass it as the first argument manually. HTH Michal __

Re: [RFC] Don't pass filename in multiboot command line

2009-08-26 Thread Seth Goldberg
Hi, Any chance of having a 'multiboot1' module that can continue to pass the multiboot filename as arg0 ? --S Quoting Seth Goldberg, who wrote the following on Wed, 26 Aug 2009: Hi there, Sorry for the delay, but I just discovered this broke booting of Solaris, and here's why: Solari

Re: [RFC] Don't pass filename in multiboot command line

2009-08-26 Thread Seth Goldberg
Hi there, Sorry for the delay, but I just discovered this broke booting of Solaris, and here's why: Solaris depends on knowing the name of the kernel file booted so it can locate the file within the boot archive (so that the kernel runtime linker can perform its relocations). Is there any

Re: [RFC] Don't pass filename in multiboot command line

2009-08-14 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 3, 2009 at 12:41 AM, Robert Millan wrote: > On Sun, Aug 02, 2009 at 11:42:43PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> >> No. Now we have an extra element that is always present and we want to >> >> remove but when we remove command line can be empty and code must >> >> handle it

Re: [RFC] Don't pass filename in multiboot command line

2009-08-02 Thread Robert Millan
On Sun, Aug 02, 2009 at 11:42:43PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> No. Now we have an extra element that is always present and we want to > >> remove but when we remove command line can be empty and code must > >> handle it correctly. > > > > Please try this patch. > I haven't trie

Re: [RFC] Don't pass filename in multiboot command line

2009-08-02 Thread Vladimir 'phcoder' Serbinenko
>> No. Now we have an extra element that is always present and we want to >> remove but when we remove command line can be empty and code must >> handle it correctly. > > Please try this patch. I haven't tried it because I know it will fail if someone does multiboot /payload Then cmdline_argc = 0;

Re: [RFC] Don't pass filename in multiboot command line

2009-08-02 Thread Robert Millan
On Sat, Aug 01, 2009 at 05:13:27PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > There's a much simpler way to address this.  Just add something like: > >> > > >> >  cmdline_argv = argv + 1; > >> >  cmdline_argc = argc - 1; > >> > > >> > at the beginning, and then use cmdline_argv and cmdline_

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 5:05 PM, Robert Millan wrote: > On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> > I agree with this.  But please wait a few days to give everyone a chance >> > to read it. >> > >> > Regarding the patch: >> > >> > There's a much simpler way to

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > I agree with this.  But please wait a few days to give everyone a chance > > to read it. > > > > Regarding the patch: > > > > There's a much simpler way to address this.  Just add something like: > > > >  cmdline_arg

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
> I agree with this.  But please wait a few days to give everyone a chance > to read it. > > Regarding the patch: > > There's a much simpler way to address this.  Just add something like: > >  cmdline_argv = argv + 1; >  cmdline_argc = argc - 1; > > at the beginning, and then use cmdline_argv and c

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 03:23:04PM +0200, Vladimir 'phcoder' Serbinenko wrote: > According to multiboot specification "It should be possible to write > compliant boot loaders that load the OS image from a variety of > sources, including floppy disk, hard disk, and across a network. " > It implicitl

[RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
According to multiboot specification "It should be possible to write compliant boot loaders that load the OS image from a variety of sources, including floppy disk, hard disk, and across a network. " It implicitly says that kernel shouldn't care about filename used by bootloader. About commandline